unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Fuchs <asf@boinkor.net>
To: Andrea Corallo <akrl@sdf.org>
Cc: 42761@debbugs.gnu.org
Subject: bug#42761: 28.0.50; [feature/native-comp] allow customizing command line/driver options?
Date: Mon, 10 Aug 2020 22:34:03 -0400	[thread overview]
Message-ID: <CAOHxn7ziejh3dsLeosythkLG_L34vG0szyB7OVhavQoLasLKKA@mail.gmail.com> (raw)
In-Reply-To: <xjfv9hsb68z.fsf@sdf.org>

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

On Sun, Aug 9, 2020 at 3:58 AM Andrea Corallo <akrl@sdf.org> wrote:
> From the patch:
> > + #ifdef LIBGCCJIT_HAVE_gcc_jit_context_add_command_line_option
> > + DEF_DLL_FN (void, gcc_jit_context_add_driver_option,
> > +             (gcc_jit_context *ctxt, const char *optname));
> > + #endif
> [...]
> > + #ifdef LIBGCCJIT_HAVE_gcc_jit_context_add_command_line_option
> > +   LOAD_DLL_FN (library, gcc_jit_context_add_driver_option);
> > + #endif
>
> The above should not be ifdef'd as they allow the function to be used
> only if present in the library in use at runtime on Windows systems.
>
> Unfortunatelly we do not have such system for Linux where the decision
> to include the call is done at compile time.  So unless we implement
> that too also the call site has to be a little changed to handle this.
>
> Please have a look for that into in Fcomp_libgccjit_version where we use
> gcc_jit_version_*.  These are the only "optional" libgccjit entry point
> we used so far.

Ah, I misread the #ifdef condition above those. Makes sense, I've adjusted
the branch and added one more commit that should ensure we pass the
`comp-native-driver-options' to async compilation child processes
correctly.

This patch builds on my system, builds on darwin under nix (with some
additional changes to emit "-L" library path entries), and asynchronously
compiles code, too!

Cheers,
-- 
Andreas Fuchs, (http://|im:asf@|mailto:asf@)boinkor.net, antifuchs

[-- Attachment #2: Type: text/html, Size: 1917 bytes --]

  reply	other threads:[~2020-08-11  2:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-08  2:51 bug#42761: 28.0.50; [feature/native-comp] allow customizing command line/driver options? Andreas Fuchs
2020-08-08 18:30 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-08 19:13   ` Andreas Fuchs
2020-08-08 19:31     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-08 20:29       ` Andreas Fuchs
2020-08-09  7:58         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-11  2:34           ` Andreas Fuchs [this message]
2020-08-13 18:46             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-19 14:37               ` Andreas Fuchs
2020-08-19 15:41                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-20 14:12                   ` Andreas Fuchs
2020-08-20 16:43                     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-22  4:14                       ` Andreas Fuchs
2020-08-24  8:49                         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-26 19:07                           ` Andreas Fuchs
2020-08-26 19:56                             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOHxn7ziejh3dsLeosythkLG_L34vG0szyB7OVhavQoLasLKKA@mail.gmail.com \
    --to=asf@boinkor.net \
    --cc=42761@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).