From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Fuchs Newsgroups: gmane.emacs.bugs Subject: bug#42761: 28.0.50; [feature/native-comp] allow customizing command line/driver options? Date: Sat, 8 Aug 2020 16:29:20 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000247d6305ac6394e0" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24313"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42761@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 08 22:30:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4VTm-0006D3-Ns for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Aug 2020 22:30:10 +0200 Original-Received: from localhost ([::1]:48240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4VTl-0006zr-QW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Aug 2020 16:30:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4VTe-0006zh-O7 for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 16:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4VTe-0002It-E9 for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 16:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4VTe-0003vQ-8i for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 16:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Fuchs Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Aug 2020 20:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42761 X-GNU-PR-Package: emacs Original-Received: via spool by 42761-submit@debbugs.gnu.org id=B42761.159691857915034 (code B ref 42761); Sat, 08 Aug 2020 20:30:02 +0000 Original-Received: (at 42761) by debbugs.gnu.org; 8 Aug 2020 20:29:39 +0000 Original-Received: from localhost ([127.0.0.1]:59659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4VTH-0003uQ-1T for submit@debbugs.gnu.org; Sat, 08 Aug 2020 16:29:39 -0400 Original-Received: from mail-ed1-f53.google.com ([209.85.208.53]:34463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4VTE-0003uC-Oo for 42761@debbugs.gnu.org; Sat, 08 Aug 2020 16:29:38 -0400 Original-Received: by mail-ed1-f53.google.com with SMTP id bs17so3701517edb.1 for <42761@debbugs.gnu.org>; Sat, 08 Aug 2020 13:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boinkor-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XsUmQRC+44LSKqPGuVDIPrIAyFjtqPkQ3lnCaaiiw+A=; b=phiyC8nRbEi0asX5CHiP8Nu1HTWwZK1wu6f6EF1YONQWryyfk0tgEgFpS0RdbsU7ID Ux/YNxdp4dmrbutLlsKlI0b087hEk6fcFg+KODGt3ZoUck5RqYIKqjgZeOuuD/vf8CgW qTpOyxdXc4r4FanZqHgMnaeV/YAiZkl+TtlqFmNvS5AWaCHiX07+b5HXYMntI5POv3Pc /cx3jstZ4w+cCIqE01Gsj/b3doZpClEEdWo0P87rVHwTh8OdH+C7YqjWelSFKbFtn5tH j6MisoUX/km95ZIjaV46oGtwHjhKp7izEzy1lPCpd9581J4Go5yt5WME25vqPvDdItTv 7TSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XsUmQRC+44LSKqPGuVDIPrIAyFjtqPkQ3lnCaaiiw+A=; b=pDYSwq7PfDSTvxs91Ja5TDlMXwX5IzVjZQFPEg6id1jSWSklgFVNyu70+yi0o4MbVl efYegDtjCbKzAwihEw66kBPt3YzpVO6LX1zxp80HAC15BGJo7MXlGou2p3GLPQM0Qpyt sEui2kdHmvOoTPsOzvtrWEKGZ28KaGSXApAJmnTxCys7EdIQan4BiA4JXxhfV6C5HEto sDG3GBxIjb0UUIRS0G9jKLdQ+HM3Dh4W1zhIsCHpx9Ov6Jt2ZzjXg/T++19YTu+hGOrY MkKShJuE/iiNVcTzrVBy6D2iFTl3WaB73T7SoE89wB5Y5F/xDPNKNK0agbKEzeXuZwEn ea0A== X-Gm-Message-State: AOAM533W2pciNGmB4/yySh3MhFy/4E5XWCTGO30Hh5UAzgCLaeMYIDhN E3d/odzReIdywQNoNk/7bVyynyZWxcMWrJ3GYFn4Pw== X-Google-Smtp-Source: ABdhPJxbt3nSnBTDuBCHYSQ/5984+vDRBcffwYm8QLJGUHGvLXVlLJIhSFfpdsGe/x7731oXqBl7ZtuDNBXSZZvWztI= X-Received: by 2002:aa7:d654:: with SMTP id v20mr14744255edr.314.1596918570706; Sat, 08 Aug 2020 13:29:30 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184371 Archived-At: --000000000000247d6305ac6394e0 Content-Type: text/plain; charset="UTF-8" On Sat, Aug 8, 2020 at 3:31 PM Andrea Corallo wrote: > Regarfing the gcc version: ne option would be to just ifdef the body of > add_driver_options using > LIBGCCJIT_HAVE_gcc_jit_context_add_command_line_option and making clear > that the customize is effective only with GCC>=9. > > But I think would be better to raise an error if > comp-native-driver-options is not empty and > gcc_jit_context_add_command_line_option is not available. > > I think we should make this clear in the customize doc. Agreed - that makes sense. I've adjusted the patch accordingly, and de-untabified the files that I touched (sorry about the whitespace churn, leftover customization from another C codebase): https://github.com/emacs-mirror/emacs/compare/feature/native-comp...antifuchs:allow-setting-driver-options > Do you already have copyright paperwork done? I signed copyright assignment papers for gnus back in 2001, but those are only valid for those changes to gnus. I've requested assignment paperwork for GNU Emacs changes now. Cheers, -- Andreas Fuchs, (http://|im:asf@|mailto:asf@)boinkor.net, antifuchs --000000000000247d6305ac6394e0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Aug 8, 2020 at 3:31 PM Andrea Corallo <akrl@sdf.org> wrote:
> Regarfing the = gcc version: ne option would be to just ifdef the body of
> add_drive= r_options using
> LIBGCCJIT_HAVE_gcc_jit_context_add_command_line_opt= ion and making clear
> that the customize is effective only with GCC&= gt;=3D9.
>
> But I think would be better to raise an error if> comp-native-driver-options is not empty and
> gcc_jit_context_= add_command_line_option is not available.
>
> I think we should= make this clear in the customize doc.

Agreed - that makes sense. I&= #39;ve adjusted the patch accordingly, and
de-untabified the files that = I touched (sorry about the whitespace churn,
leftover customization from= another C codebase):

ht= tps://github.com/emacs-mirror/emacs/compare/feature/native-comp...antifuchs= :allow-setting-driver-options

> Do you already have copyright= paperwork done?

I signed copyright assignment papers for gnus back = in 2001, but those
are only valid for those changes to gnus. I've re= quested assignment
paperwork for GNU Emacs changes now.

Cheers,--
Andreas Fuchs, (http://|im:asf@|mailto:asf@= )boinkor.net, antifuchs
--000000000000247d6305ac6394e0--