From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Evgeny Zajcev Newsgroups: gmane.emacs.bugs Subject: bug#39491: 28.0.50; two bugs in battery-upower Date: Sun, 26 Apr 2020 18:44:09 +0300 Message-ID: References: <83mu9tedsh.fsf@gnu.org> <5A4C6466-FB4B-484F-BF29-91762AFB46F3@gmail.com> <83wo625mo6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c5657505a43378ef" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="13771"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39491@debbugs.gnu.org, rms@gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 26 17:46:28 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSjUB-0003UU-TA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Apr 2020 17:46:28 +0200 Original-Received: from localhost ([::1]:33672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSjUA-0008Ai-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Apr 2020 11:46:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38626) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSjSp-0006qe-5p for bug-gnu-emacs@gnu.org; Sun, 26 Apr 2020 11:45:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSjSo-0005zE-Jp for bug-gnu-emacs@gnu.org; Sun, 26 Apr 2020 11:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSjSo-0005yb-7D for bug-gnu-emacs@gnu.org; Sun, 26 Apr 2020 11:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSjSo-0002t2-4w for bug-gnu-emacs@gnu.org; Sun, 26 Apr 2020 11:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Evgeny Zajcev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Apr 2020 15:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39491 X-GNU-PR-Package: emacs Original-Received: via spool by 39491-submit@debbugs.gnu.org id=B39491.158791586811043 (code B ref 39491); Sun, 26 Apr 2020 15:45:02 +0000 Original-Received: (at 39491) by debbugs.gnu.org; 26 Apr 2020 15:44:28 +0000 Original-Received: from localhost ([127.0.0.1]:33942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSjSG-0002s3-HZ for submit@debbugs.gnu.org; Sun, 26 Apr 2020 11:44:28 -0400 Original-Received: from mail-lf1-f51.google.com ([209.85.167.51]:45431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSjSE-0002rp-5Z for 39491@debbugs.gnu.org; Sun, 26 Apr 2020 11:44:26 -0400 Original-Received: by mail-lf1-f51.google.com with SMTP id f8so11701226lfe.12 for <39491@debbugs.gnu.org>; Sun, 26 Apr 2020 08:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dMtLbfHNoYFBW7IwVirXM39gdz52ixZa35BFam0a0GY=; b=DAk5QcGYhHV+rlNWah92LiVaxnbVYe6Ye+1C4TH6uCziRnH+Gkb4U+bFuU4QOHW4JD DsxeABeaHztjqKYs04Km2tnOpB49LFaHQGgBr/NZJsIKoknLcvU1HImz0k7uQTE6KTSB gZUpEAKmqMYaGHXeIk5UbpJjJJoJGAMf052VtkSR5bcVEVzj72stds9UeozxvkfZXgc3 Ou0OugGGvedv1QcCpyQqN8EPhIXbOlHlcA+Wqy39hBe8f4UAyi90O2CnOYwXBjUZMyRD GcLYDPnEh9TxGlEvt8F2FWk/t8+JX0WeC51VpH7jhWKeBnqzxfH1h0RXBgZh/88REoQg +Hww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dMtLbfHNoYFBW7IwVirXM39gdz52ixZa35BFam0a0GY=; b=uOucfFqVTzRrsugEoWjdydTzRdznCIO8iifRiR5N8W01Da4j2vTpTef8cuYsKAzuFa gS0Rg4tevyt8Hmgn1IQWiOK0Z2ZZow7zSB2ZJeshIlZVVFsLOIFpWUFreuArfF8koKYQ jmGNkdsyqE0yYTR4nrX2EXhhRkjHSXr9TqpfPIR2uhho0LiliF4vhRvS8GXJDqpbxBdn fAVWaW1eT4/h9L3ABJI4UIv6hAGJume/5zLs/ZjXWunyKVSFcNZ1enaClLOJ0/994uQP MJi4VZzzQzFPsOVIqUDSDjzazi6jvlyFtgELMAS8Zq2CsKm+Mn4LNKq8F+L+ffi5Nk7B zuRw== X-Gm-Message-State: AGi0PuYqzmHhe25D+4HNG7M7VQo7vWaQeuCHDtVDJ6VskUuN1PrQ6nxh Ym2SdezRFvcAZn9PLUbqzDn5fDQGzmz+qntCUo8= X-Google-Smtp-Source: APiQypKyqQoKQHwzAa4n0+p6eDTRtfViyLPI8vA9fuym7TxHXEHJb8FFzejKQchihwFamahKnjlnKnbbVWouhU+srwE= X-Received: by 2002:a05:6512:308e:: with SMTP id z14mr12873640lfd.110.1587915860041; Sun, 26 Apr 2020 08:44:20 -0700 (PDT) In-Reply-To: <83wo625mo6.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179079 Archived-At: --000000000000c5657505a43378ef Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D0=B2=D1=81, 26 =D0=B0=D0=BF=D1=80. 2020 =D0=B3. =D0=B2 17:47, Eli Zaretsk= ii : > > From: lg.zevlg@gmail.com > > Date: Sat, 8 Feb 2020 12:10:46 +0400 > > Cc: 39491@debbugs.gnu.org, rms@gnu.org, > > Stefan Monnier > > > > >> However, that function has a design flaw: it reports on just the fir= st > > >> battery in the list. battery-upower-device-list correctly returns a > > >> list with an element for each battery, but battery-upower finds only > one > > >> of them (the first one in the list) and ignores the others. > > >> > > >> The old code handle all the batteries and added the energy quantitie= s > > >> so as to report accurately the total power available and overall > > >> fraction of charge. I wrote that code myself, around 10 years ago. > > >> > > >> Please restore the lost functionality. > > > > > > Evgeny, could you please look into fixing this? > > > > > > > OK, we should generalize multi-battery code then, so each status func > won=E2=80=99t reimplement multi battery handling. > > > > I=E2=80=99ll look at it tomorrow > > Evgeny, any progress in fixing this? > Sorry for the delay, I have some progress, but not yet ready. I'm pretty busy these days because I'm working for large company that provides video-streaming service and we experiencing extreme rise in number of the active users and everybody wants to watch something all the day :) --=20 lg --000000000000c5657505a43378ef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
=D0=B2=D1=81, 26 =D0=B0=D0=BF=D1=80. = 2020 =D0=B3. =D0=B2 17:47, Eli Zaretskii <eliz@gnu.org>:
> From: = lg.zevlg@gmail.com
> Date: Sat, 8 Feb 2020 12:10:46 +0400
> Cc: 39491@d= ebbugs.gnu.org, rms@gn= u.org,
>=C2=A0 Stefan Monnier <monnier@iro.umontreal.ca>
>
> >> However, that function has a design flaw: it reports on just = the first
> >> battery in the list.=C2=A0 battery-upower-device-list correct= ly returns a
> >> list with an element for each battery, but battery-upower fin= ds only one
> >> of them (the first one in the list) and ignores the others. > >>
> >> The old code handle all the batteries and added the energy qu= antities
> >> so as to report accurately the total power available and over= all
> >> fraction of charge.=C2=A0 I wrote that code myself, around 10= years ago.
> >>
> >> Please restore the lost functionality.
> >
> > Evgeny, could you please look into fixing this?
> >
>
> OK, we should generalize multi-battery code then, so each status func = won=E2=80=99t reimplement multi battery handling.
>
> I=E2=80=99ll look at it tomorrow

Evgeny, any progress in fixing this?

So= rry for the delay, I have some progress, but not yet ready.=C2=A0 I'm p= retty busy these days because I'm working for large company that provid= es video-streaming service and we experiencing extreme rise in number of th= e active users and everybody wants to watch something all the day :)

--
lg
--000000000000c5657505a43378ef--