From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#72426: 29.2.50; comint-pager doesn't affect async-shell-command Date: Sat, 3 Aug 2024 06:47:10 -0400 Message-ID: References: <86sevmupgo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000002088b5061ec52bd3" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="764"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72426@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 03 12:48:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saCIs-000Abz-K7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Aug 2024 12:48:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saCIa-0006fM-5I; Sat, 03 Aug 2024 06:47:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saCIY-0006fC-VM for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 06:47:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saCIY-0007k7-L5 for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 06:47:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=IfSyByOteYvm5FujMXsz/T5TXnVWQJJfC+N0SWpMZpo=; b=s5wUFh11gGc854JnoNbHx3qIHFpq28SPm55lnNHcX1jeDbJeoyzd43JdYyIekS7Hp0IK5iT2FAxccGpTRlQ3FbtUd4hnIMJZ0dsCpHqIo9JXyWo+BKq3kBXZxDG2ynNlk9D6r+dI8eucd5bf8/CGkr6r8as8t//rGfJjp7CmGgWV2jtHD40FvcYG35AR166PjssREsKWzxF1yZaeDJR44nZBmdRqs+e6f4AvHPZfq2csSN5dtcc03zKLbY+u22eivCTfBVaZqSFh/yjQZtdFbvpcZx5ZPOUcpOEoYzk2eCUOvtRv9K84NfVouYBPLpwbnvXEwBgDWaDdo8i1Be2EJg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1saCIr-0000ns-Tj for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 06:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Aug 2024 10:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72426 X-GNU-PR-Package: emacs Original-Received: via spool by 72426-submit@debbugs.gnu.org id=B72426.17226820713067 (code B ref 72426); Sat, 03 Aug 2024 10:48:01 +0000 Original-Received: (at 72426) by debbugs.gnu.org; 3 Aug 2024 10:47:51 +0000 Original-Received: from localhost ([127.0.0.1]:54119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saCIg-0000nM-9c for submit@debbugs.gnu.org; Sat, 03 Aug 2024 06:47:51 -0400 Original-Received: from mxout1.mail.janestreet.com ([38.105.200.78]:54439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saCId-0000n7-RR for 72426@debbugs.gnu.org; Sat, 03 Aug 2024 06:47:48 -0400 Original-Received: from mail-ej1-f69.google.com ([209.85.218.69]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) (Exim 4.98) id 1saCIE-00000002z35-0I98 for 72426@debbugs.gnu.org; Sat, 03 Aug 2024 06:47:22 -0400 Original-Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a7abee2b4b0so797278966b.1 for <72426@debbugs.gnu.org>; Sat, 03 Aug 2024 03:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; t=1722682041; x=1723286841; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IfSyByOteYvm5FujMXsz/T5TXnVWQJJfC+N0SWpMZpo=; b=IDAX/L18HHApaX2j22hiCnVCs2BY6gTqvjo7H3gseuaV/Abjl/2n0ARyR1TjtI+egh RBiCCr9OteUPXNmq97DXyliXmBtpY5U0o08NpFfp098rCQEfkqKLHyUX/pvGIu0lvFYG wSqt9g5J8E9fDnWKaAH0NOcUc3QZqz06xB94c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1722682042; bh=IfSyByOteYvm5FujMXsz/T5TXnVWQJJfC+N0SWpMZpo=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=k+jyj4RqL3Uda0/HgzDoHy1xH2Pih7lsT7d/JRcLuKmy7ofHJHf2KHV7RkbGFgypW +MGxOjm69ZUkG+ef9V7lKGxDovvj9AJaHoJyvS9S3RRc4IZGQOFNwZON2Iydtlnjc9 tm7R9qvuTkcD75fUA2lrV9rppV9e+AhPou7x0po7aUXo30IbTX2C5usZWdy/yz3Lhg JdahUitF/wCJ9LgVUVejoimyCCdNxBk7CAU5IQAYt/1oOal+4mfUsHF6AoKosibeMJ H6AshBiPfo9MKLr49z9DP9N78MM88y2Yw+zy9o6bGvRQQ352+zLwoaZ6pKJTzHFkBt Hzq3ZPX/izcUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722682041; x=1723286841; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IfSyByOteYvm5FujMXsz/T5TXnVWQJJfC+N0SWpMZpo=; b=kIFW4xd8dQMIQ+2/tjOGMb63VWXQg49tRL9PdjtGEi69MvbmBdCcmpHCTKtCilFHTJ ivDJcaUb/CYI/HDEJUdlo6ZdFP3EO6AYCPWW+tEVCEZGWLKkYy0w29Xd+5ch6nWrEFWG EU2wpQYir+wIrcGbeFlBpxYyalID+nFxRiTLMVCw6zXfYrc8jrTvCxWVoztbw04kdbd0 zR7c202sVlMA9BAEX88KkFqveEh7sOwbvfsNdvmS9jfDnQ5POWeMubPEatZMYIhWE1pC UDih0is2fsoJ2uQlR5w50JSuNZQqBENqS7Yft01f844y8jk4+Q2BjKuv59fEfj1R+nD+ 3+4Q== X-Gm-Message-State: AOJu0YyJ/bg4frCbW0ciFkG1KGRI6sxXPAke2xmZC2lNT8M0a5ngWYLT 1hG1GE7JVRuEUrjkpqW34hWc1PIRhswfcIg2PjtsKVhevahvbHPMdF2ZKeJ3aZDS9KlE0+FHAXL P/THX5l//EK2xEZGbiJdMHyJWeYVDx8KShiL2v4CGQkP8cVD325tU3vHITFQiCnxCLpoQQI8Gl4 cMdLGTdGqbEhrwqMg7G/1nn/OFmw== X-Received: by 2002:a17:906:6a08:b0:a7a:a7b8:ada6 with SMTP id a640c23a62f3a-a7dc4ffa91dmr503732566b.39.1722682041596; Sat, 03 Aug 2024 03:47:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGWjSsEaoMDJcyc4sZzEMmAWoHzqY3kXsrXcdyfsnRrkYZDm9Ad65L/oOKwqHCebGjNUs+lt37JvjEXjkErTNk= X-Received: by 2002:a17:906:6a08:b0:a7a:a7b8:ada6 with SMTP id a640c23a62f3a-a7dc4ffa91dmr503730966b.39.1722682041200; Sat, 03 Aug 2024 03:47:21 -0700 (PDT) In-Reply-To: <86sevmupgo.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289672 Archived-At: --0000000000002088b5061ec52bd3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Aug 3, 2024, 1:48=E2=80=AFAM Eli Zaretskii wrote: > > From: Spencer Baugh > > Date: Fri, 02 Aug 2024 14:35:25 -0400 > > > > > > 1. PAGER=3Dless emacs -Q > > 2. (setq comint-pager "cat") > > 3. (async-shell-command "echo $PAGER") > > 4. Observe "less" rather than "cat". > > > > I intended async-shell-command to also be affected when I added > > comint-pager; a patch to fix this will follow. > > Thanks, I don't think this is right: comint stuff should not affect > lower-level primitives, it should only affect comint and its callers. > comint-terminfo-terminal affects async-shell-command, why not this? If the fact that the variable is in comint is the problem, I can rename it and move it elsewhere. Lisp programs that use async-shell-command can arrange for > process-environment to have PAGER=3DSOMETHING as they see fit. > My intention is primarily to affect interactive usage of async-shell-command. > --0000000000002088b5061ec52bd3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Aug 3, 2024, 1:48=E2=80=AFAM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Spencer Baugh <sbaugh@janestreet.com= >
> Date: Fri, 02 Aug 2024 14:35:25 -0400
>
>
> 1. PAGER=3Dless emacs -Q
> 2. (setq comint-pager "cat")
> 3. (async-shell-command "echo $PAGER")
> 4. Observe "less" rather than "cat".
>
> I intended async-shell-command to also be affected when I added
> comint-pager; a patch to fix this will follow.

Thanks, I don't think this is right: comint stuff should not affect
lower-level primitives, it should only affect comint and its callers.

comint= -terminfo-terminal affects async-shell-command, why not this?

If the fact that the variable is in c= omint is the problem, I can rename it and move it elsewhere.

Lisp programs that use async-shell-command can arrange for
process-environment to have PAGER=3DSOMETHING as they see fit.

My intention = is primarily to affect interactive usage of async-shell-command.
--0000000000002088b5061ec52bd3--