From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#62759: [PATCH] add support for prompting for projects by name Date: Mon, 10 Apr 2023 20:08:19 -0400 Message-ID: References: <2fb028b1-a9ad-648d-9d27-2107e7e4833a@gutov.dev> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000722f4305f9044a0e" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7859"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62759-done@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 11 02:09:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm1ZZ-0001uV-Ri for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Apr 2023 02:09:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pm1ZK-00054J-AU; Mon, 10 Apr 2023 20:09:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm1ZG-00053z-JC for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 20:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pm1ZG-0003HN-9q for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 20:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pm1ZG-0002Q0-08 for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 20:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Apr 2023 00:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62759 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62759-done@debbugs.gnu.org id=D62759.16811717159259 (code D ref 62759); Tue, 11 Apr 2023 00:09:01 +0000 Original-Received: (at 62759-done) by debbugs.gnu.org; 11 Apr 2023 00:08:35 +0000 Original-Received: from localhost ([127.0.0.1]:36166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm1Yo-0002PH-W3 for submit@debbugs.gnu.org; Mon, 10 Apr 2023 20:08:35 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:33267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm1Yn-0002P3-PO for 62759-done@debbugs.gnu.org; Mon, 10 Apr 2023 20:08:34 -0400 Original-Received: from mail-yw1-f198.google.com ([209.85.128.198]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) (Exim 4.96) id 1pm1Yh-005gmF-1l for 62759-done@debbugs.gnu.org; Mon, 10 Apr 2023 20:08:28 -0400 Original-Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-54ee0b7dbdbso69143277b3.0 for <62759-done@debbugs.gnu.org>; Mon, 10 Apr 2023 17:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; t=1681171708; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7NU16uQCOWw5u927pH98sLTwbIdtS7DmJe7hF3OApIQ=; b=ObX9/oklBuaa3vm6HxHW3l0xpLgrAXC0YTGqxtl3yyFkUYcGYkXeFaJzhAF44SyaLz o9vEuRTQJUeu3hXJ4AEKKlCSdoXRafZIMptFSy3f1Gk7HXKXI5YVAzAPitPrb89aJGyD 7vtx5XFKcCXayORsunZMeXwIdAP0JzWIsRblQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681171708; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7NU16uQCOWw5u927pH98sLTwbIdtS7DmJe7hF3OApIQ=; b=mz6uSQ/Kvhi9aOcQkew7PeUBCv2MjwpPbND6K0z3nG/K8Ya90i7DCr6PlwOlpo5mGs Kmhqwf9iRJqpGq+3xiJZ6xyxjSSwTHyS81fUKJOxp6wsuhnAoo3Ci+hm7/AeKL48eFQk Eo4QM8n3FSGf22Z3cIiipMq1YhVPV1jDeGYSd+0IBrI7U5RAYHgbUtJn+6HSgAlbsHm8 tOinwq+NeLD0pkkyZqT/CNfBOjsJqEYYdCAX/zLvZA37lTd4zqH3+5J+Bv0a4AHEkp2/ kskZ+P41kcx0IdvI6RJmxHCg5A4wp3pVShG8JeHTupoPa1F4VcBXR7mR/QT+KxslR97s M9wA== X-Gm-Message-State: AAQBX9cIR2aA4P3xDQYBuCqpNr5pUmqoyAOsVrKW9+RZQZs+u68DQO8s vIV1CCmuz8eZc7ZcSA3uhbc7rTyGQnjUnhJRswcnyNi/aFXARSGu2Jbn2fgUpPrlwB3AnsOvXd2 NnI++bbfLEOyO1n4oWZ0ur/ACuYBLQsz2kh05 X-Received: by 2002:a25:d649:0:b0:b8a:7b2d:6555 with SMTP id n70-20020a25d649000000b00b8a7b2d6555mr298827ybg.9.1681171708004; Mon, 10 Apr 2023 17:08:28 -0700 (PDT) X-Google-Smtp-Source: AKy350ZZhEqBqs337o51+sm7icf6Xr46f4jY2uMXQOYExFCHJSUZqfqegXtWxzC3ufIxPDfHS9hg7xAhdpWYlc5KB+Y= X-Received: by 2002:a25:d649:0:b0:b8a:7b2d:6555 with SMTP id n70-20020a25d649000000b00b8a7b2d6555mr298813ybg.9.1681171707728; Mon, 10 Apr 2023 17:08:27 -0700 (PDT) In-Reply-To: <2fb028b1-a9ad-648d-9d27-2107e7e4833a@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259614 Archived-At: --000000000000722f4305f9044a0e Content-Type: text/plain; charset="UTF-8" On Mon, Apr 10, 2023, 19:20 Dmitry Gutov wrote: > Hi! Thanks for the patch. Pushed to master. > > Next time please also add the full common message, though. > Sorry, will do. I was expecting to need to iterate through some review cycles :) Also note that the idea behind the current default (and also why it > doesn't return a project instance: just the dir) was to avoid visiting > all the directories -- because some might be unavailable at this exact > moment (e.g. remote, over Tramp, and currently disconnected), and some > simply slow. Yes, I figured that was the reason. I should also mention that I was thinking about automatically pruning zombie projects (my backend yields lots of those) but instead I just had project-prompt-project-name skip zombies, for exactly this reason (that it avoids excess FS access). It shouldn't hurt to have this as an alternative behavior, though. > --000000000000722f4305f9044a0e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Apr 10, 2023, 19:20 Dmitry Gutov <dmitry@gutov.dev> wrote:
Hi! Thanks for the patch. Pushed to master.

Next time please also add the full common message, though.
=

Sorry, will do. I= was expecting to need to iterate through some review cycles :)=C2=A0
=

Also note that the idea behind the current default (and also why it
doesn't return a project instance: just the dir) was to avoid visiting =
all the directories -- because some might be unavailable at this exact
moment (e.g. remote, over Tramp, and currently disconnected), and some
simply slow.

Yes, I figured that was the reason. I should also mention that I = was thinking about automatically pruning zombie projects (my backend yields= lots of those) but instead I just had project-prompt-project-name skip zom= bies, for exactly this reason (that it avoids excess FS access).

It shouldn't hurt to have this as an alternative behavior, though.
--000000000000722f4305f9044a0e--