From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#62229: 29.0.60; It's no longer possible to customize the xref ring size Date: Fri, 17 Mar 2023 08:02:22 -0400 Message-ID: References: <83v8izeqqv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000026f0a005f7175ad4" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7658"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62229@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 17 13:03:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd8nm-0001lp-9T for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Mar 2023 13:03:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pd8nb-0000YO-3L; Fri, 17 Mar 2023 08:03:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd8nW-0000Y0-DH for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 08:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pd8nW-00049L-5P for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 08:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pd8nW-0007YN-0c for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 08:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Mar 2023 12:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62229 X-GNU-PR-Package: emacs Original-Received: via spool by 62229-submit@debbugs.gnu.org id=B62229.167905456229010 (code B ref 62229); Fri, 17 Mar 2023 12:03:01 +0000 Original-Received: (at 62229) by debbugs.gnu.org; 17 Mar 2023 12:02:42 +0000 Original-Received: from localhost ([127.0.0.1]:43871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd8nC-0007Xp-2W for submit@debbugs.gnu.org; Fri, 17 Mar 2023 08:02:42 -0400 Original-Received: from mxout1.mail.janestreet.com ([38.105.200.78]:36989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd8n9-0007XZ-Oq for 62229@debbugs.gnu.org; Fri, 17 Mar 2023 08:02:40 -0400 Original-Received: from mail-yw1-f198.google.com ([209.85.128.198]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) (Exim 4.96) id 1pd8n3-001ata-1Y for 62229@debbugs.gnu.org; Fri, 17 Mar 2023 08:02:34 -0400 Original-Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-5417f156cb9so44637807b3.8 for <62229@debbugs.gnu.org>; Fri, 17 Mar 2023 05:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; t=1679054554; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ylZzEJpzX2bWqV0lNpAojGAGVbijxQxk+UR2XmoKBj8=; b=qYAucfh6gfUgr8dASSiBGI7MCB0tClb45OcHPPl/1KgxZSDVZUtNIn8XNEnD66SlvN BecQ9XSQSfVUlphUyeFzlMmkos4Ikjh5NENQjnvJtIJwddsJfWhExvEK9B/YwicpYCNj d93tlSi5oBOZSPfCsTqfKquUtyC/rsiMU0DME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679054554; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ylZzEJpzX2bWqV0lNpAojGAGVbijxQxk+UR2XmoKBj8=; b=WrUqtEYbWDPdU9qbjT5MW42VVsA2aFU1CzgBu6zN4fnKAylM6l0unY5GkGB6UFjkTF wMayCdaCjd3V86JGnNluoq5UZsEgvjKt0hJcytwlxnr8Ce0XGLyTQj2LmNDuLV4jJYrw +/XIQK60viFxt1N0gRH3cf2ZijSfxFw+KaJKlJ5Dyr8tYfTwuX3AU/fdHLl88Du8bmOW nq306KY6i37itKlGvCEazJFMJc7+G235SgVhqukNluAQ4moa7ciGvz62bFLhyh/WUuPp BUJn6Qe3l2Gx0wrKG82eZr+K5HqE/Ff4eLOaoGuMkdpXhqd2b/4F+mc6fAEFdZoj3lA5 Xiog== X-Gm-Message-State: AO0yUKX25jr/sNxb4EwHNEPDqaLZ0LNjf2guJM4YF12Kr9WwUPXq8Kua Gqxg7JUBHwXQpGNMGVblN5GgdibWTMIJBUnXnOC75E7xZ654hwSWuxH4/SdZdWps7zCEXSkpQKe B54j8+5xJFhGqbSYDiZ1ljCQri8ymq4OoDN3/Ew== X-Received: by 2002:a25:8d8e:0:b0:b30:2539:a2b0 with SMTP id o14-20020a258d8e000000b00b302539a2b0mr15852747ybl.9.1679054552981; Fri, 17 Mar 2023 05:02:32 -0700 (PDT) X-Google-Smtp-Source: AK7set+v/e4W7U9vzC776MQcTTFMok5m5F88+wwc0Hsda9YfpOshPiUbH4WEp+qD8bqAcoFm67PQyS9nxwLQUo/kg6I= X-Received: by 2002:a25:8d8e:0:b0:b30:2539:a2b0 with SMTP id o14-20020a258d8e000000b00b302539a2b0mr15852717ybl.9.1679054552355; Fri, 17 Mar 2023 05:02:32 -0700 (PDT) In-Reply-To: <83v8izeqqv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258074 Archived-At: --00000000000026f0a005f7175ad4 Content-Type: text/plain; charset="UTF-8" On Fri, Mar 17, 2023, 04:17 Eli Zaretskii wrote: > > From: Spencer Baugh > > Date: Thu, 16 Mar 2023 18:11:06 -0400 > > > > > > Emacs 28 had the function xref-set-marker-ring-length and the > > customizable variable xref-marker-ring-length which allowed growing > > the amount of history kept by xref. > > > > This feature has been lost in Emacs 29; that variable has been > > obsoleted with no replacement. > > > > It's not clear, looking at the change, whether this is because the > > size is now infinite or not. The same commit that obsoleted that > > variable added the similar tags-location-ring-length. However that > > variable has no docstring, no customize hooks, and setting it has no > > effect unless tags-reset-tags-tables is called. > > > > At the very least, all this should be documented better, and the > > obsoleting of this function and variable should be mentioned in NEWS. > > If the history is indeed infinite now, that should be mentioned in > > NEWS as well. > > Indeed, that change paid very little attention to documenting the > important aspects of adding Xref history and using it instead of a > limited-size ring. We should do better. > > I've now attempted to add the missing documentation; please take a > look at the latest emacs-29 branch. > Yes, looks great! Covers all my concerns! > --00000000000026f0a005f7175ad4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Mar 17, 2023, 04:17 Eli Zaretskii <eliz@gnu.org> wrote:
> From: Spencer Baugh <sbaugh@janestreet.com>
> Date: Thu, 16 Mar 2023 18:11:06 -0400
>
>
> Emacs 28 had the function xref-set-marker-ring-length and the
> customizable variable xref-marker-ring-length which allowed growing > the amount of history kept by xref.
>
> This feature has been lost in Emacs 29; that variable has been
> obsoleted with no replacement.
>
> It's not clear, looking at the change, whether this is because the=
> size is now infinite or not.=C2=A0 The same commit that obsoleted that=
> variable added the similar tags-location-ring-length.=C2=A0 However th= at
> variable has no docstring, no customize hooks, and setting it has no > effect unless tags-reset-tags-tables is called.
>
> At the very least, all this should be documented better, and the
> obsoleting of this function and variable should be mentioned in NEWS.<= br> > If the history is indeed infinite now, that should be mentioned in
> NEWS as well.

Indeed, that change paid very little attention to documenting the
important aspects of adding Xref history and using it instead of a
limited-size ring.=C2=A0 We should do better.

I've now attempted to add the missing documentation; please take a
look at the latest emacs-29 branch.

Yes, looks great! Covers all my concerns= !
--00000000000026f0a005f7175ad4--