unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Spencer Baugh <sbaugh@janestreet.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62229@debbugs.gnu.org
Subject: bug#62229: 29.0.60; It's no longer possible to customize the xref ring size
Date: Fri, 17 Mar 2023 08:02:22 -0400	[thread overview]
Message-ID: <CAO=BR8MhD2bA5e2YXJwdTPt2_pv5nhTKYYnMgp9PDZ_7XRm+UQ@mail.gmail.com> (raw)
In-Reply-To: <83v8izeqqv.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

On Fri, Mar 17, 2023, 04:17 Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Spencer Baugh <sbaugh@janestreet.com>
> > Date: Thu, 16 Mar 2023 18:11:06 -0400
> >
> >
> > Emacs 28 had the function xref-set-marker-ring-length and the
> > customizable variable xref-marker-ring-length which allowed growing
> > the amount of history kept by xref.
> >
> > This feature has been lost in Emacs 29; that variable has been
> > obsoleted with no replacement.
> >
> > It's not clear, looking at the change, whether this is because the
> > size is now infinite or not.  The same commit that obsoleted that
> > variable added the similar tags-location-ring-length.  However that
> > variable has no docstring, no customize hooks, and setting it has no
> > effect unless tags-reset-tags-tables is called.
> >
> > At the very least, all this should be documented better, and the
> > obsoleting of this function and variable should be mentioned in NEWS.
> > If the history is indeed infinite now, that should be mentioned in
> > NEWS as well.
>
> Indeed, that change paid very little attention to documenting the
> important aspects of adding Xref history and using it instead of a
> limited-size ring.  We should do better.
>
> I've now attempted to add the missing documentation; please take a
> look at the latest emacs-29 branch.
>

Yes, looks great! Covers all my concerns!

>

[-- Attachment #2: Type: text/html, Size: 2083 bytes --]

  reply	other threads:[~2023-03-17 12:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 22:11 bug#62229: 29.0.60; It's no longer possible to customize the xref ring size Spencer Baugh
2023-03-17  0:03 ` Dmitry Gutov
2023-03-17  8:17 ` Eli Zaretskii
2023-03-17 12:02   ` Spencer Baugh [this message]
2023-03-17 12:16     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO=BR8MhD2bA5e2YXJwdTPt2_pv5nhTKYYnMgp9PDZ_7XRm+UQ@mail.gmail.com' \
    --to=sbaugh@janestreet.com \
    --cc=62229@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).