unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 71356@debbugs.gnu.org, philipk@posteo.net, acorallo@gnu.org
Subject: bug#71356: use-package doesn't load org from elpa
Date: Fri, 7 Jun 2024 10:05:02 +0200	[thread overview]
Message-ID: <CAO48Bk9JfzxeORzqOBobj1n2WZzSft2=B9iLoYxLEAmm=K=gKQ@mail.gmail.com> (raw)
In-Reply-To: <865xumgku6.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2599 bytes --]

Just for the record. Further tests I have done:

--- init.el ---
(require 'benchmark)
(require 'package)
(setq custom-file (locate-user-emacs-file "custom.el"))

(when (not package-archive-contents)
  (package-refresh-contents))
(message "Loading org from elpa took %f s"
         (benchmark-elapse
           (setq-default package-install-upgrade-built-in t)
           (use-package org
             :ensure t
             :pin gnu)
  (message "org-version: %s" org-version)))
---

M-x org-version yields 9.6.15 (expected was 9.7.3)

Best, /PA

On Thu, 6 Jun 2024 at 17:19, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> > Date: Thu, 6 Jun 2024 17:07:02 +0200
> > Cc: Philip Kaludercic <philipk@posteo.net>, acorallo@gnu.org,
> 71356@debbugs.gnu.org
> >
> >  > IIUC the feature would be that if a use-package form has a
> >  >
> >  >      :pin gnu
> >  >
> >  > argument, then this is an indication that we want to install the
> package
> >  > from GNU ELPA, disregarding the fact that Emacs already has a built-in
> >  > version of the same package.  Sort of a package-local version of
> >  > `package-install-upgrade-built-in'.
> >
> >  I'm not sure.  People tend to copy/paste recipes from the Internet
> >  without really understanding what they do.  I think a simple :pin
> >  should not be sufficient, we need some specialized keyword (in
> >  addition to supporting package-install-upgrade-built-in).
> >
> > I didn't arrive at trying :pin gnu from anything in the Internet, but
> from
> > reading the use-package documentation (just this time ;-) )
> >
> >  > I am not familiar with the use-package code, but it seems like we
> could
> >  > implement this generally in package-install, by checking
> >  > `package-pinned-packages'.
> >
> >  I would prefer not to introduce another indication of whether built-in
> >  packages should or should not be upgraded.  If we do, we will next
> >  need to decide which one "wins" when they contradict each other.
> >
> >
> > My feeling is that if I set package-install-upgrade-built-in to t and pin
> > a package to (say) gnu elpa, that should be enough.
>
> I agree.  I was responding to the suggestion that just :pin should be
> enough.  That use-package currently ignores
> package-install-upgrade-built-in is a bug we should surely fix.
>


-- 
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet

[-- Attachment #2: Type: text/html, Size: 3851 bytes --]

  reply	other threads:[~2024-06-07  8:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  6:26 bug#71356: use-package doesn't load org from elpa Pedro Andres Aranda Gutierrez
2024-06-04 21:44 ` Andrea Corallo
2024-06-05  6:40   ` Pedro Andres Aranda Gutierrez
2024-06-05 11:18   ` Eli Zaretskii
2024-06-05 18:09     ` Andrea Corallo
2024-06-06  5:46       ` Pedro Andres Aranda Gutierrez
2024-06-06  6:02         ` Eli Zaretskii
2024-06-06  6:11           ` Pedro Andres Aranda Gutierrez
2024-06-06  9:15             ` Eli Zaretskii
2024-06-06  6:15           ` Philip Kaludercic
2024-06-06  9:21             ` Eli Zaretskii
2024-06-06 15:07               ` Pedro Andres Aranda Gutierrez
2024-06-06 15:19                 ` Eli Zaretskii
2024-06-07  8:05                   ` Pedro Andres Aranda Gutierrez [this message]
2024-06-10  6:02               ` Philip Kaludercic
2024-06-10  6:52                 ` Pedro Andres Aranda Gutierrez
2024-06-10  8:17                 ` Andrea Corallo
2024-06-10 12:18                   ` Eli Zaretskii
2024-06-10 15:40                     ` Philip Kaludercic
2024-06-10 16:12                       ` Eli Zaretskii
2024-06-10 16:51                         ` Pedro Andres Aranda Gutierrez
2024-06-10 17:46                           ` Eli Zaretskii
2024-06-10 18:04                             ` Philip Kaludercic
2024-06-11  5:27                             ` Pedro Andres Aranda Gutierrez
2024-06-11  7:29                               ` Eli Zaretskii
2024-06-11  7:53                                 ` Pedro Andres Aranda Gutierrez
2024-06-10 12:14                 ` Eli Zaretskii
2024-11-05  6:26 ` bug#71356: Follow-up on bug#71356 Pedro A. Aranda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO48Bk9JfzxeORzqOBobj1n2WZzSft2=B9iLoYxLEAmm=K=gKQ@mail.gmail.com' \
    --to=paaguti@gmail.com \
    --cc=71356@debbugs.gnu.org \
    --cc=acorallo@gnu.org \
    --cc=eliz@gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).