From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pedro Andres Aranda Gutierrez Newsgroups: gmane.emacs.bugs Subject: bug#71356: use-package doesn't load org from elpa Date: Thu, 6 Jun 2024 17:07:02 +0200 Message-ID: References: <86plsvk57o.fsf@gnu.org> <86ed9aip6z.fsf@gnu.org> <87ed9abnqn.fsf@posteo.net> <868qziifzd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a47e2b061a3a0a0a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7818"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71356@debbugs.gnu.org, Philip Kaludercic , acorallo@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 06 17:09:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sFEjb-0001iq-Ku for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jun 2024 17:08:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sFEjR-0007p6-N7; Thu, 06 Jun 2024 11:08:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFEjQ-0007oV-3w for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 11:08:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFEjP-0007oJ-RP for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 11:08:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sFEje-0001gy-2p for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 11:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pedro Andres Aranda Gutierrez Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jun 2024 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71356 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71356-submit@debbugs.gnu.org id=B71356.17176865356491 (code B ref 71356); Thu, 06 Jun 2024 15:09:02 +0000 Original-Received: (at 71356) by debbugs.gnu.org; 6 Jun 2024 15:08:55 +0000 Original-Received: from localhost ([127.0.0.1]:54209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFEjW-0001gc-S1 for submit@debbugs.gnu.org; Thu, 06 Jun 2024 11:08:55 -0400 Original-Received: from mail-ed1-f41.google.com ([209.85.208.41]:58406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFEjS-0001gN-64 for 71356@debbugs.gnu.org; Thu, 06 Jun 2024 11:08:53 -0400 Original-Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-57a4ce82f30so1402469a12.0 for <71356@debbugs.gnu.org>; Thu, 06 Jun 2024 08:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717686449; x=1718291249; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=V0jrTZ9xymQyY9oPPPAj8TYXuon48y6CHfiKLOHWoHg=; b=mVm5ZxDot6ktpe0ht4jXfm41HUobQFi58vhH/t2NgtcuynzPl1jKeWvnSzmen7VeOP 8GYLhlrCiEucdqpKfjiLlU2RhDS19KH13RoxPRlWjL701tL0BokTUTCnktzY/jyyahIK yRJAIm7jFWy3w30cwfOgBk4Nnhc5SJPIjIr6sQyKr9ABCF+1aObhMXT1q/8BNK1ge+3v UdTggGZqC5rMzuw4NhWS2j19g9Gf3t3qPpnWYhqoNPXH+ccx+XJrVHR8EtqmWNiKYTdO cr/DEgJ5G1PGGXrzk3JkADjzNX2tmPoCHT/ABw/mp3gy9pO+n8mT1PEf7jnkMsUDEKmU txpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717686449; x=1718291249; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V0jrTZ9xymQyY9oPPPAj8TYXuon48y6CHfiKLOHWoHg=; b=BIdone5Fajbfur1bzYzNFzr4CVI2sa5iFVSdBNqG4OIqMfp4OyVbYZTG/gl9LuL3Mb 4wxQWYkiII+nKfLypKtv8xijtTLMFkIGKWx222u6ywT/prFRX+wQui2qual4xVEMiGOA 2CS/Lm1L4H+FqUQrbZgq51RtSasCgbi9gZRUjRXbZD77yo1HtIas7WOfW217mnZQnNsF 0xBcGR3LvgbA20qwSrgTL3WxwUFVRvBXHgk+2RSHcBqyDmu3q5B+5MSnCt22RzsUM5v6 4b3+EXz9RsPitLNA7sGEyqcuYexZp2lkFIiA65tdbT/gHlYP/DI32S5AMtjHpn7CJHkd sb4w== X-Forwarded-Encrypted: i=1; AJvYcCVFAuGkfbv7zStcqZtx+40KdhjNmU1+LQKqI0KBPfH+QNiTk//zpOtkmOsfNu4pA7aISy0tCxX2Rz3Amn5Tir/ay4DUYVY= X-Gm-Message-State: AOJu0YzyHeMVL9Sp5iZLT/hIcOq4SyC2yLbVBZntdqETM6M8az/zAiJ8 y4iP0PgDMgqmBxm3V9ELUIJc8PaJZSMHtffNmG/Vv8TK8tZ104AHqttVsVoe5/nQmDzTA99wI3Y c0OQh2S2q3NSWUcKO/23swvvUtOc= X-Google-Smtp-Source: AGHT+IHOUhujYuPqvucJ4WFwrsmh2yygf/oyaTTHUH3+PVP24/7Qujf+HvJadxcVffQAjodR1bpSoZE2RjWPxKUwEvM= X-Received: by 2002:a50:99c7:0:b0:579:eb77:6d85 with SMTP id 4fb4d7f45d1cf-57a8b7c7cfbmr4452615a12.27.1717686449239; Thu, 06 Jun 2024 08:07:29 -0700 (PDT) In-Reply-To: <868qziifzd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286706 Archived-At: --000000000000a47e2b061a3a0a0a Content-Type: text/plain; charset="UTF-8" Answers inline On Thu, 6 Jun 2024 at 11:21, Eli Zaretskii wrote: > > From: Philip Kaludercic > > Cc: Pedro Andres Aranda Gutierrez , acorallo@gnu.org > , > > 71356@debbugs.gnu.org > > Date: Thu, 06 Jun 2024 06:15:44 +0000 > > > > Sorry for the delayed response; I don't think that has to be expected. > > While use-package can utilise package.el for package management, my > > impression is that it is at liberty to be more flexible/declarative. > > Doesn't use-package utilize package.el already? > > If not, how does it handle installation and upgrades? by its own code? > > > > Do you have package-install-upgrade-built-in set non-nil? If not, can > > > you set it non-nil and try the recipe again? > > > > I have tried it out myself, and it doesn't appear to do anything. The > > issue looks like that `package-installed-p' doesn't respect > > package-install-upgrade-built-in or :pin. > > We should fix that, I think. If package-install-upgrade-built-in is > non-nil, use-package should upgrade built-in packages. > > > > As for a feature request: what exactly is the feature requested here? > > > Are you saying that use-package should automatically upgrade built-in > > > packages? If so, I don't think this will fly, since it would mean > > > inconsistencies with package-install. > > > > IIUC the feature would be that if a use-package form has a > > > > :pin gnu > > > > argument, then this is an indication that we want to install the package > > from GNU ELPA, disregarding the fact that Emacs already has a built-in > > version of the same package. Sort of a package-local version of > > `package-install-upgrade-built-in'. > > I'm not sure. People tend to copy/paste recipes from the Internet > without really understanding what they do. I think a simple :pin > should not be sufficient, we need some specialized keyword (in > addition to supporting package-install-upgrade-built-in). I didn't arrive at trying :pin gnu from anything in the Internet, but from reading the use-package documentation (just this time ;-) ) > I am not familiar with the use-package code, but it seems like we could > > implement this generally in package-install, by checking > > `package-pinned-packages'. > > I would prefer not to introduce another indication of whether built-in > packages should or should not be upgraded. If we do, we will next > need to decide which one "wins" when they contradict each other. > My feeling is that if I set package-install-upgrade-built-in to t and pin a package to (say) gnu elpa, that should be enough. I may resort to use-package from everything, but would not use :pin on built-in packages that I don't want to upgrade (makes no sense, right?). It's a bit like adding a load-path to the use-package call and download the package externally (for example cloning with git) into that directory, which is the way I use to get the development version of, for example, org-mode when I want to contribute to it. Does it sound strange? /PA -- Fragen sind nicht da, um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler Headaches with a Juju log: unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet --000000000000a47e2b061a3a0a0a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Answers inline

On Thu, 6 Jun 2024 at 11:21, Eli Zarets= kii <eliz@gnu.org> wrote:
> From: Philip Kalud= ercic <philipk@p= osteo.net>
> Cc: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>,=C2=A0 acorallo@gnu.org,
>=C2=A0 =C2=A071356@debbugs.gnu.org
> Date: Thu, 06 Jun 2024 06:15:44 +0000
>
> Sorry for the delayed response;=C2=A0 I don't think that has to be= expected.
> While use-package can utilise package.el for package management, my > impression is that it is at liberty to be more flexible/declarative.= =C2=A0

Doesn't use-package utilize package.el already?

If not, how does it handle installation and upgrades? by its own code?

> > Do you have package-install-upgrade-built-in set non-nil?=C2=A0 I= f not, can
> > you set it non-nil and try the recipe again?
>
> I have tried it out myself, and it doesn't appear to do anything.= =C2=A0 The
> issue looks like that `package-installed-p' doesn't respect > package-install-upgrade-built-in or :pin.

We should fix that, I think.=C2=A0 If package-install-upgrade-built-in is non-nil, use-package should upgrade built-in packages.

> > As for a feature request: what exactly is the feature requested h= ere?
> > Are you saying that use-package should automatically upgrade buil= t-in
> > packages?=C2=A0 If so, I don't think this will fly, since it = would mean
> > inconsistencies with package-install.
>
> IIUC the feature would be that if a use-package form has a
>
>=C2=A0 =C2=A0 =C2=A0 :pin gnu
>
> argument, then this is an indication that we want to install the packa= ge
> from GNU ELPA, disregarding the fact that Emacs already has a built-in=
> version of the same package.=C2=A0 Sort of a package-local version of<= br> > `package-install-upgrade-built-in'.

I'm not sure.=C2=A0 People tend to copy/paste recipes from the Internet=
without really understanding what they do.=C2=A0 I think a simple :pin
should not be sufficient, we need some specialized keyword (in
addition to supporting package-install-upgrade-built-in).
=
I didn't arrive at trying :pin gnu from anything in the = Internet, but from
reading the use-package documentation (just th= is time ;-) )

> I am not familiar with the use-package code, but it seems l= ike we could
> implement this generally in package-install, by checking
> `package-pinned-packages'.

I would prefer not to introduce another indication of whether built-in
packages should or should not be upgraded.=C2=A0 If we do, we will next
need to decide which one "wins" when they contradict each other.<= br>
=C2=A0
My feeling is that if I set pac= kage-install-upgrade-built-in to t and pin
a package to (say) gnu= elpa, that should be enough. I may resort to
use-package from ev= erything, but would not use :pin on built-in packages
that I don&= #39;t want to upgrade (makes no sense, right?).

It= 's a bit like adding a load-path to the use-package call=C2=A0
and download the package externally
(for example cloning with g= it) into that directory, which is
the way I use to get the develo= pment version of, for example, org-mode
when I want to contribute= to it.

Does it sound strange?=C2=A0
=C2= =A0/PA


--
Frage= n sind nicht da, um beantwortet zu werden,
Fragen sind da um geste= llt zu werden
Georg Kreisler

Headaches wi= th a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter= .operation we should run a leader-deposed hook here, but we can't yet
--000000000000a47e2b061a3a0a0a--