unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eyal Soha <eyalsoha@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 74026-done@debbugs.gnu.org
Subject: bug#74026: Patch to correct the list of cached functions in tramp-sh.el
Date: Sat, 26 Oct 2024 07:18:20 -0600	[thread overview]
Message-ID: <CANsz78+1=P6LEy2s1PytSOzuwguOZM527Q2WDZRmF1yWEjGfJA@mail.gmail.com> (raw)
In-Reply-To: <87ttcz9hpf.fsf@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

Yes, I imagine that it was once correct and no longer.

To help prevent this issue in the future, Tramp could print a message
whenever the handler is installed yet commands other than the ones in the
list get run.

Thanks for the help! I have closed the PR on GitHub.

Eyal

On Sat, Oct 26, 2024, 06:22 Michael Albinus <michael.albinus@gmx.de> wrote:

> Version: 30.2
>
> Eyal Soha <eyalsoha@gmail.com> writes:
>
> Hi Eyal,
>
> > The comment here is not correct:
> >
> https://github.com/emacs-mirror/emacs/blob/2a6af880b0958d527a4d32005ef9acf3bc4ea030/lisp/net/tramp-sh.el#L3736-L3740
>
> The comment was correct. Meanwhile, vc-find-root has been added or
> extended, we need file-directorx-p therefore.
>
> > The command file-directory-p should also be cached.  Fortunately, the
> > result is already cached so all that is needed is to add this function
> > to the list.  Performance of the ssh commands for vc-register is
> > improved by 170% with this patch.
> >
> > It's described in detail here:
> > https://github.com/emacs-mirror/emacs/pull/43
> >
> > How can I help get this patch into the repository?
>
> Thanks for your comprehensive investigation. I've tried your changes,
> Tramp's regression tests still pass.
>
> So I have pushed it to the repositories. Will appear end of this month
> with Tramp 2.7.1.4 on GNU ELPA. Closing the bug.
>
> > Eyal
>
> Best regards, Michael.
>

[-- Attachment #2: Type: text/html, Size: 2208 bytes --]

  reply	other threads:[~2024-10-26 13:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-26  7:23 bug#74026: Patch to correct the list of cached functions in tramp-sh.el Eyal Soha
2024-10-26 12:22 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-26 13:18   ` Eyal Soha [this message]
2024-10-26 14:48     ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-26 14:49       ` Eyal Soha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANsz78+1=P6LEy2s1PytSOzuwguOZM527Q2WDZRmF1yWEjGfJA@mail.gmail.com' \
    --to=eyalsoha@gmail.com \
    --cc=74026-done@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).