* bug#27613: [PATCH] Support all perl variable declarators and prefixes @ 2017-07-07 22:08 Jefferson Carpenter 2017-08-21 2:27 ` npostavs 0 siblings, 1 reply; 4+ messages in thread From: Jefferson Carpenter @ 2017-07-07 22:08 UTC (permalink / raw) To: 27613; +Cc: Jefferson Carpenter Syntax highlight declarators and prefixes, and add all variable definitions to imenu. --- lisp/progmodes/perl-mode.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el index 3def37a2ea..9cacfac336 100644 --- a/lisp/progmodes/perl-mode.el +++ b/lisp/progmodes/perl-mode.el @@ -135,7 +135,7 @@ '(;; Functions (nil "^[ \t]*sub\\s-+\\([-[:alnum:]+_:]+\\)" 1) ;;Variables - ("Variables" "^\\(?:my\\|our\\)\\s-+\\([$@%][-[:alnum:]+_:]+\\)\\s-*=" 1) + ("Variables" "^[ \t]*\\(?:anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\s-+\\([$@%][-[:alnum:]+_:]+\\)\\s-*=" 1) ("Packages" "^[ \t]*package\\s-+\\([-[:alnum:]+_:]+\\);" 1) ("Doc sections" "^=head[0-9][ \t]+\\(.*\\)" 1)) "Imenu generic expression for Perl mode. See `imenu-generic-expression'.") @@ -179,8 +179,9 @@ "BEGIN" "END" "return" "exec" "eval") t) "\\>") ;; - ;; Fontify local and my keywords as types. - ("\\<\\(local\\|my\\)\\>" . font-lock-type-face) + ;; Fontify declarators and prefixes as types. + ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators + ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes ;; ;; Fontify function, variable and file name references. ("&\\(\\sw+\\(::\\sw+\\)*\\)" 1 font-lock-function-name-face) -- 2.11.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#27613: [PATCH] Support all perl variable declarators and prefixes 2017-07-07 22:08 bug#27613: [PATCH] Support all perl variable declarators and prefixes Jefferson Carpenter @ 2017-08-21 2:27 ` npostavs 2017-08-23 21:09 ` Jefferson Carpenter 0 siblings, 1 reply; 4+ messages in thread From: npostavs @ 2017-08-21 2:27 UTC (permalink / raw) To: Jefferson Carpenter; +Cc: 27613 Jefferson Carpenter <jeffersoncarpenter2@gmail.com> writes: > Syntax highlight declarators and prefixes, and add all variable > definitions to imenu. Looks good to me. Have you done copyright assignment for Emacs? (The patch is small enough to apply regardless, I only ask to know whether I should mark it as such or not.) ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#27613: [PATCH] Support all perl variable declarators and prefixes 2017-08-21 2:27 ` npostavs @ 2017-08-23 21:09 ` Jefferson Carpenter 2017-08-26 3:09 ` npostavs 0 siblings, 1 reply; 4+ messages in thread From: Jefferson Carpenter @ 2017-08-23 21:09 UTC (permalink / raw) To: npostavs; +Cc: 27613 [-- Attachment #1: Type: text/plain, Size: 489 bytes --] Thanks for looking it over. No, I have not done copyright assignment. On Sun, Aug 20, 2017 at 9:27 PM, <npostavs@users.sourceforge.net> wrote: > Jefferson Carpenter <jeffersoncarpenter2@gmail.com> writes: > > > Syntax highlight declarators and prefixes, and add all variable > > definitions to imenu. > > Looks good to me. Have you done copyright assignment for Emacs? (The > patch is small enough to apply regardless, I only ask to know whether I > should mark it as such or not.) > [-- Attachment #2: Type: text/html, Size: 916 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#27613: [PATCH] Support all perl variable declarators and prefixes 2017-08-23 21:09 ` Jefferson Carpenter @ 2017-08-26 3:09 ` npostavs 0 siblings, 0 replies; 4+ messages in thread From: npostavs @ 2017-08-26 3:09 UTC (permalink / raw) To: Jefferson Carpenter; +Cc: 27613 tags 27613 fixed close 27613 26.1 quit Jefferson Carpenter <jeffersoncarpenter2@gmail.com> writes: > Thanks for looking it over. No, I have not done copyright assignment. Okay, pushed to master. [1: feecb66b6f]: 2017-08-25 22:50:15 -0400 Support all perl variable declarators and prefixes (Bug#27613) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=feecb66b6fe41c977b8e11b5f2d419c9544f42de> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-26 3:09 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-07-07 22:08 bug#27613: [PATCH] Support all perl variable declarators and prefixes Jefferson Carpenter 2017-08-21 2:27 ` npostavs 2017-08-23 21:09 ` Jefferson Carpenter 2017-08-26 3:09 ` npostavs
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).