unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark Kennedy <mark.t.kennedy@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 51794@debbugs.gnu.org
Subject: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar
Date: Thu, 18 Nov 2021 18:39:23 -0500	[thread overview]
Message-ID: <CANru7VEJxp_22Sf1CiLyR_JKmqaQAURv8hGju6vA6hPeof4t1g@mail.gmail.com> (raw)
In-Reply-To: <CANru7VEf+Ne+iM+Xta=obQ5c-7tJGdrzS6siRGUvCYG052HGKQ@mail.gmail.com>

bug fix #50993 is the bug.  it made make_lispy_position skip setting
posn to the tab_bar if track_mouse is non-nil.  why track_mouse is nil
for some frames and not for others i didn't look into.
thoughts/comments?

/mark

On Sat, Nov 13, 2021 at 10:43 AM Mark Kennedy <mark.t.kennedy@gmail.com> wrote:
>
> Thanks, I'll check it out.
>
> On Sat, Nov 13, 2021, 10:30 AM Eli Zaretskii <eliz@gnu.org> wrote:
>>
>> > From: Mark Kennedy <mark.t.kennedy@gmail.com>
>> > Date: Sat, 13 Nov 2021 09:52:21 -0500
>> > Cc: 51794@debbugs.gnu.org
>> >
>> > i'm willing to attempt to debug it myself but not via the -Q route.  i
>> > prefer to focus on where the bad input event stream is being created.
>> > any suggestions about where to put an elisp or C breakpoint to go
>> > after this?
>>
>> In keyboard.c, under "case MOUSE_CLICK_EVENT:", step through the
>> code until you get to this line:
>>
>>             position = make_lispy_position (f, event->x, event->y,
>>                                             event->timestamp);
>>
>> then step into make_lispy_position, and see what it produces.
>>
>> (I hope I got the code right; apologies if not.)





  reply	other threads:[~2021-11-18 23:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 20:49 bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar Mark Kennedy
2021-11-13  7:18 ` Eli Zaretskii
     [not found]   ` <CANru7VHKtNYZBwVHFEt-=25j7PGWkawdU+PWcdAPqdNaKSYP3w@mail.gmail.com>
2021-11-13 13:43     ` Eli Zaretskii
     [not found]       ` <CANru7VH29KdLB0-Bc-JoDB3x+_-M9irADdQ2=JVkupbLyW15DQ@mail.gmail.com>
2021-11-13 14:40         ` Eli Zaretskii
2021-11-13 14:52           ` Mark Kennedy
2021-11-13 15:29             ` Eli Zaretskii
2021-11-13 15:43               ` Mark Kennedy
2021-11-18 23:39                 ` Mark Kennedy [this message]
2021-11-19  7:01                   ` Eli Zaretskii
2021-11-19  7:54                     ` Eli Zaretskii
2021-11-19  9:26                     ` martin rudalics
2021-11-19 13:18                       ` Mark Kennedy
2021-11-20  8:03                       ` Eli Zaretskii
2021-11-20  8:48                         ` martin rudalics
2021-11-20  9:07                           ` Eli Zaretskii
2021-11-20  9:56                             ` martin rudalics
2021-11-20 10:08                               ` Eli Zaretskii
2021-11-21  9:12                                 ` martin rudalics
2021-11-21 14:56                                   ` Mark Kennedy
2021-11-21 15:00                                     ` Eli Zaretskii
2021-11-21 15:20                                       ` Mark Kennedy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANru7VEJxp_22Sf1CiLyR_JKmqaQAURv8hGju6vA6hPeof4t1g@mail.gmail.com \
    --to=mark.t.kennedy@gmail.com \
    --cc=51794@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).