From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Brinkhoff Newsgroups: gmane.emacs.bugs Subject: bug#68215: Bug in what-page Date: Thu, 11 Jan 2024 14:49:58 +0100 Message-ID: References: <83il46u7he.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000006f2c6b060eabd3d4" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22678"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68215@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 11 14:51:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNvSl-0005f2-7Z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jan 2024 14:51:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNvSd-0004Vr-Ke; Thu, 11 Jan 2024 08:51:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNvSb-0004Vg-DJ for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 08:51:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNvSb-0002Qk-3v for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 08:51:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNvSX-0002o7-T1 for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 08:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Brinkhoff Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jan 2024 13:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68215 X-GNU-PR-Package: emacs Original-Received: via spool by 68215-submit@debbugs.gnu.org id=B68215.170498101610733 (code B ref 68215); Thu, 11 Jan 2024 13:51:01 +0000 Original-Received: (at 68215) by debbugs.gnu.org; 11 Jan 2024 13:50:16 +0000 Original-Received: from localhost ([127.0.0.1]:59100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNvRn-0002n3-ML for submit@debbugs.gnu.org; Thu, 11 Jan 2024 08:50:16 -0500 Original-Received: from mail-ua1-x92a.google.com ([2607:f8b0:4864:20::92a]:47472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNvRk-0002mm-Sp for 68215@debbugs.gnu.org; Thu, 11 Jan 2024 08:50:14 -0500 Original-Received: by mail-ua1-x92a.google.com with SMTP id a1e0cc1a2514c-7cc9da9995bso1693870241.3 for <68215@debbugs.gnu.org>; Thu, 11 Jan 2024 05:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704981010; x=1705585810; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zRcyFKGUeojaLge5MuL/P76vXcIVxYo0lfxgqKtpujA=; b=GEhGN2XkGWXgySSVmV2Wz9inXjYXiXgGXpHUWws+YeRu8KKXhTBSSGn3x1Bz3nLxNE Ym+qbU4jDLjWCcWmLvvqeBJep85IvwCki0IPkNwLfNdxLt7yaMRJUu7ibSPVKbBh/DAy gcYddOulRHHZRy2heWD8btO8+CwWTEoFxIl8js7K4DGDFDKlLbj4ijuh+w7Y1TfHa8PU kAsRWdPkVqjNj+z9Ij/OAeKmZ+8exNwzNbfXLigrS4ZSHZgHbmQWaUf03HfXHJVUzsig UBQ/fKNYDzqUOvZmXZCJexG9zxbzrFqF1ChlX7OB0YEvPrrA9UTtlKqzVBoJmB7Rx/Bi KEMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704981010; x=1705585810; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zRcyFKGUeojaLge5MuL/P76vXcIVxYo0lfxgqKtpujA=; b=vM/yc5sVnXWF4/Th54CQy7DTvLrfPk3dwUZo5LSktbC0WwRhUNaAOPV+Y+gkwlXuX3 3bZTGR6BiQmfaCj8tyjnXRqTiwmVj3mAaXfLYRCTSm6Dnf0FYYjKNSDjsDR+xBYxSdsY MO4qIxIJMgAWIy+AJmOQFihr+pi5hHeQLXFn8HIxHb9gRJzmc8MWT2tAtRw8MeTxpThR 1klhGxBpr8qFn53fKACB4vl0z90zWXxBcHXoUTN82gaNz4LaF4BNJ/hEpCYdc0Am550I KmJzaGOOP28gqftC7wtLg0zQ/+QMR6/RXlThrjTUpVNTJgbFHxp3qFPLm1e+OaPagmr1 n1kA== X-Gm-Message-State: AOJu0Yy4ICywomCFzeskGCs+Ywlp3KqRBDX/IC4VO8777yDOeaMLoF5N Ln6WQYSrS4OLLjDi8Jwr96ilT+MwjKgdK7beo/Z2seu7Yq0= X-Google-Smtp-Source: AGHT+IHJ/h0K/gjUUCVJJs3tB20IjIZHCsbHIZg4wQpoE9414ymlrjbKjGgZXnn2GrhcgqAJMHCljKY2v5U3O2wtYTU= X-Received: by 2002:a05:6102:124b:b0:467:29b:812 with SMTP id p11-20020a056102124b00b00467029b0812mr514733vsg.1.1704981009730; Thu, 11 Jan 2024 05:50:09 -0800 (PST) In-Reply-To: <83il46u7he.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277895 Archived-At: --0000000000006f2c6b060eabd3d4 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii wrote: > It should be a simple matter to countermand this special-casing in > what-page, while still using count-lines. Or am I missing something? That's probably better. I'm attaching an updated patch which uses count-lines instead. It countermands the special case by checking (bolp) and then doing the opposite adjustment. However, there's one more case to consider: when point starts out right after a page delimiter (i.e. the very first positon on a page), the page--what-page while loop will leave the final point there too, and then count-lines will return 0. The line number should be 1, so an adjustment is needed there too. The updated test is the same as the previous round, and they still pass with the new patch. > > + "Return a list of the page number of point, and the line number > > +within that page." > > Our convention is to have the first line of a doc string be a single > complete sentence. Fixed by moving info to a second line, or rephrasing to one line. --0000000000006f2c6b060eabd3d4 Content-Type: text/x-patch; charset="US-ASCII"; name="what-line-2.patch" Content-Disposition: attachment; filename="what-line-2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lr99mucg0 Y29tbWl0IDc0NjAxM2UxNzk3MzU2NzNiMmFkNTM1ZWE0NmQ1NGJhZTNmMzhkNTAKQXV0aG9yOiBM YXJzIEJyaW5raG9mZiA8bGFyc0Bub2NyZXcub3JnPgpEYXRlOiAgIFR1ZSBKYW4gMiAwOTowNjox MyAyMDI0ICswMTAwCgogICAgRml4IHdoYXQtcGFnZS4KCmRpZmYgLS1naXQgYS9saXNwL3RleHRt b2Rlcy9wYWdlLmVsIGIvbGlzcC90ZXh0bW9kZXMvcGFnZS5lbAppbmRleCBlODYyMWVlMDM4My4u MWM3NTYxZDcxYzYgMTAwNjQ0Ci0tLSBhL2xpc3AvdGV4dG1vZGVzL3BhZ2UuZWwKKysrIGIvbGlz cC90ZXh0bW9kZXMvcGFnZS5lbApAQCAtMTU5LDIxICsxNTksMjMgQEAgY291bnQtbGluZXMtcGFn ZQogICAgICAgICAgICAgIHRvdGFsIGJlZm9yZSBhZnRlcikpKQogCiAoZGVmdW4gcGFnZS0td2hh dC1wYWdlICgpCi0gICJSZXR1cm4gYSBsaXN0IG9mIHRoZSBwYWdlIGFuZCBsaW5lIG51bWJlciBv ZiBwb2ludC4iCisgICJSZXR1cm4gYSBsaXN0IG9mIHRoZSBwYWdlIGFuZCBsaW5lIG51bWJlciBv ZiBwb2ludC4KK1RoZSBsaW5lIG51bWJlciBpcyByZWxhdGl2ZSB0byB0aGUgc3RhcnQgb2YgdGhl IHBhZ2UuIgogICAoc2F2ZS1yZXN0cmljdGlvbgogICAgICh3aWRlbikKICAgICAoc2F2ZS1leGN1 cnNpb24KICAgICAgIChsZXQgKChjb3VudCAxKQorICAgICAgICAgICAgKGFkanVzdCAoaWYgKG9y IChib2xwKSAobG9va2luZy1iYWNrIHBhZ2UtZGVsaW1pdGVyKSkgMSAwKSkKICAgICAgICAgICAg IChvcG9pbnQgKHBvaW50KSkpCiAgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCiAgICAg ICAgICh3aGlsZSAocmUtc2VhcmNoLWZvcndhcmQgcGFnZS1kZWxpbWl0ZXIgb3BvaW50IHQpCiAg ICAgICAgICAgKHdoZW4gKD0gKG1hdGNoLWJlZ2lubmluZyAwKSAobWF0Y2gtZW5kIDApKQogICAg ICAgICAgICAgKGZvcndhcmQtY2hhcikpCiAgICAgICAgICAgKHNldHEgY291bnQgKDErIGNvdW50 KSkpCi0gICAgICAgIChsaXN0IGNvdW50IChsaW5lLW51bWJlci1hdC1wb3Mgb3BvaW50KSkpKSkp CisgICAgICAgIChsaXN0IGNvdW50ICgrIGFkanVzdCAoY291bnQtbGluZXMgKHBvaW50KSBvcG9p bnQpKSkpKSkpCiAKIChkZWZ1biB3aGF0LXBhZ2UgKCkKLSAgIlByaW50IHBhZ2UgYW5kIGxpbmUg bnVtYmVyIG9mIHBvaW50LiIKKyAgIkRpc3BsYXkgdGhlIHBhZ2UgbnVtYmVyLCBhbmQgdGhlIGxp bmUgbnVtYmVyIHdpdGhpbiB0aGF0IHBhZ2UuIgogICAoaW50ZXJhY3RpdmUpCiAgIChhcHBseSAj J21lc3NhZ2UgKGNvbnMgIlBhZ2UgJWQsIGxpbmUgJWQiIChwYWdlLS13aGF0LXBhZ2UpKSkpCiAK ZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC90ZXh0bW9kZXMvcGFnZS10ZXN0cy5lbCBiL3Rlc3QvbGlz cC90ZXh0bW9kZXMvcGFnZS10ZXN0cy5lbAppbmRleCBmM2EyYzVmYmUwMC4uNjE3YjU5YTU0ZmIg MTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC90ZXh0bW9kZXMvcGFnZS10ZXN0cy5lbAorKysgYi90ZXN0 L2xpc3AvdGV4dG1vZGVzL3BhZ2UtdGVzdHMuZWwKQEAgLTEwNiwxMCArMTA2LDE0IEBAIHBhZ2Ut dGVzdHMtd2hhdC1wYWdlCiAgICAgKGluc2VydCAiZm9vXG4MXG5iYXJcbgxcbmJheiIpCiAgICAg KGdvdG8tY2hhciAocG9pbnQtbWluKSkKICAgICAoc2hvdWxkIChlcXVhbCAocGFnZS0td2hhdC1w YWdlKSAnKDEgMSkpKQorICAgIChmb3J3YXJkLWNoYXIpCisgICAgKHNob3VsZCAoZXF1YWwgKHBh Z2UtLXdoYXQtcGFnZSkgJygxIDEpKSkKICAgICAoZm9yd2FyZC1wYWdlKQorICAgIChzaG91bGQg KGVxdWFsIChwYWdlLS13aGF0LXBhZ2UpICcoMiAxKSkpCisgICAgKG5leHQtbGluZSkKICAgICAo c2hvdWxkIChlcXVhbCAocGFnZS0td2hhdC1wYWdlKSAnKDIgMikpKQogICAgIChmb3J3YXJkLXBh Z2UpCi0gICAgKHNob3VsZCAoZXF1YWwgKHBhZ2UtLXdoYXQtcGFnZSkgJygzIDQpKSkpKQorICAg IChzaG91bGQgKGVxdWFsIChwYWdlLS13aGF0LXBhZ2UpICcoMyAxKSkpKSkKIAogCiA7OzsgcGFn ZS10ZXN0cy5lbCBlbmRzIGhlcmUK --0000000000006f2c6b060eabd3d4--