bug#21808: 24.3; tramp sorting with regular expression crashes whole dir listing

bug#21808: 24.3; tramp sorting with regular expression crashes whole dir listing

[Piotr Wasik]

[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]

hi,

I try to set up tramp with adb to access nexus. Its root directory contains
a protected file called factory and directory listing returns: "lstat
'//factory' failed: Permission denied" as one of files.

it crashes with the following backtrace
;; Debugger entered--Lisp error: (args-out-of-range "lstat '//factory'
failed: Permission denied" 55 43)
;;   tramp-adb-ls-output-name-less-p("lstat '//factory' failed: Permission
denied" "lrwxrwxrwx root     root            0 2015-11-01 13:49 etc ->
/system/etc")
;;   sort(("drwxr-xr-x root     root            0 2015-11-01 13:49 acct"
"drwxrwx--- system   cache           0 2015-11-01 15:03 cache" "lrwxrwxrwx
root     root            0 1970-01-01 01:00 charger -> /sbin/healthd"
"dr-x------ root     root            0 2015-11-01 13:49 config" "lrwxrwxrwx
root     root            0 2015-11-01 13:49 d -> /sys/kernel/debug")
tramp-adb-ls-output-name-less-p)
;;   tramp-adb-sh-fix-ls-output()
;;   tramp-adb-handle-directory-files-and-attributes("/adb::/")
;;   eval((tramp-adb-handle-directory-files-and-attributes "/adb::/") nil)
;;   eval-last-sexp-1(t)
;;   eval-last-sexp(t)
;;   eval-print-last-sexp()
;;   call-interactively(eval-print-last-sexp nil nil)

I suggest a fix:

(defun tramp-adb-ls-output-name-less-p (a b)
  "Sort \"ls\" output by name, ascending."
  (let (posa posb matched-a matched-b)
    (setq matched-a (string-match dired-move-to-filename-regexp a))
    (setq posa (match-end 0))
    (setq matched-b (string-match dired-move-to-filename-regexp b))
    (setq posb (match-end 0))
    (string-lessp (substring a (if matched-a a 0)) (substring b (if
matched-b b 0)))))

I added matched-a and matched-b variables so even if directory listing
returns something unexpected, sorting completes normally.

Cheers,
Piotr

[-- Attachment #2: Type: text/html, Size: 2400 bytes --]

bug#21808: Fixed in master

[Jürgen Hötzel]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

This is already fixed in the master branch (currently unreleased)

commit ca762806fd6b5b455c42ef85833ff92c791eabe8
Author: Juergen Hoetzel <juergen@archlinux.org>
Date:   Fri Aug 7 18:00:00 2015 +0200

    * tramp-adb.el (tramp-adb-ls-output-name-less-p): Improve error
      checking. "ls -l" on Android in Enforcing mode can print "lstat
      './FILENAME failed: Permission denied".

[-- Attachment #2: Type: text/html, Size: 604 bytes --]

bug#21808: 24.3; tramp sorting with regular expression crashes whole dir listing

[Michael Albinus]

Piotr Wasik <piotr.wasik@gmail.com> writes:

> hi,

Hi Piotr,

> I try to set up tramp with adb to access nexus. Its root directory
> contains a protected file called factory and directory listing
> returns: "lstat '//factory' failed: Permission denied" as one of
> files.

Thanks for the bug report. It was already detected by Jürgen Hötzel back
in August, and he fixed it in both the Tramp and Emacs repositories. See
<http://lists.gnu.org/archive/html/emacs-diffs/2015-08/msg00050.html>.

> Cheers,
> Piotr

Best regards, Michael.

bug#21808: 24.3; tramp sorting with regular expression crashes whole dir listing

[Michael Albinus]

[Please keep Cc for the archives]

Piotr Wasik <piotr.wasik@gmail.com> writes:

> great, thanks.

Well, so I'm closing the bug.

> Piotr

Best regards, Michael.