From: Emilio Lopes <eclig@gmx.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 18461@debbugs.gnu.org
Subject: bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved.
Date: Fri, 12 Sep 2014 22:36:52 +0200 [thread overview]
Message-ID: <CANiPZaB8mi=mXrsy7aX1jBjJqnErZMTL8fzTCcP9LwVb702FsA@mail.gmail.com> (raw)
In-Reply-To: <jwvmwa492en.fsf-monnier+emacsbugs@gnu.org>
2014-09-12 19:28 GMT+02:00 Stefan Monnier <monnier@iro.umontreal.ca>:
>> + (ignore-errors
>> + ;; In case some problem might happen. E.g. We can't
>> + ;; find an `svn' executable. We used to only catch
>> + ;; `file-error' but when the process is run on a
>> + ;; remote host via Tramp, the error is only reported
>> + ;; via the exit status which is turned into an
>> + ;; `error' by vc-do-command.
>> + (cd dir)
>> + (vc-svn-command t t file "status" "-v"))))
>
> Sounds OK, but I suggest we use with-demoted-errors, so the user is told
> in case there's a problem.
Makes sense, thanks for looking at it. I'll submit a new patch the next days.
Emílio
next prev parent reply other threads:[~2014-09-12 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 16:09 bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved Emilio Lopes
2014-09-12 17:28 ` Stefan Monnier
2014-09-12 20:36 ` Emilio Lopes [this message]
2014-09-15 13:27 ` Emilio Lopes
2016-02-23 12:08 ` Lars Ingebrigtsen
2016-02-24 0:22 ` Dmitry Gutov
2016-02-24 1:43 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiPZaB8mi=mXrsy7aX1jBjJqnErZMTL8fzTCcP9LwVb702FsA@mail.gmail.com' \
--to=eclig@gmx.net \
--cc=18461@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).