From: Jim Porter <jporterbugs@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 49104@debbugs.gnu.org
Subject: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode'
Date: Sat, 19 Jun 2021 10:31:38 -0700 [thread overview]
Message-ID: <CANh=_JH2pUZLK6=ENuGgkyE4vMR2BE_3+uHYbRUcbLB+=LJedw@mail.gmail.com> (raw)
In-Reply-To: <jwv35td7p7n.fsf-monnier+emacs@gnu.org>
On Sat, Jun 19, 2021 at 10:24 AM Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> In that case, `key-binding` might be a good replacement.
> I see that using `key-binding` could find flyspell's own binding, tho, so we
> should probably use the (first) patch below instead.
>
> Tho I also wonder why we do the lookup when flyspell is enabled instead
> of doing directly in flyspell-auto-correct-word as in the second
> patch below.
Indeed, while I was looking into this some more, I saw that
`flyspell-auto-correct-word' is bound to both `M-TAB' and `C-.' in
`flyspell-mode-map'. Your second patch should properly delegate to the
right command for either binding, which would be very nice. The
original code (and my patch) always act as though you typed `M-TAB'
when delegating, which isn't quite right.
next prev parent reply other threads:[~2021-06-19 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 23:09 bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' Jim Porter
2021-06-19 6:07 ` Eli Zaretskii
2021-06-19 11:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-19 12:20 ` Eli Zaretskii
2021-06-19 17:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-19 17:31 ` Jim Porter [this message]
2021-06-27 19:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-28 4:44 ` Jim Porter
2021-07-20 12:13 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANh=_JH2pUZLK6=ENuGgkyE4vMR2BE_3+uHYbRUcbLB+=LJedw@mail.gmail.com' \
--to=jporterbugs@gmail.com \
--cc=49104@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).