From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode Date: Wed, 25 Aug 2021 09:41:52 -0700 Message-ID: References: <838s0rvyfu.fsf@gnu.org> <83zgt6vi43.fsf@gnu.org> <87a6l5k9xr.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000fcd7bd05ca64ed4d" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7566"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50179@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 25 18:43:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIvza-0001jW-JB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 18:43:10 +0200 Original-Received: from localhost ([::1]:43486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIvzY-0006lq-N8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 12:43:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIvzS-0006li-MW for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 12:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIvzS-0006c4-EY for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 12:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIvzS-00071O-Cj for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 12:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Aug 2021 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50179-submit@debbugs.gnu.org id=B50179.162990973926936 (code B ref 50179); Wed, 25 Aug 2021 16:43:02 +0000 Original-Received: (at 50179) by debbugs.gnu.org; 25 Aug 2021 16:42:19 +0000 Original-Received: from localhost ([127.0.0.1]:47511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIvyh-00070L-2t for submit@debbugs.gnu.org; Wed, 25 Aug 2021 12:42:19 -0400 Original-Received: from mail-ua1-f53.google.com ([209.85.222.53]:34455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIvya-000704-JT for 50179@debbugs.gnu.org; Wed, 25 Aug 2021 12:42:13 -0400 Original-Received: by mail-ua1-f53.google.com with SMTP id l24so94298uai.1 for <50179@debbugs.gnu.org>; Wed, 25 Aug 2021 09:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k/1ENmVIu2xqf1ZtP+UC1hKlDuGoNa2B3DCWR6Z9iDQ=; b=VZsE5NwsdkuG9mZQl+8Z3jo+VcAFgg4Aw11KAU8zbPQ6zrGZ48Mqs2z5j47EjqG+aY JWDrXiiBOvHyAYqN7O+AneAOQI7DHWxpGYLMN8u61dQ1vNTFgZNT6xSEMnN2V7sZodye ilv8aTGPzIjhmzWZcrrZJZ7oRMsFFdNJRtAPb3CdKTBdZI4leVMYbI53xo4qFfSRVbxR 3RQc8qbKm+1+ZidUEW4uxbLoOtF+aBo+UFlSoHlQn6htZGib7kH8UJ2C8Qbf5OFSqghV Vr4iAeDmKPC2PVBr9Y8/YVlKLVdSco5FJelbruiLJhN1C9J+pDZeBZ9nRYIgrYvoYGQ2 te7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k/1ENmVIu2xqf1ZtP+UC1hKlDuGoNa2B3DCWR6Z9iDQ=; b=iWt9lYrBHg4E08NKsA0GSwZECjWtKW6fP/+sbzoqgBtBiUnFdmAbuks+BphKPTtR/K i47xIW/E7cj+vUOh93MEQud3+pTRmNerP736bbe1hxj2ifs91+AReEEFx02DHsIvrI3Y 5wnmbG78RnIEVF3t8s5Cu4lwL0bQ8DYSCEzJKmjmNT7l7zLZXYlWOfvjdJWcSThL1wuj e7WNxHQI2OzotBoKQM+Izwe0GMC+OmD6F9RSkUEUXPKZGcJgUd8D9gNZIgN3iZL6SZ8i xxIZ6RoSevlDGZy69c7xAGBiW9uQTONz28BJkaYct2DxQMdsJ8S5VXWwmEqoE82cPM7H ogjA== X-Gm-Message-State: AOAM532EbRaXX/9DI/D97+p5jVyDWKpOQcP4ySa8Ziy9FoyEk0NpTPVM p015GR0e49SsbGkpBytUzPGcWzCBfbr5F8fdxkw= X-Google-Smtp-Source: ABdhPJyxYdxn2cy/D6POHYYHcXFjN9O0D4xj728nioCbN8QcNTsrcBu7TrSx9DvZU2oaxKbxLzrR+bMEizJUGwbTSG8= X-Received: by 2002:a9f:3189:: with SMTP id v9mr3102835uad.32.1629909721857; Wed, 25 Aug 2021 09:42:01 -0700 (PDT) In-Reply-To: <87a6l5k9xr.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212658 Archived-At: --000000000000fcd7bd05ca64ed4d Content-Type: text/plain; charset="UTF-8" Oops, I ran the tests locally, but I think I forgot to rebuild term.elc, so naturally the tests passed without needing any changes. Here's a patch. However, I just want to be sure it's ok for these patches to merge. As mentioned in the original message, my copyright assignment is currently out of date. I contacted assign@ to get it updated, and I don't foresee any problems, but you never know with companies. If the maintainers are ok with the patch being in-tree despite this, then I'm ok with it too; I just wanted to be sure everyone was aware of the situation. On Wed, Aug 25, 2021 at 5:04 AM Lars Ingebrigtsen wrote: > > Jim Porter writes: > > > Ok, here are updated patches addressing your comments. I fixed the > > grammatical error in the comment, improved the commit message for the > > second patch, and switched to using `ansi-color-bold-is-bright' in > > both files. I left `ansi-bright-color-names-vector' as a defcustom > > though, since I think that's the right thing to do there (see my > > previous message), but I can change that later if we agree on a > > different/better route there. > > Thanks; applied to Emacs 28. But unfortunately, I didn't notice the > test failure until after pushing. :-/ > > 1 unexpected results: > FAILED term-colors-bold-is-bright > > And the faces are: > > (font-lock-face ((:foreground "yellow3" :background "unspecified-bg" > :inverse-video nil) :inherit term-bold)) > (font-lock-face ((:foreground "yellow2" :background "unspecified-bg" > :inverse-video nil) :inherit term-bold)) > > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no --000000000000fcd7bd05ca64ed4d Content-Type: application/octet-stream; name="0001-Update-a-test-that-got-missed-for-bug-50179.patch" Content-Disposition: attachment; filename="0001-Update-a-test-that-got-missed-for-bug-50179.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ksrq3xxy0 RnJvbSA4MDljNDIwY2JjNDJhZGYxYjVmMGQ3ZDhkMGY1MjlmNmFkN2IwOGY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5jb20+CkRh dGU6IFdlZCwgMjUgQXVnIDIwMjEgMDk6MzU6NDkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBVcGRh dGUgYSB0ZXN0IHRoYXQgZ290IG1pc3NlZCBmb3IgYnVnIzUwMTc5CgoqIHRlc3QvbGlzcC90ZXJt LXRlc3RzLmVsICh0ZXJtLWNvbG9ycy1ib2xkLWlzLWJyaWdodCk6IFNldAonYW5zaS1jb2xvci1i b2xkLWlzLWJyaWdodCcuCi0tLQogdGVzdC9saXNwL3Rlcm0tdGVzdHMuZWwgfCAyICstCiAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS90 ZXN0L2xpc3AvdGVybS10ZXN0cy5lbCBiL3Rlc3QvbGlzcC90ZXJtLXRlc3RzLmVsCmluZGV4IGE2 MWQwOTM5ZWEuLmI2YTVlOWU4MTQgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC90ZXJtLXRlc3RzLmVs CisrKyBiL3Rlc3QvbGlzcC90ZXJtLXRlc3RzLmVsCkBAIC0xMjYsNyArMTI2LDcgQEAgdGVybS1j b2xvcnMKIAogKGVydC1kZWZ0ZXN0IHRlcm0tY29sb3JzLWJvbGQtaXMtYnJpZ2h0ICgpCiAgIChz a2lwLXVubGVzcyAobm90IChtZW1xIHN5c3RlbS10eXBlICcod2luZG93cy1udCBtcy1kb3MpKSkp Ci0gIChsZXQgKCh0ZXJtLWNvbG9yLWJvbGQtaXMtYnJpZ2h0IHQpKQorICAobGV0ICgoYW5zaS1j b2xvci1ib2xkLWlzLWJyaWdodCB0KSkKICAgICAocGNhc2UtZG9saXN0IChgKCxzdHIgLGV4cGVj dGVkICxicmlnaHQtZXhwZWN0ZWQpIGFuc2ktdGVzdC1zdHJpbmdzKQogICAgICAgKGxldCAoKGV4 cGVjdGVkIChvciBicmlnaHQtZXhwZWN0ZWQgZXhwZWN0ZWQpKQogICAgICAgICAgICAgKHJlc3Vs dCAodGVybS10ZXN0LXNjcmVlbi1mcm9tLWlucHV0IDQwIDEyIHN0cikpKQotLSAKMi4yNS4xCgo= --000000000000fcd7bd05ca64ed4d--