unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 47861@debbugs.gnu.org
Subject: bug#47861: Starting `jsonrpc-process-connection' over Tramp fails if the process writes to stderr
Date: Fri, 21 May 2021 21:53:10 -0700	[thread overview]
Message-ID: <CANh=_JEKEdJCtsKt92bod_iaBd1hdCV97dmQAF+R5ZfEisQ5hA@mail.gmail.com> (raw)
In-Reply-To: <87mtsvgawk.fsf@gmx.de>

On Sat, May 15, 2021 at 10:33 AM Michael Albinus <michael.albinus@gmx.de> wrote:
> Michael Albinus <michael.albinus@gmx.de> writes:
>
> > However, handling stderr buffers in Tramp's make-process is still a
> > mess. So I've started to reimplement this, using a named pipe on the
> > remote machine. make-pipe-process, the natural choice, does not work for
> > remote processes.
>
> I've finished a first shot on this, see the appended patch. Would you
> mind to test this in your environment, for example with eglot?

I've tested this patch (using commit
e89a2304a152d6ee9e5d75efe0d22cabab771388 from the Tramp repository,
which includes your above patch), and everything works correctly as
far as I can tell.

I also wanted to be sure I could still reproduce the original issue,
so I confirmed that if I roll Tramp back to a previous revision before
your workaround (I used commit
f9301e5d4424bd567dc212f579350c5e04397ba1), I see the bug again.

Thanks for the fix!





  reply	other threads:[~2021-05-22  4:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18  3:53 bug#47861: Starting `jsonrpc-process-connection' over Tramp fails if the process writes to stderr Jim Porter
2021-05-01  9:43 ` Michael Albinus
2021-05-15 17:32   ` Michael Albinus
2021-05-22  4:53     ` Jim Porter [this message]
2021-05-22  7:27       ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANh=_JEKEdJCtsKt92bod_iaBd1hdCV97dmQAF+R5ZfEisQ5hA@mail.gmail.com' \
    --to=jporterbugs@gmail.com \
    --cc=47861@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).