From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Date: Thu, 1 Jul 2021 12:45:42 -0700 Message-ID: References: <87a6n7zuf4.fsf@gmx.de> <877dia2sxh.fsf@gnus.org> <87h7hexlsv.fsf@gmx.de> <83lf6qkwjq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000003df81805c61516c7" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30193"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49283@debbugs.gnu.org, Lars Ingebrigtsen , Michael Albinus To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 01 21:46:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lz2da-0007YF-Ry for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Jul 2021 21:46:14 +0200 Original-Received: from localhost ([::1]:47544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lz2dZ-0004mp-Su for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Jul 2021 15:46:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lz2dO-0004lF-OL for bug-gnu-emacs@gnu.org; Thu, 01 Jul 2021 15:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lz2dO-0000sM-G6 for bug-gnu-emacs@gnu.org; Thu, 01 Jul 2021 15:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lz2dO-0003sM-FJ for bug-gnu-emacs@gnu.org; Thu, 01 Jul 2021 15:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jul 2021 19:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.162516876114890 (code B ref 49283); Thu, 01 Jul 2021 19:46:02 +0000 Original-Received: (at 49283) by debbugs.gnu.org; 1 Jul 2021 19:46:01 +0000 Original-Received: from localhost ([127.0.0.1]:33732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz2dN-0003s4-7H for submit@debbugs.gnu.org; Thu, 01 Jul 2021 15:46:01 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:34450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz2dL-0003rs-Bu for 49283@debbugs.gnu.org; Thu, 01 Jul 2021 15:45:59 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id a7so7154658pga.1 for <49283@debbugs.gnu.org>; Thu, 01 Jul 2021 12:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uffpiXg9jXMwvxC5NdfGkkZs2MUtILZh53C5H8rENtk=; b=bK8qNfBZRpM0RGoZ+ImdSyhrIgmR8xy4o0Z6g3WeD1ispaEqoy+P3i7vOPjL1YIEdH 4cDQigQZLfKYp7FGFPBZ31r0fy4CCHyHccLQtOuiiI5sJGP6HoThJDKbLzR+90DhpJ4A PDM3m6OZQcJtAOxwaz1JMQPo4LfK0Pq7vIi7JnVto1cQFTKRrVBkuET2fNmX6Ex5P4Qj lCdJSCcImyk4H2JCBvU9GEiuQlyxAancxCCCDkkWUSR7UNE4SD2gt+PnKh/CytDZzadD MOtHEz0eY9VK2P0TXcJddfSCsr1i6K9syqHXog60OGZHNy2uQEstltWdhXYR1K37kUOo kZ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uffpiXg9jXMwvxC5NdfGkkZs2MUtILZh53C5H8rENtk=; b=khG/fNWqRDm9ROrQjIRQtjeSF6vEU38Z+LGQUAmIDDJwnF8+xNBsDbp1GSgUQgz1uA yvotDKRIuQ2cux4NJTzt5/sf5luHtdP4ElFwqEu+S8cVnhoGTWD6YVeKe+PicpBIFXW+ 8IC7jGpZMEOFqFBJaNnsA30vIXJUZ/+v3MFk/SsVcpZWn4AB56P1Z+sThYvBO8OoGz6w o5hmg54L46PKKNMR7RidT+vHH1WKkbMxRC1aiiaEoTu2M9wCn5ILKcGITJgo+EedfVi5 kssfHVLvrx0sPlxp6R7OAAq+p2uI9tlRmm59kM/ob9J7BmIXEMX9NJ3SenmcXK0TEQZQ 8C5A== X-Gm-Message-State: AOAM533TJZ4uCEldytquBW6xIYY/e6APdOLCX2sA2g8enHTrPVsl8PYj HLMhKhXfSQpUWbovwaa5IxLI6DN8JJqF5GnLWrM= X-Google-Smtp-Source: ABdhPJwPTq30G6tDTUw8L6AQi0n/po0Y5+jKH+lGa9Ln7VwtPKdKW6Wg56FQGPGng7wTRW5dCr3cGvGSpavk/etz2R8= X-Received: by 2002:aa7:9464:0:b029:306:3984:b22a with SMTP id t4-20020aa794640000b02903063984b22amr1274605pfq.81.1625168753316; Thu, 01 Jul 2021 12:45:53 -0700 (PDT) In-Reply-To: <83lf6qkwjq.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209286 Archived-At: --0000000000003df81805c61516c7 Content-Type: text/plain; charset="UTF-8" On Thu, Jul 1, 2021 at 6:12 AM Eli Zaretskii wrote: > > > From: Michael Albinus > > Date: Thu, 01 Jul 2021 14:26:08 +0200 > > Cc: Jim Porter , 49283@debbugs.gnu.org > > > > So we shall apply Jim's patch. Maybe the docstring could be enhanced a > > little bit at the end, saying that INFILE, if it is a relative file > > name, is expanded to the directory the process uses as cwd. > > encode_current_directory returns an encoded file name. So if we make > this change, we should avoid calling ENCODE_FILE on it (doing so is a > no-op, but it's still unclean). I'd considered that when writing my initial patch to `call-process', but I wasn't sure what the most-correct way to avoid that would be. It seems we want an encoded path before returning from `encode_current_directory' in order to check that our result is actually accessible. But then that encoded dir gets passed in to `expand-file-name'. If INFILE is an un-encoded absolute path, wouldn't `expand-file-name' be un-encoded as well? Maybe a better way would be to get the cwd *without* encoding it (see the attached patch). However, maybe there's a simpler answer to all of this that I just don't know about since I'm not very familiar with how Emacs encodes file names. --0000000000003df81805c61516c7 Content-Type: application/octet-stream; name="0001-Ensure-call-process-interprets-infile-as-a-local-pat.patch" Content-Disposition: attachment; filename="0001-Ensure-call-process-interprets-infile-as-a-local-pat.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqlbhmyy0 RnJvbSBlODVkMWU4ZGI4MTY0ZmU3MmZhYWQ0ZDVlZjUxZDg0ZjlkODQ0YWNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5jb20+CkRh dGU6IFRodSwgMSBKdWwgMjAyMSAxMjo0MTo0OSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEVuc3Vy ZSAnY2FsbC1wcm9jZXNzJyBpbnRlcnByZXRzICdpbmZpbGUnIGFzIGEgbG9jYWwgcGF0aAoKKiBz cmMvY2FsbHByb2MuYyAoRmNhbGxfcHJvY2Vzcyk6IEludGVycHJldCAnaW5maWxlJyByZWxhdGl2 ZSB0byB0aGUKd29ya2luZyBkaXJlY3RvcnkgZnJvbSB3aGljaCAncHJvZ3JhbScgaXMgcnVuLCBu b3QgJ2RlZmF1bHQtZGlyZWN0b3J5Jy4KLS0tCiBzcmMvY2FsbHByb2MuYyB8IDE5ICsrKysrKysr KysrKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL3NyYy9jYWxscHJvYy5jIGIvc3JjL2NhbGxwcm9jLmMKaW5kZXgg YWFiYzM5MzEzYi4uMTQyZmI0Y2IyMyAxMDA2NDQKLS0tIGEvc3JjL2NhbGxwcm9jLmMKKysrIGIv c3JjL2NhbGxwcm9jLmMKQEAgLTIyNSw4ICsyMjUsOSBAQCBERUZVTiAoImNhbGwtcHJvY2VzcyIs IEZjYWxsX3Byb2Nlc3MsIFNjYWxsX3Byb2Nlc3MsIDEsIE1BTlksIDAsCiBUaGUgcmVtYWluaW5n IGFyZ3VtZW50cyBhcmUgb3B0aW9uYWwuCiAKIFRoZSBwcm9ncmFtJ3MgaW5wdXQgY29tZXMgZnJv bSBmaWxlIElORklMRSAobmlsIG1lYW5zIGBudWxsLWRldmljZScpLgotSWYgeW91IHdhbnQgdG8g bWFrZSB0aGUgaW5wdXQgY29tZSBmcm9tIGFuIEVtYWNzIGJ1ZmZlciwgdXNlCi1gY2FsbC1wcm9j ZXNzLXJlZ2lvbicgaW5zdGVhZC4KK0lmIElORklMRSBpcyBhIHJlbGF0aXZlIHBhdGgsIGl0IHdp bGwgYmUgbG9va2VkIGZvciByZWxhdGl2ZSB0byB0aGUKK2RpcmVjdG9yeSB3aGVyZSB0aGUgcHJv Y2VzcyBpcyBydW4gKHNlZSBiZWxvdykuICBJZiB5b3Ugd2FudCB0byBtYWtlIHRoZQoraW5wdXQg Y29tZSBmcm9tIGFuIEVtYWNzIGJ1ZmZlciwgdXNlIGBjYWxsLXByb2Nlc3MtcmVnaW9uJyBpbnN0 ZWFkLgogCiBUaGlyZCBhcmd1bWVudCBERVNUSU5BVElPTiBzcGVjaWZpZXMgaG93IHRvIGhhbmRs ZSBwcm9ncmFtJ3Mgb3V0cHV0LgogSWYgREVTVElOQVRJT04gaXMgYSBidWZmZXIsIG9yIHQgdGhh dCBzdGFuZHMgZm9yIHRoZSBjdXJyZW50IGJ1ZmZlciwKQEAgLTI3MCw3ICsyNzEsMTkgQEAgREVG VU4gKCJjYWxsLXByb2Nlc3MiLCBGY2FsbF9wcm9jZXNzLCBTY2FsbF9wcm9jZXNzLCAxLCBNQU5Z LCAwLAogCiAgIGlmIChuYXJncyA+PSAyICYmICEgTklMUCAoYXJnc1sxXSkpCiAgICAgewotICAg ICAgaW5maWxlID0gRmV4cGFuZF9maWxlX25hbWUgKGFyZ3NbMV0sIEJWQVIgKGN1cnJlbnRfYnVm ZmVyLCBkaXJlY3RvcnkpKTsKKyAgICAgIC8qIEV4cGFuZCBpbmZpbGUgcmVsYXRpdmUgdG8gdGhl IGN1cnJlbnQgYnVmZmVyJ3MgY3VycmVudAorCSBkaXJlY3RvcnksIG9yIGl0cyB1bmhhbmRsZWQg ZXF1aXZhbGVudCAoIn4iKS4gICovCisgICAgICBMaXNwX09iamVjdCBjdXJkaXIgPSBCVkFSIChj dXJyZW50X2J1ZmZlciwgZGlyZWN0b3J5KTsKKyAgICAgIGN1cmRpciA9IEZ1bmhhbmRsZWRfZmls ZV9uYW1lX2RpcmVjdG9yeSAoY3VyZGlyKTsKKworICAgICAgLyogSWYgdGhlIGZpbGUgbmFtZSBo YW5kbGVyIHNheXMgdGhhdCBkaXIgaXMgdW5yZWFjaGFibGUsIHVzZQorCSBhIHNlbnNpYmxlIGRl ZmF1bHQuICovCisgICAgICBpZiAoTklMUCAoY3VyZGlyKSkKKwljdXJkaXIgPSBidWlsZF9zdHJp bmcgKCJ+Iik7CisKKyAgICAgIGN1cmRpciA9IGV4cGFuZF9hbmRfZGlyX3RvX2ZpbGUgKGN1cmRp cik7CisKKyAgICAgIGluZmlsZSA9IEZleHBhbmRfZmlsZV9uYW1lIChhcmdzWzFdLCBjdXJkaXIp OwogICAgICAgQ0hFQ0tfU1RSSU5HIChpbmZpbGUpOwogICAgIH0KICAgZWxzZQotLSAKMi4yNS4x Cgo= --0000000000003df81805c61516c7--