From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#39408: Breakpoints don't work with M-x gdb under TRAMP Date: Thu, 15 Apr 2021 22:02:01 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ebb18b05c00fe190" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7032"; mail-complaints-to="usenet@ciao.gmane.io" To: 39408@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 16 09:12:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXIeM-0001jp-3f for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Apr 2021 09:12:22 +0200 Original-Received: from localhost ([::1]:55106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXIeL-0007BE-3x for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Apr 2021 03:12:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXIe4-0007AS-4T for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 03:12:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXIe3-0005OU-2l for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 03:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXIe2-0002TF-Ut for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 03:12:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Apr 2021 07:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39408-submit@debbugs.gnu.org id=B39408.16185571049444 (code B ref 39408); Fri, 16 Apr 2021 07:12:02 +0000 Original-Received: (at 39408) by debbugs.gnu.org; 16 Apr 2021 07:11:44 +0000 Original-Received: from localhost ([127.0.0.1]:39931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXIdk-0002SE-6I for submit@debbugs.gnu.org; Fri, 16 Apr 2021 03:11:44 -0400 Original-Received: from mail-pl1-f169.google.com ([209.85.214.169]:34635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXGcT-0007Jw-2o for 39408@debbugs.gnu.org; Fri, 16 Apr 2021 01:02:17 -0400 Original-Received: by mail-pl1-f169.google.com with SMTP id t22so13007184ply.1 for <39408@debbugs.gnu.org>; Thu, 15 Apr 2021 22:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=G/rx2RAabpAivnyJavGFiE0PhXi9B2k0FglpeiD/KrQ=; b=tWeXEnYS8aNCsRIzzBG/VZDY0FEjhknpSYqkzlZLzw2r/z37JE/IeXzhO2gF6V/RMg nRPjbcwAqn1vNrKIp+PC6rJjn/JseLmvVSm/xSEncUwJBesuRGMH749fm/dRFoIC08OV vml5XIpe5KZjD3XrVM2pIp22RrP/e6h3DuQOjRcBwmnIi0OCyZhuhXEHTwViE7+aTY9F sJXBVHyds5OucrcBimc7mm+CwWZxHAW5mE5WjYvwGClrUP78sv2TkW07YQY/Eh5BMAQz mLu5/VZLSZXemIoESnEJxOyW/i4D3hv7K/lW2H6tzG0c7JRrQUdY1AMq6RwskE9po7N3 6Ymw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=G/rx2RAabpAivnyJavGFiE0PhXi9B2k0FglpeiD/KrQ=; b=TC/8fk/xAURtX2zWPW832feKdvRZPU/6W1Gpzshed/9kZP3vs1jYlfKSwLYMtcH6ZP 8wFsjJ5+EhhSNRtvT+3y5ly03Z/AcOvIP35tChwC9jHs99s4k92dSrXKgcQII9Y0YZQ/ l31PdEZWfWSRhjW5BW0lU3B4MdCWrzJhNeuhCBcU/CRBRfOmBRpHysub5LmDGPwE4IzM Qmy/fP+vIc2uOYlJDEYUfK412JbsccWanwOkFNveT7m25XW7otw7XOA8OVjdxKvHnl6v prLvcMEdmoJPT2zAe2tZ60hFXdprmwKneai+MylxQit1cZBzXc8UlZwG9ToP4dy1d9fU okLw== X-Gm-Message-State: AOAM532CMdTzOBR1RqI32NmPB0fwKgK1T0hxPaTaSnPqQw5lRNWkLwEW f9Z7MJ69w86m23lKg+qsnAJXLi4kmQptv3nRCXMvzkrzzXI= X-Google-Smtp-Source: ABdhPJz4OjKy747Qcvyr0ipRasaUEfPiXEIGaQUiLCSrFHFGqFHD3raE5TZE6+M9TEPySqAiHVyS4HfJLw1PcpV0BeI= X-Received: by 2002:a17:90a:c3:: with SMTP id v3mr7945856pjd.55.1618549330910; Thu, 15 Apr 2021 22:02:10 -0700 (PDT) X-Mailman-Approved-At: Fri, 16 Apr 2021 03:11:42 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204118 Archived-At: --000000000000ebb18b05c00fe190 Content-Type: text/plain; charset="UTF-8" This is already fixed in Emacs 28 thanks to bug#44173 (a78c614), which replaces the old GDB/MI parser (that converted the data to JSON first) with a more-robust parser. Attached is a patch to fix this under Emacs 27. The problem is that in `gdb-jsonify-buffer', when replacing the "fullname" with a Tramp path, the wildcard was greedy, resulting in only one "fullname" being replaced in the buffer. This had the effect of rendering it impossible to have more than one breakpoint, as all but the first breakpoint would have unmodified "fullname"s. (Note: I have a couple of patches in Tramp already that put me at the limit for patches without copyright assignment paperwork. However, I've already requested the form.) --000000000000ebb18b05c00fe190 Content-Type: application/octet-stream; name="0001-Emacs-27-Fix-setting-breakpoints-in-M-x-gdb-for-remote-files.patch" Content-Disposition: attachment; filename="0001-Emacs-27-Fix-setting-breakpoints-in-M-x-gdb-for-remote-files.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_knju2fsx0 RnJvbSAyYWIxZWNlZjY3OWRmMzIyMzA3MDVlMzcwOThjMWQ5M2M2MzljMjJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5jb20+CkRh dGU6IFRodSwgMTUgQXByIDIwMjEgMjE6Mzk6MDMgLTA3MDAKU3ViamVjdDogW1BBVENIIDEvMl0g Rml4IHNldHRpbmcgYnJlYWtwb2ludHMgaW4gTS14IGdkYiBmb3IgcmVtb3RlIGZpbGVzCgoqIGxp c3AvcHJvZ21vZGVzL2dkYi1taS5lbCAoZ2RiLWpzb25pZnktYnVmZmVyKTogRml4IG1vZGlmaWNh dGlvbiBvZgpHREIvTUkgImZ1bGxuYW1lIiBwcm9wZXJ0eSBmb3IgcmVtb3RlIGZpbGVzCi0tLQog bGlzcC9wcm9nbW9kZXMvZ2RiLW1pLmVsIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvZ2RiLW1p LmVsIGIvbGlzcC9wcm9nbW9kZXMvZ2RiLW1pLmVsCmluZGV4IDY1ZmU5OTczNDEuLjFiMjY0MmZh ZTcgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2dkYi1taS5lbAorKysgYi9saXNwL3Byb2dt b2Rlcy9nZGItbWkuZWwKQEAgLTI2OTYsNyArMjY5Niw3IEBAIElmIGBkZWZhdWx0LWRpcmVjdG9y eScgaXMgcmVtb3RlLCBmdWxsIGZpbGUgbmFtZXMgYXJlIGFkYXB0ZWQgYWNjb3JkaW5nbHkuIgog ICAgIChsZXQgKChyZW1vdGUgKGZpbGUtcmVtb3RlLXAgZGVmYXVsdC1kaXJlY3RvcnkpKSkKICAg ICAgICh3aGVuIHJlbW90ZQogICAgICAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQotICAgICAg ICAod2hpbGUgKHJlLXNlYXJjaC1mb3J3YXJkICJbXFxbLF1mdWxsbmFtZT1cIlxcKC4rXFwpXCIi IG5pbCB0KQorICAgICAgICAod2hpbGUgKHJlLXNlYXJjaC1mb3J3YXJkICJbXFxbLF1mdWxsbmFt ZT1cIlxcKC4rP1xcKVwiIiBuaWwgdCkKICAgICAgICAgICAocmVwbGFjZS1tYXRjaCAoY29uY2F0 IHJlbW90ZSAiXFwxIikgbmlsIG5pbCBuaWwgMSkpKSkKICAgICAoZ290by1jaGFyIChwb2ludC1t aW4pKQogICAgICh3aGVuIGZpeC1rZXkKLS0gCjIuMjUuMQoK --000000000000ebb18b05c00fe190--