unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Josh <josh@foxtail.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Leo Liu <sdl.web@gmail.com>, 15641@debbugs.gnu.org
Subject: bug#15641: 24.3; [PATCH] Add find-definition for M-.
Date: Fri, 18 Oct 2013 12:01:21 -0700	[thread overview]
Message-ID: <CANdFEAH66tbdmu7nD2OdO43RcrZc0MK6uLEjNqpuBv08dadHpw@mail.gmail.com> (raw)
In-Reply-To: <jwva9i6hh80.fsf-monnier+emacsbugs@gnu.org>

On Fri, Oct 18, 2013 at 5:58 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> I think we should just make M-. work on elisp-related places such as
>> lisp-interaction-mode, emacs-lisp-mode, eval-expression and even
>> help-mode.
>
> Right: M-. should not be bound to an command specific to etags but to
> a command which delegates the work to a find-tag-function (whose
> default can then be to use etags).
>
> Of course, find-tag-function should do "as little as possible": find the
> corresponding place and return it.  The generic part of the code will
> take care of displaying the buffer, selecting it, remembering the
> previous position, etc... so we don't need a pop-tag-mark-function.

If you haven't already done so, it might be worth taking a look at
elisp-slime-nav-mode[0], which implements something similar to your
patch in a minor mode.  Its author appears to have signed copyright
papers as well.

I'm in agreement with Stefan's inclination to make the entry points
to this functionality sufficiently generic that they can be tagging
system agnostic.  If we start down that path for M-. it seems wise
to consider and specify user interfaces to all of the related
functionality (e.g. as described here[1]) at the same time in order
to provide a single coherent set of commands and key bindings
for navigating source trees, regardless of whether the navigation
in any particular context is facilitated by etags, GNU Global, nrepl,
or other means.

[0] https://github.com/purcell/elisp-slime-nav
[1] http://www.emacswiki.org/emacs/EmacsTags#toc1

Josh





  reply	other threads:[~2013-10-18 19:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-18  7:33 bug#15641: 24.3; [PATCH] Add find-definition for M- Leo Liu
2013-10-18 12:58 ` Stefan Monnier
2013-10-18 19:01   ` Josh [this message]
2013-10-18 20:02   ` Dmitry Gutov
2013-10-19  1:21     ` Stefan Monnier
2013-10-18 22:49 ` Barry OReilly
2017-11-07  0:53 ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANdFEAH66tbdmu7nD2OdO43RcrZc0MK6uLEjNqpuBv08dadHpw@mail.gmail.com \
    --to=josh@foxtail.org \
    --cc=15641@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).