* bug#1833: 23.0.60; Bug in custom-set-variables sorting
@ 2009-01-09 20:55 Lennart Borgman
2011-07-08 11:25 ` Juanma Barranquero
0 siblings, 1 reply; 13+ messages in thread
From: Lennart Borgman @ 2009-01-09 20:55 UTC (permalink / raw)
To: emacs-pretest-bug
I believe there is a bug the sorting routine in
custom-theme-set-variables. The comparision of two symbols does not
take the dependency list in account if the symbols compared are not
mentioned in their dependency list. However that breaks, eh, what do
you call it ..., transity.
In other words if one of the two symbols compared has a dependency
list and the other not then the first symbols must be sorted after the
second. It should look something like this:
;; Move minor modes and variables with explicit requires to the end.
(setq args
(sort args
(lambda (a1 a2)
(let* ((sym1 (car a1))
(sym2 (car a2))
(dep1 (get sym1 'custom-dependencies))
(dep2 (get sym2 'custom-dependencies))
(1-then-2 (memq sym1 dep2))
(2-then-1 (memq sym2 dep1)))
(cond ((and 1-then-2 2-then-1)
(error "Circular custom dependency between `%s' and `%s'"
sym1 sym2))
(2-then-1 nil)
;; 1 is a dependency of 2, so needs to be set first.
1-then-2
;; Put minor modes and symbols with :require last.
;; Putting minor modes last ensures that the mode
;; function will see other customized values rather
;; than default values.
(t (or (and dep2 (not dep1))
(nth 3 a2)
(eq (get sym2 'custom-set)
'custom-set-minor-mode))))))))
In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
of 2009-01-04
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/g/include -fno-crossjumping'
^ permalink raw reply [flat|nested] 13+ messages in thread* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2009-01-09 20:55 bug#1833: 23.0.60; Bug in custom-set-variables sorting Lennart Borgman
@ 2011-07-08 11:25 ` Juanma Barranquero
2011-07-08 22:28 ` Lennart Borgman
0 siblings, 1 reply; 13+ messages in thread
From: Juanma Barranquero @ 2011-07-08 11:25 UTC (permalink / raw)
To: Lennart Borgman; +Cc: 1833
On Fri, Jan 9, 2009 at 21:55, Lennart Borgman <lennart.borgman@gmail.com> wrote:
> I believe there is a bug the sorting routine in
> custom-theme-set-variables. The comparision of two symbols does not
> take the dependency list in account if the symbols compared are not
> mentioned in their dependency list. However that breaks, eh, what do
> you call it ..., transity.
>
> In other words if one of the two symbols compared has a dependency
> list and the other not then the first symbols must be sorted after the
> second.
Does still happen? Do you have a recipe to show the problem, starting
with "emacs -Q"?
Juanma
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2011-07-08 11:25 ` Juanma Barranquero
@ 2011-07-08 22:28 ` Lennart Borgman
2011-07-08 23:19 ` Juanma Barranquero
0 siblings, 1 reply; 13+ messages in thread
From: Lennart Borgman @ 2011-07-08 22:28 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: 1833
On Fri, Jul 8, 2011 at 13:25, Juanma Barranquero <lekktu@gmail.com> wrote:
> On Fri, Jan 9, 2009 at 21:55, Lennart Borgman <lennart.borgman@gmail.com> wrote:
>
>> I believe there is a bug the sorting routine in
>> custom-theme-set-variables. The comparision of two symbols does not
>> take the dependency list in account if the symbols compared are not
>> mentioned in their dependency list. However that breaks, eh, what do
>> you call it ..., transity.
>>
>> In other words if one of the two symbols compared has a dependency
>> list and the other not then the first symbols must be sorted after the
>> second.
>
> Does still happen? Do you have a recipe to show the problem, starting
> with "emacs -Q"?
I do not know if it still happens. Has it been fixed somehow?
It is rather cumbersome to make an example for this. Is there anything
unclear with my explanation?
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2011-07-08 22:28 ` Lennart Borgman
@ 2011-07-08 23:19 ` Juanma Barranquero
2011-07-08 23:49 ` Lennart Borgman
0 siblings, 1 reply; 13+ messages in thread
From: Juanma Barranquero @ 2011-07-08 23:19 UTC (permalink / raw)
To: Lennart Borgman; +Cc: 1833
On Sat, Jul 9, 2011 at 00:28, Lennart Borgman <lennart.borgman@gmail.com> wrote:
> It is rather cumbersome to make an example for this. Is there anything
> unclear with my explanation?
Plenty, but if you cannot bother giving a test case or even testing
whether the bug is still extant, I don't know why anyone should bother
trying to fix it.
Juanma
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2011-07-08 23:19 ` Juanma Barranquero
@ 2011-07-08 23:49 ` Lennart Borgman
2011-07-09 0:12 ` Juanma Barranquero
0 siblings, 1 reply; 13+ messages in thread
From: Lennart Borgman @ 2011-07-08 23:49 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: 1833
On Sat, Jul 9, 2011 at 01:19, Juanma Barranquero <lekktu@gmail.com> wrote:
> On Sat, Jul 9, 2011 at 00:28, Lennart Borgman <lennart.borgman@gmail.com> wrote:
>
>> It is rather cumbersome to make an example for this. Is there anything
>> unclear with my explanation?
>
> Plenty, but if you cannot bother giving a test case or even testing
> whether the bug is still extant, I don't know why anyone should bother
> trying to fix it.
I think you are exaggerating. I have explained the problem in detail
and I also gave some code that fixes the problem. As I remember it I
already use this in EmacsW32+Emacs for a long time.
If anyone is interested in fixing this (I would be glad) then look at
the code I have supplied to understand the problem better. Thanks.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2011-07-08 23:49 ` Lennart Borgman
@ 2011-07-09 0:12 ` Juanma Barranquero
2011-07-09 0:23 ` Lennart Borgman
0 siblings, 1 reply; 13+ messages in thread
From: Juanma Barranquero @ 2011-07-09 0:12 UTC (permalink / raw)
To: Lennart Borgman; +Cc: 1833
On Sat, Jul 9, 2011 at 01:49, Lennart Borgman <lennart.borgman@gmail.com> wrote:
> I think you are exaggerating.
No.
> I have explained the problem in detail
No.
> and I also gave some code that fixes the problem.
Code, and not a patch, that fixes one problem that you haven't clearly
explained, and for which you haven't provided a step-by-step recipe.
Juanma
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2011-07-09 0:12 ` Juanma Barranquero
@ 2011-07-09 0:23 ` Lennart Borgman
2011-07-09 0:27 ` Juanma Barranquero
0 siblings, 1 reply; 13+ messages in thread
From: Lennart Borgman @ 2011-07-09 0:23 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: 1833
On Sat, Jul 9, 2011 at 02:12, Juanma Barranquero <lekktu@gmail.com> wrote:
> On Sat, Jul 9, 2011 at 01:49, Lennart Borgman <lennart.borgman@gmail.com> wrote:
>
>> I think you are exaggerating.
>
> No.
>
>> I have explained the problem in detail
>
> No.
>
>> and I also gave some code that fixes the problem.
>
> Code, and not a patch, that fixes one problem that you haven't clearly
> explained, and for which you haven't provided a step-by-step recipe.
I am sorry you think so. Perhaps you can ask more specific questions
about the explanation I tried to give?
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2011-07-09 0:23 ` Lennart Borgman
@ 2011-07-09 0:27 ` Juanma Barranquero
2011-07-09 0:30 ` Lennart Borgman
0 siblings, 1 reply; 13+ messages in thread
From: Juanma Barranquero @ 2011-07-09 0:27 UTC (permalink / raw)
To: Lennart Borgman; +Cc: 1833
On Sat, Jul 9, 2011 at 02:23, Lennart Borgman <lennart.borgman@gmail.com> wrote:
> Perhaps you can ask more specific questions
> about the explanation I tried to give?
What's not specific in "please provide a step-by-step recipe of the
bug, starting from emacs -Q, explaining what do you see and what did
you expect to see"? Is not like I'm requesting something weird, that's
the standard procedure for any bug report (not that you follow it, of
course).
Juanma
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2011-07-09 0:27 ` Juanma Barranquero
@ 2011-07-09 0:30 ` Lennart Borgman
2011-07-09 0:40 ` Juanma Barranquero
0 siblings, 1 reply; 13+ messages in thread
From: Lennart Borgman @ 2011-07-09 0:30 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: 1833
On Sat, Jul 9, 2011 at 02:27, Juanma Barranquero <lekktu@gmail.com> wrote:
> On Sat, Jul 9, 2011 at 02:23, Lennart Borgman <lennart.borgman@gmail.com> wrote:
>
>> Perhaps you can ask more specific questions
>> about the explanation I tried to give?
>
> What's not specific in "please provide a step-by-step recipe of the
> bug, starting from emacs -Q, explaining what do you see and what did
> you expect to see"? Is not like I'm requesting something weird, that's
> the standard procedure for any bug report (not that you follow it, of
> course).
It is not at all related to the information I have given.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2011-07-09 0:30 ` Lennart Borgman
@ 2011-07-09 0:40 ` Juanma Barranquero
2011-07-09 0:57 ` Lennart Borgman
2011-07-11 1:59 ` Glenn Morris
0 siblings, 2 replies; 13+ messages in thread
From: Juanma Barranquero @ 2011-07-09 0:40 UTC (permalink / raw)
To: Lennart Borgman; +Cc: 1833
On Sat, Jul 9, 2011 at 02:30, Lennart Borgman <lennart.borgman@gmail.com> wrote:
> It is not at all related to the information I have given.
Lennart, apparently you don't understand how to make a bug report or
you refuse to do so. Good luck with your bug reports.
Juanma
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2011-07-09 0:40 ` Juanma Barranquero
@ 2011-07-09 0:57 ` Lennart Borgman
2011-07-11 1:59 ` Glenn Morris
1 sibling, 0 replies; 13+ messages in thread
From: Lennart Borgman @ 2011-07-09 0:57 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: 1833
On Sat, Jul 9, 2011 at 02:40, Juanma Barranquero <lekktu@gmail.com> wrote:
> On Sat, Jul 9, 2011 at 02:30, Lennart Borgman <lennart.borgman@gmail.com> wrote:
>
>> It is not at all related to the information I have given.
>
> Lennart, apparently you don't understand how to make a bug report or
> you refuse to do so. Good luck with your bug reports.
Maybe someone else understand what I have written and care to fix the problem.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2011-07-09 0:40 ` Juanma Barranquero
2011-07-09 0:57 ` Lennart Borgman
@ 2011-07-11 1:59 ` Glenn Morris
2011-07-11 16:02 ` Lennart Borgman
1 sibling, 1 reply; 13+ messages in thread
From: Glenn Morris @ 2011-07-11 1:59 UTC (permalink / raw)
To: 1833-done
This simply is not comprehensible without a recipe that shows the
problem. I do not believe anyone could or should do anything without
such, therefore I am closing it. If you reply with a recipe that shows
the problem, the report can be reopened. From the Emacs manual
"Checklist for Bug Reports":
And if we can't understand what bug you are trying to fix, or why
your patch should be an improvement, we mustn't install it.
^ permalink raw reply [flat|nested] 13+ messages in thread* bug#1833: 23.0.60; Bug in custom-set-variables sorting
2011-07-11 1:59 ` Glenn Morris
@ 2011-07-11 16:02 ` Lennart Borgman
0 siblings, 0 replies; 13+ messages in thread
From: Lennart Borgman @ 2011-07-11 16:02 UTC (permalink / raw)
To: 1833, rgm; +Cc: 1833-done
On Mon, Jul 11, 2011 at 03:59, Glenn Morris <rgm@gnu.org> wrote:
>
> This simply is not comprehensible without a recipe that shows the
> problem.
Could you please read the second paragraph of the bug report? Here it
is again, a bit rephrased:
if the first of the two symbol compared has a dependency
list and the seond not have that, then the first symbol must
be sorted after the second.
I sent this bug report more than two years ago, but as I remember it
now the sort function did not properly do the comparison if one of the
symbols lacked a dependency list.
This is what I tried to fix in the code. And I think this is the code
I once implemented in my patched version of Emacs+EmacsW32. (I might
have done some changes later, the code is on the web.)
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2011-07-11 16:02 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-09 20:55 bug#1833: 23.0.60; Bug in custom-set-variables sorting Lennart Borgman
2011-07-08 11:25 ` Juanma Barranquero
2011-07-08 22:28 ` Lennart Borgman
2011-07-08 23:19 ` Juanma Barranquero
2011-07-08 23:49 ` Lennart Borgman
2011-07-09 0:12 ` Juanma Barranquero
2011-07-09 0:23 ` Lennart Borgman
2011-07-09 0:27 ` Juanma Barranquero
2011-07-09 0:30 ` Lennart Borgman
2011-07-09 0:40 ` Juanma Barranquero
2011-07-09 0:57 ` Lennart Borgman
2011-07-11 1:59 ` Glenn Morris
2011-07-11 16:02 ` Lennart Borgman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).