From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Date: Mon, 4 Jul 2011 01:11:09 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1309734783 29404 80.91.229.12 (3 Jul 2011 23:13:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 3 Jul 2011 23:13:03 +0000 (UTC) Cc: 6414@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 04 01:12:58 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVqS-0003Gt-C8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jul 2011 01:12:56 +0200 Original-Received: from localhost ([::1]:43364 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdVqR-0003TD-FL for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2011 19:12:55 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:56495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdVpc-0003OK-Pf for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2011 19:12:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QdVpb-000606-6M for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2011 19:12:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdVpa-000602-Rh for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2011 19:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QdVpa-0006Jr-0M; Sun, 03 Jul 2011 19:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2011 23:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Original-Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130973469724257 (code B ref 6414); Sun, 03 Jul 2011 23:12:01 +0000 Original-Received: (at 6414) by debbugs.gnu.org; 3 Jul 2011 23:11:37 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVpA-0006JC-PS for submit@debbugs.gnu.org; Sun, 03 Jul 2011 19:11:37 -0400 Original-Received: from mail-ew0-f44.google.com ([209.85.215.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVp9-0006J0-6s for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 19:11:35 -0400 Original-Received: by ewy19 with SMTP id 19so1932544ewy.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 16:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=cpPr/6tB8q77EjLmECxYUJTxmEQ/zw0SIpUvfm9nVt4=; b=UjS1AdQmuNUI7/qhax5yGP0n1+cFRbRyoLOoHZfPTNNF7xdFYKm4BRmrVELn+Hf7JJ rkaZXDD4KzbC79miI9qij63clE0JcqruoCwT0g7A2CZNOk2ckDde+NsBM3/UAEMrBVQF YJbEXjJseNiYpsgII2LCywaCYzpwxSGStCqsI= Original-Received: by 10.213.20.200 with SMTP id g8mr1650696ebb.140.1309734689158; Sun, 03 Jul 2011 16:11:29 -0700 (PDT) Original-Received: by 10.213.7.84 with HTTP; Sun, 3 Jul 2011 16:11:09 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 03 Jul 2011 19:12:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47882 Archived-At: On Mon, Jul 4, 2011 at 00:48, Juanma Barranquero wrote: > On Mon, Jul 4, 2011 at 00:37, Lennart Borgman wrote: > >> It has been some time since I suggested this, but as far as I remember >> I looked into this because I had quite a few crashes. They seemed to >> be related to menus. > > Yes, I've seen these bug reports, but they usually don't have enough > information to follow through (for what I've seen, Eli tried to get > you to add more information, with mixed results). I tried to do that, but as I said in another thread I do not see the same problem in my patched build any more. (But I see new problems on 64-bit windows.) >> Yes, correct. And I pointed to another place where I thought the >> problem was instead. > > Yes, but still not saying what the problem is. You had crashes in > menus, and you filed other bug reports for them. I'm talking about > this "bug" report. This is a complement to them. We agreed to file bug report for code changes we should not forget. This is one of those. Do you agree that this report is a reasonable way to tell you what I have done to try to fix the problem and get your thoughts on it? Otherwise suggest something else. (I can't do much now, but perhaps later.) >> Since you asked for a recipe I thought I had to mention this again. It >> looked to me that you overlooked this problem again. > > "Overlooked [...] again"? Yes. The problem with race conditions was one of the main reasons for my suggestion to add error checking to all system calls. I thought that you might have overlooked this since you suggested that I should send a clear recipe for how to reproduce the bug. But maybe you did not do that? Please explain if I am misunderstanding you. >> Did you look at the logic as I suggested? > > If the logic is flawed and there's an unitialized struct, it will > likely cause bugs and crashes. We only have a few such reports, by > you, but they are not very informative, often it is not clear whether > it happens with stock Emacs or you patched one (which includes changes > in menu functions), and I don't even know if you've had more such > crashes recently or they were a year or two ago. Lots of things have > changed in between. I think I was wrong about the initialization. As I said later I think the structure was initialized. Yes, I have a lot of changes in that area. Complicated, unfortunately. I think I have lost control of the details there now. And I never felt I had complete control of it. The code is complex and I am not even sure that we are always doing things in the right thread etc. However after fixing the things I suggested I have not seen those crashes any more as far as I remember. But it might be that I have changed my usage pattern of Emacs. Nowadays I am mostly using org-mode with my bibhlp.el extensions. >> If you are sure my >> suggestion is wrong then feel free to close the bug. > > If your suggestion is anything other than "all system calls should be > checked", which has already been discussed in emacs-devel, I fail to > see what it is. Care to clarify? Yes, it is this that I wrote earlier: "The problem seems to be in x_free_frame_resources. Should not free_frame_menubar be called before my_destroy_window there?" We might disagree, but be sure I am glad for your efforts!