From: Lennart Borgman <lennart.borgman@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Chong Yidong <cyd@gnu.org>, 10633@debbugs.gnu.org
Subject: bug#10633: Please mark invalid "; !important;" in CSS
Date: Tue, 31 Jan 2012 03:36:11 +0100 [thread overview]
Message-ID: <CANbX366FYE42XLb2JP2A6pTGiOeHR-vNzXtT4WCwKX-e0hye_g@mail.gmail.com> (raw)
In-Reply-To: <jwvaa54od63.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Tue, Jan 31, 2012 at 02:48, Stefan Monnier <monnier@iro.umontreal.ca>wrote:
> >> >> However there are a lot of things that can go wrong when you work
> with
> >> >> things like css.
> >> > I don't think it should be the job of CSS mode to highlight ad-hoc
> >> > mistake conditions like that.
> >> There's cwarn-mode for something similar, so the question really is
> >> whether this error is common or specific to a particular user.
> >> I have no idea which it is.
> > The "!important" is colored as it is now even when I happen to put it
> > after the ";". Not syntax coloring that would be enough to easily
> > detect the problem.
>
> That would be perfect, yes. Patch welcome,
>
> I think this is enough:
;;("!\\s-*important" . font-lock-builtin-face)
("[^; \t\n]\\s-*\\(!\\s-*important\\)"
(1 'font-lock-builtin-face))
[-- Attachment #2: Type: text/html, Size: 1315 bytes --]
prev parent reply other threads:[~2012-01-31 2:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 22:01 bug#10633: Please mark invalid "; !important;" in CSS Lennart Borgman
2012-01-28 23:18 ` Juanma Barranquero
2012-01-28 23:26 ` Lennart Borgman
2012-01-28 23:52 ` Lennart Borgman
2012-01-29 0:10 ` Lennart Borgman
2012-01-29 0:34 ` Juanma Barranquero
2012-01-29 1:19 ` Lennart Borgman
2012-01-29 1:37 ` Juanma Barranquero
2012-01-29 1:56 ` Lennart Borgman
2012-01-29 2:01 ` Juanma Barranquero
2012-01-29 1:54 ` Glenn Morris
2012-01-29 2:00 ` Lennart Borgman
2012-01-29 2:04 ` Juanma Barranquero
2012-01-29 2:07 ` Lennart Borgman
2012-01-29 2:12 ` Juanma Barranquero
2012-01-29 4:07 ` Chong Yidong
2012-01-29 4:12 ` Lennart Borgman
2012-01-30 4:31 ` Stefan Monnier
2012-01-30 4:44 ` Lennart Borgman
2012-01-31 1:48 ` Stefan Monnier
2012-01-31 2:36 ` Lennart Borgman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANbX366FYE42XLb2JP2A6pTGiOeHR-vNzXtT4WCwKX-e0hye_g@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=10633@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).