From: Lennart Borgman <lennart.borgman@gmail.com>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 10633@debbugs.gnu.org
Subject: bug#10633: Please mark invalid "; !important;" in CSS
Date: Sun, 29 Jan 2012 01:10:57 +0100 [thread overview]
Message-ID: <CANbX365oOB+eoEgP67AZOygx8Vw-GZ9OEVE8Go0exRJmN6uO+w@mail.gmail.com> (raw)
In-Reply-To: <CANbX365RZsmjVWAcRSoiB35Hx_LRRLW_KT8u73WK5wp2f-F8nQ@mail.gmail.com>
On Sun, Jan 29, 2012 at 00:52, Lennart Borgman
<lennart.borgman@gmail.com> wrote:
> On Sun, Jan 29, 2012 at 00:26, Lennart Borgman
> <lennart.borgman@gmail.com> wrote:
>> On Sun, Jan 29, 2012 at 00:18, Juanma Barranquero <lekktu@gmail.com> wrote:
>>> On Sat, Jan 28, 2012 at 23:01, Lennart Borgman
>>> <lennart.borgman@gmail.com> wrote:
>>>
>>>> One of my most common mistakes when editing CSS files is that I leave
>>>> a ";" before "!important", like this:
>>>>
>>>> width: 500px; !important;
>>>>
>>>> This should have been
>>>>
>>>> width: 500px !important;
>>>>
>>>> Could Emacs please help me with this?;-)
>>>
>>> Sure. Use hi-lock-mode, add a "; +!important" regexp as a file
>>> pattern, set the mode in the css-mode-hook, and for added simplicity
>>> do also
>>>
>>> (setq hi-lock-file-patterns-policy (lambda (patterns)
>>> (if (eq major-mode 'css-mode)
>>> t
>>> (y-or-n-p "Add patterns
>>> from this buffer to hi-lock? "))))
>>>
>>> Look, ma, no hands.
>>
>> Thanks, it is a great tip until it is fixed!
>
> Though it was a bit unpractical. It would be easier to just add it to
> css-mode-hook and forget hi-lock-mode. Since isearch does it without
> hi-lock-mode that is doable. Anyone remember how to do it offhand? (Or
> do I have to search the isearch code... ?;-)
Here is a way to do it:
- In isearch-forward-regexp do M-s-h-r to hilight the pattern.
- Then use hi-lock-write-interactive-patterns to write it down in the
buffer for the moment (so you do not have to think about it...;-)
- Now to css-mode-hook add something like this (hi-lock-face-buffer ";
+!important;" 'hi-my-face)
In my .emacs I added:
(add-hook 'css-mode-hook 'my-hilock-css-important-errors)
(defun my-hilock-css-important-errors()
(hi-lock-face-buffer "; +!important;" 'hi-my-magenta))
next prev parent reply other threads:[~2012-01-29 0:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 22:01 bug#10633: Please mark invalid "; !important;" in CSS Lennart Borgman
2012-01-28 23:18 ` Juanma Barranquero
2012-01-28 23:26 ` Lennart Borgman
2012-01-28 23:52 ` Lennart Borgman
2012-01-29 0:10 ` Lennart Borgman [this message]
2012-01-29 0:34 ` Juanma Barranquero
2012-01-29 1:19 ` Lennart Borgman
2012-01-29 1:37 ` Juanma Barranquero
2012-01-29 1:56 ` Lennart Borgman
2012-01-29 2:01 ` Juanma Barranquero
2012-01-29 1:54 ` Glenn Morris
2012-01-29 2:00 ` Lennart Borgman
2012-01-29 2:04 ` Juanma Barranquero
2012-01-29 2:07 ` Lennart Borgman
2012-01-29 2:12 ` Juanma Barranquero
2012-01-29 4:07 ` Chong Yidong
2012-01-29 4:12 ` Lennart Borgman
2012-01-30 4:31 ` Stefan Monnier
2012-01-30 4:44 ` Lennart Borgman
2012-01-31 1:48 ` Stefan Monnier
2012-01-31 2:36 ` Lennart Borgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANbX365oOB+eoEgP67AZOygx8Vw-GZ9OEVE8Go0exRJmN6uO+w@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=10633@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).