From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yikai Zhao Newsgroups: gmane.emacs.bugs Subject: bug#73766: 30.0.91; (documentation 'pcase) can take several seconds Date: Sun, 13 Oct 2024 22:10:24 +0800 Message-ID: References: <86msj9y8u2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30573"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 73766@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 13 16:12:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1szzKE-0007nD-Go for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Oct 2024 16:12:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szzK0-0002e9-QJ; Sun, 13 Oct 2024 10:11:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szzJz-0002dw-2e for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 10:11:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szzJy-0008A5-GN for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 10:11:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=Df4WoKeSxRDymxRTda837mPpjrihgczqrSaXj0SlXuY=; b=W5zLY53eNP1g8P8z0IKJi2PijKFIX6kva4DsihzlNKYjnJYDiDwXjQDqqTCDvTRcMFFYPppHzrgVt8O605Stvi8LkRzG6mtO94uQUnQ+6BzZf4F2hUTk5K7U3L3zXF3dSY8To1PJ8e0OrEwWt54tTTMBqDPqCj8IZvowk2wXueemufq3YJx9f8mYplpN+e19Aj5K2KnUspSnyZ3zwZxuZ8KBILWgmM+eVhBt1I6m670baA1/0LNXlkZBEy9nHEkPM0Oo8QEl/jtMKJzQZ8Smf+ykCuCbRWHYbvneKFVoi5ZWMjK+u7g27Zjg0ehzj0obOLkVHaLl4NtE16+flkzpBA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1szzKD-000591-UQ for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 10:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yikai Zhao Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2024 14:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73766 X-GNU-PR-Package: emacs Original-Received: via spool by 73766-submit@debbugs.gnu.org id=B73766.172882871419760 (code B ref 73766); Sun, 13 Oct 2024 14:12:01 +0000 Original-Received: (at 73766) by debbugs.gnu.org; 13 Oct 2024 14:11:54 +0000 Original-Received: from localhost ([127.0.0.1]:51999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szzK6-00058e-Gl for submit@debbugs.gnu.org; Sun, 13 Oct 2024 10:11:54 -0400 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:45365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szzK3-00058V-PY for 73766@debbugs.gnu.org; Sun, 13 Oct 2024 10:11:52 -0400 Original-Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-37d4c1b1455so2415349f8f.3 for <73766@debbugs.gnu.org>; Sun, 13 Oct 2024 07:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=z1k.dev; s=google; t=1728828635; x=1729433435; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Df4WoKeSxRDymxRTda837mPpjrihgczqrSaXj0SlXuY=; b=esfytqUsI1AerO/tnjz+GX+Cl9vaxNuOPYJxkVYaQ4tdwymbGuzwjai00+XZLmJNHv WXf4jo5ebbLoYkAIFQoSny3gDPrKNNnuFiCoBiBv24E+JcHPlv0hOcFchcRpOTJqBkmz Dw0+C6LlgXx6nKTm6M8BQ5BuBv9/J0H/6lksv4e0NnFCK4CVWwUrHMvPEhHaPPolNLzE 1oxY9dYB0a7bGdodtJ/CFKLLM3lPKa5nk6xrBuyiNL6m+lFxF1bT/7kN2wOaXwbS2wrQ zldfIA5jICYWqycKiqYOu3xSye01udrb315ACyM/Xw73PquUvg0SE07EXFlt91jvefp4 +jfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728828635; x=1729433435; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Df4WoKeSxRDymxRTda837mPpjrihgczqrSaXj0SlXuY=; b=wnaZzSWFunq+ceNv1UcryPsuABDuM6Se4tDL5FlEgI3MkxkgzM8bvBaYLtacazFzBK /ZMRocSAgwp8UbnjGa0TXha+Osq0sc/M66hJY5tim1R+TISl5guZnD5ksd7hCb27LEGG QixGUiXybt96Vx+xXwnINE4sVzyFU0/QN+N5j2WmzYxcBJR8b6dIWDKxHeeqPCerNSyq vf9CiR0GBxgyG4E5yQh14bBQH0q2menDdCsqDKz4gs2Ziv/aBIxlzlXixI2NAu14Esu2 O40j4knZbSiah+MBheTadvHs2W9w+E1pXndI6JShKFQnrImDiJ1sZBxr0P+J8evvwiQp oU9Q== X-Forwarded-Encrypted: i=1; AJvYcCVKizFT0BFq877H1bdvqcndkFvfvrOYkNNIKS8VgCdoF2W5PFQQKedWOfrd54cwXvqG44D50A==@debbugs.gnu.org X-Gm-Message-State: AOJu0YycyLcvgvh7vfFHEE6F/KBisC2ANbYGvyjMV60Bjp4EPlGa6oE/ aGotI1roqgBA4DiW84u2H6KCil4doLvVUKEA7BhiCfUjsPR+soYwuItMQBwkT3K8tBf+Tr0aVm1 cO0ga3YBrrtOXbPcshlD9ehk7a6P/XfBqc8Vvxw== X-Google-Smtp-Source: AGHT+IH0pNQF4bSRCHDcmBWr6jfosPUc3pu15WH5oMKPZfPrLg0qR1MqCLO7ZqJLgFxVNwKDNEZhLsvyIs5OoYCQRoQ= X-Received: by 2002:adf:ef11:0:b0:37d:4610:dc5 with SMTP id ffacd0b85a97d-37d55262d68mr6077054f8f.44.1728828635347; Sun, 13 Oct 2024 07:10:35 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293520 Archived-At: On Sun, Oct 13, 2024 at 12:39=E2=80=AFAM Stefan Monnier wrote: > > >> Apparently, it would iterate over all defined pcase macros (N), and fo= r > >> each of those, `help-fns-short-filename` would iterate over all items = in > >> `load-path` (M). Total time complexity is N*M. > > Adding Stefan and Jo=C3=A3o, in case they have some comments or > > suggestions. > > How 'bout a patch like the one below? Hello, I tried this patch and can confirm it improves the performance. Here's the result of (benchmark-run (documentation 'pcase)): - master: 4s - master with this patch: 0.12s However it's still slower than last stable version: - 29.4 version: 0.02s Yikai