From: Yikai Zhao <yikai@z1k.dev>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Eli Zaretskii" <eliz@gnu.org>,
73766@debbugs.gnu.org, "João Távora" <joaotavora@gmail.com>
Subject: bug#73766: 30.0.91; (documentation 'pcase) can take several seconds
Date: Sun, 13 Oct 2024 22:10:24 +0800 [thread overview]
Message-ID: <CANMyjpgmECc9wek+F5uecVRMaweSZhTBADBZTff-Ce=LyqnjSg@mail.gmail.com> (raw)
In-Reply-To: <jwv1q0li8f0.fsf-monnier+emacs@gnu.org>
On Sun, Oct 13, 2024 at 12:39 AM Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>
> >> Apparently, it would iterate over all defined pcase macros (N), and for
> >> each of those, `help-fns-short-filename` would iterate over all items in
> >> `load-path` (M). Total time complexity is N*M.
> > Adding Stefan and João, in case they have some comments or
> > suggestions.
>
> How 'bout a patch like the one below?
Hello,
I tried this patch and can confirm it improves the performance.
Here's the result of (benchmark-run (documentation 'pcase)):
- master: 4s
- master with this patch: 0.12s
However it's still slower than last stable version:
- 29.4 version: 0.02s
Yikai
prev parent reply other threads:[~2024-10-13 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 8:02 bug#73766: 30.0.91; (documentation 'pcase) can take several seconds Yikai Zhao
2024-10-12 9:22 ` Eli Zaretskii
2024-10-12 16:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-13 14:10 ` Yikai Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANMyjpgmECc9wek+F5uecVRMaweSZhTBADBZTff-Ce=LyqnjSg@mail.gmail.com' \
--to=yikai@z1k.dev \
--cc=73766@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).