From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Kramer Newsgroups: gmane.emacs.bugs Subject: bug#52050: [PATCH] Make tab-line-switch-cycling work with buffer groups Date: Mon, 22 Nov 2021 20:16:09 -0800 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000f15d4505d16d0047" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2446"; mail-complaints-to="usenet@ciao.gmane.io" To: 52050@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 23 05:37:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpNYM-0000RU-Iw for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Nov 2021 05:37:10 +0100 Original-Received: from localhost ([::1]:52192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpNYL-0001Xm-4o for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Nov 2021 23:37:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpNYE-0001XQ-Od for bug-gnu-emacs@gnu.org; Mon, 22 Nov 2021 23:37:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38077) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpNYE-0002oL-Go for bug-gnu-emacs@gnu.org; Mon, 22 Nov 2021 23:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpNYE-0006DW-51 for bug-gnu-emacs@gnu.org; Mon, 22 Nov 2021 23:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matt Kramer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Nov 2021 04:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52050 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163764219223832 (code B ref -1); Tue, 23 Nov 2021 04:37:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Nov 2021 04:36:32 +0000 Original-Received: from localhost ([127.0.0.1]:49621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpNXg-0006CG-US for submit@debbugs.gnu.org; Mon, 22 Nov 2021 23:36:32 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:52890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpNEG-0005i1-Ub for submit@debbugs.gnu.org; Mon, 22 Nov 2021 23:16:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:32960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpNEG-0008AD-OA for bug-gnu-emacs@gnu.org; Mon, 22 Nov 2021 23:16:24 -0500 Original-Received: from [2607:f8b0:4864:20::233] (port=33511 helo=mail-oi1-x233.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpNEF-0000GK-8H for bug-gnu-emacs@gnu.org; Mon, 22 Nov 2021 23:16:24 -0500 Original-Received: by mail-oi1-x233.google.com with SMTP id q25so42307298oiw.0 for ; Mon, 22 Nov 2021 20:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=W5/Y7WS3TuDF+bogl8/ap+rCg1OVepEanVtnHpzCp4s=; b=k9gJ5D5jV6HJe2ITUqfeqJWr7R6M45v/uCzUpq71BKZDK848sISYxh0hEyo8S/xt0T UeNFzudc5oi85gFNcdNX8L0svxEU94N8bApyZtDMeOSZWdSgJ8jwEU8K1FLb1B+aw0yO TeKBh2VRrVvmakk4vENugPHeChgnUDUdxpCFRw5VyzYJ3Mn7tFI/nB4FMhPi9Ez7lxbE /tH2+1gBVFZRDjuc1HjD2NgzcOCo0IpowkzUiqJLeTBYmv+QfyJLKx6yRfQh6g919H5C +BYyu9WUbrSFOQUOm0uECHhSUw089iRVl+/qDbK2uAUMMF1m0TL2tK1o5lXiYLxtU5wu h6ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=W5/Y7WS3TuDF+bogl8/ap+rCg1OVepEanVtnHpzCp4s=; b=VOqKzsZkeEMWt2c5GLswkFVbHuuazSWav1wI7XrNNVZvnBIfo+TlvEV72FGooEUAy3 ZmyxJKP2Oqj/ofn3BrPsZkHnfgcZQ52mYCmffMiWfqemA/ajWwtGAovX18e9Qownycej zpf0270rGG/5/h4Kba8BDdzgGezyKloEmiWFaXPYwej5+PwirGdb3jTaX85UyJbmsEEe 8UPTEpkbr37p2w9ElLqfD+jGxJKMEH+8++BY15GkgJRQNbhiziHlNgXMnAtr3uyqKW6t 6OeCclKpg7l5xgCaztlfMPsIR/2mr06v7fhHzaay6XeS7Yk1bB8zlEejOQrsGFFPGVQs /ywg== X-Gm-Message-State: AOAM530o83aFjVvS5GkhqpbtctvZ48mbP8l3y2YUo0amFepQOhAx+ySf BjD4foaPVrPgI1Jz1zYUn6oNyg9+u2zr79iSpFfVw2+XLwXmFw== X-Google-Smtp-Source: ABdhPJxqYHXzpEh9exJtN2Uw1DKeVMZrn7Nvc2hXTnm/luODBNPqwA9xlCxouGmelEUfYjQ9KUyI5gCPKFRipXWfOPg= X-Received: by 2002:aca:ac8e:: with SMTP id v136mr2757541oie.19.1637640981010; Mon, 22 Nov 2021 20:16:21 -0800 (PST) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::233 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::233; envelope-from=matt314159@gmail.com; helo=mail-oi1-x233.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 22 Nov 2021 23:36:27 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220641 Archived-At: --000000000000f15d4505d16d0047 Content-Type: text/plain; charset="UTF-8" Currently, `tab-line-switch-cycling' has no effect in the presence of any tab that isn't associated with a buffer, such as the `group-tab' that exists when `tab-line-tabs-function' is `tab-line-tabs-buffer-groups'. This patch modifies `tab-line-switch-to-{next,prev}-tab' to remove any such tab from consideration. >From 205cebc3a05884d948a5ea45688732cbe1b948ea Mon Sep 17 00:00:00 2001 From: Matt Kramer Date: Mon, 22 Nov 2021 20:03:01 -0800 Subject: [PATCH] Fix tab-line cycling when using buffer groups --- lisp/tab-line.el | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lisp/tab-line.el b/lisp/tab-line.el index 110c6e9696..af0647acf7 100644 --- a/lisp/tab-line.el +++ b/lisp/tab-line.el @@ -792,7 +792,9 @@ tab-line-switch-to-prev-tab (if (eq tab-line-tabs-function #'tab-line-tabs-window-buffers) (switch-to-prev-buffer window) (with-selected-window (or window (selected-window)) - (let* ((tabs (funcall tab-line-tabs-function)) + (let* ((tabs (seq-filter + (lambda (tab) (or (bufferp tab) (assq 'buffer tab))) + (funcall tab-line-tabs-function))) (pos (seq-position tabs (current-buffer) (lambda (tab buffer) @@ -816,7 +818,9 @@ tab-line-switch-to-next-tab (if (eq tab-line-tabs-function #'tab-line-tabs-window-buffers) (switch-to-next-buffer window) (with-selected-window (or window (selected-window)) - (let* ((tabs (funcall tab-line-tabs-function)) + (let* ((tabs (seq-filter + (lambda (tab) (or (bufferp tab) (assq 'buffer tab))) + (funcall tab-line-tabs-function))) (pos (seq-position tabs (current-buffer) (lambda (tab buffer) -- 2.26.2 --000000000000f15d4505d16d0047 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Currently, `tab-line-switch-cycling' has no effect in = the presence of any tab that isn't associated with a buffer, such as th= e `group-tab' that exists when `tab-line-tabs-function' is `tab-lin= e-tabs-buffer-groups'. This patch modifies `tab-line-switch-to-{next,pr= ev}-tab' to remove any such tab from consideration.

= From 205cebc3a05884d948a5ea45688732cbe1b948ea Mon = Sep 17 00:00:00 2001
From: Matt Kramer <mkramer@lbl.gov>
Date: Mon, 22 Nov 2021 20:03:01 -0800
S= ubject: [PATCH] Fix tab-line cycling when using buffer groups

---=C2=A0lisp/tab-line.el | 8 ++++++--
=C2=A01 file changed, 6 insertions(= +), 2 deletions(-)

diff --git a/lisp/tab-line.el b/lisp/tab-line.el<= br>index 110c6e9696..af0647acf7 100644
--- a/lisp/tab-line.el
+++ b/l= isp/tab-line.el
@@ -792,7 +792,9 @@ tab-line-switch-to-prev-tab
=C2= =A0 =C2=A0 =C2=A0(if (eq tab-line-tabs-function #'tab-line-tabs-window-= buffers)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(switch-to-prev-buffer window= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0(with-selected-window (or window (selected-= window))
- =C2=A0 =C2=A0 =C2=A0 =C2=A0(let* ((tabs (funcall tab-line-tab= s-function))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0(let* ((tabs (seq-filter
+ = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0(lambda (tab) (or (bufferp tab) (assq 'buffer tab)))
+ =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(funcall = tab-line-tabs-function)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 (pos (seq-position
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 tabs (current-buffer)
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda (tab= buffer)
@@ -816,7 +818,9 @@ tab-line-switch-to-next-tab
=C2=A0 =C2= =A0 =C2=A0(if (eq tab-line-tabs-function #'tab-line-tabs-window-buffers= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(switch-to-next-buffer window)
= =C2=A0 =C2=A0 =C2=A0 =C2=A0(with-selected-window (or window (selected-windo= w))
- =C2=A0 =C2=A0 =C2=A0 =C2=A0(let* ((tabs (funcall tab-line-tabs-fun= ction))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0(let* ((tabs (seq-filter
+ =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(l= ambda (tab) (or (bufferp tab) (assq 'buffer tab)))
+ =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(funcall tab-= line-tabs-function)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 (pos (seq-position
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 tabs (current-buffer)
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda (tab bu= ffer)
--
2.26.2
--000000000000f15d4505d16d0047--