From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Kramer Newsgroups: gmane.emacs.bugs Subject: bug#52050: [PATCH] Make tab-line-switch-cycling work with buffer groups Date: Tue, 23 Nov 2021 01:41:59 -0800 Message-ID: References: <86sfvnpaie.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000030340d05d1718eae" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3327"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52050@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 23 10:43:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpSKX-0000al-6g for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Nov 2021 10:43:13 +0100 Original-Received: from localhost ([::1]:54606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpSKW-00063q-5s for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Nov 2021 04:43:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpSKM-00063Y-PD for bug-gnu-emacs@gnu.org; Tue, 23 Nov 2021 04:43:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38493) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpSKM-00028U-HS for bug-gnu-emacs@gnu.org; Tue, 23 Nov 2021 04:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpSKM-00016M-GA for bug-gnu-emacs@gnu.org; Tue, 23 Nov 2021 04:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matt Kramer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Nov 2021 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52050 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52050-submit@debbugs.gnu.org id=B52050.16376605394178 (code B ref 52050); Tue, 23 Nov 2021 09:43:02 +0000 Original-Received: (at 52050) by debbugs.gnu.org; 23 Nov 2021 09:42:19 +0000 Original-Received: from localhost ([127.0.0.1]:50039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpSJe-00015J-Vd for submit@debbugs.gnu.org; Tue, 23 Nov 2021 04:42:19 -0500 Original-Received: from mail-ot1-f53.google.com ([209.85.210.53]:40923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpSJc-000155-Bf for 52050@debbugs.gnu.org; Tue, 23 Nov 2021 04:42:17 -0500 Original-Received: by mail-ot1-f53.google.com with SMTP id v15-20020a9d604f000000b0056cdb373b82so32917925otj.7 for <52050@debbugs.gnu.org>; Tue, 23 Nov 2021 01:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z3UwWePxKZCh40aGfnwQfd4P8xrMZ1aZ00z21Wm1Oxk=; b=jYw9DYPLIj0GpLWnnAsTncZuqUtVN0x9HaLcv7mOXMq5ooqKj8jRozv7iYY46BdtQZ Fl/WSD0G4az1frFxWUeE1hHeD2/nNXvsNiKZDbGFZfWUwmTv7f2Hzcc9lA1cniRMEyuP n9lw4/L5q8DqcNKuZgKlk+TauB6OLKxV1ZKAL9Gekhok8khBbyv2aA2sWReRjuGUTNtm 33BhoSVZVUFt0rczWHu6Os8qnp2LHs+mejoC3zQcUn4MM8fIH5DI0MP+kYf1V5/s2QXX LoaKPSDrj8HrO7tJWCIQwBzmkjG8ypCgIKV/JNlxV7zwuCWHdo0IrGMgZ4l7Awhr4Ftl oIiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z3UwWePxKZCh40aGfnwQfd4P8xrMZ1aZ00z21Wm1Oxk=; b=LLqmhN1rgoirvRya+EEYyg1McGe6Io4gKLHjpSswHgkeyNdabbaF0VCWC/DyfHNmZ0 5BGvJPI0C0GtbIr86zunrDFCTTC0KYPJW02OIu1lZmTra85SZBRZMNxvka5Jr7QCYf+8 s+OWUWvWJmskniBCWa7YhlB1XwUONw4vJtt0VGQmu7u9SvhrYlbgl6KPfCKtAUb3BesX OlTrU3ziEAND75q8HlWSTq3QySuUElea9WPZweP44qbAIOhWpsSlOmSPypOFOPNUolHV 63HPqh/bby9BLXaMDnYn16ybKnDP4F7rW71S/UrTrVGxcK49IlXSMwO0Qu/HMI/ZIzCJ 4dfw== X-Gm-Message-State: AOAM531RjVjnTOHU6y3iQWQ7/bWAnFF2kzyIh9fIsPv/OXV+1QY5KeO7 1JUzC5R4H/LENQxDvyR3zRSoS48LbAJ1zd0p3yc= X-Google-Smtp-Source: ABdhPJzreRE9qZNVJ0p9BDrTJmvB2J7bg7+653tn0R6lhsfVQ0T1ok8R1a0qV9ahUENFG/WSLQhSp3jB9ukr7Kv3sSE= X-Received: by 2002:a05:6830:90a:: with SMTP id v10mr3027083ott.223.1637660530585; Tue, 23 Nov 2021 01:42:10 -0800 (PST) In-Reply-To: <86sfvnpaie.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220645 Archived-At: --00000000000030340d05d1718eae Content-Type: text/plain; charset="UTF-8" > > But it seems you also modified either tab-line-tabs-buffer-list-function, > or tab-line-tabs-buffer-group-sort-function, or both of them. Is this > true? > Yes to tab-line-tabs-buffer-group-sort-function, no to tab-line-tabs-buffer-list-function, yes also to tab-line-tabs-buffer-group-function. Setup is below: (defvar ++buffer-group-table (make-hash-table :test 'equal)) ;; I manually populate ++buffer-group-table (defun ++tab-line-buffer-group (buffer) (gethash (buffer-name buffer) ++buffer-group-table (with-current-buffer buffer (concat (symbol-name major-mode) ":" (and buffer-file-name (file-name-directory buffer-file-name)))))) (defun ++buffer-name< (a b) (string< (buffer-name a) (buffer-name b))) (setq tab-line-tabs-function #'tab-line-tabs-buffer-groups tab-line-tabs-buffer-group-function #'++tab-line-buffer-group tab-line-tabs-buffer-group-sort-function #'++buffer-name< tab-line-switch-cycling t) --00000000000030340d05d1718eae Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
But it s= eems you also modified either tab-line-tabs-buffer-list-function,
or tab= -line-tabs-buffer-group-sort-function, or both of them.=C2=A0 Is this true?=

Yes to tab-line-tabs-buffer-group-sort= -function, no to tab-line-tabs-buffer-list-function, yes also to tab-line-t= abs-buffer-group-function. Setup is below:

(defvar ++buffer-group-table
=C2=A0 (make-hash-table := test 'equal))

;; I manually populate=C2=A0++buffer-group-table

(defun ++tab-line-buffer-group (buffer)
=C2=A0 (gethash (buffer= -name buffer) ++buffer-group-table
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0(with-current-buffer buffer
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(concat (symbol-name major-mode)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0":"
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(and buff= er-file-name
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-name-directory buffer-file-name))))))=

(defun ++buffer-name< (a b)
=C2=A0 (string< (buffer-name a= ) (buffer-name b)))

(setq tab-line-tabs-function #'tab-line-tabs= -buffer-groups
=C2=A0 =C2=A0 =C2=A0 tab-line-tabs-buffer-group-function = #'++tab-line-buffer-group
=C2=A0 =C2=A0 =C2=A0 tab-line-tabs-buffer-= group-sort-function #'++buffer-name<
=C2=A0 =C2=A0 =C2=A0 tab-lin= e-switch-cycling t)

--00000000000030340d05d1718eae--