From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gulshan Singh Newsgroups: gmane.emacs.bugs Subject: bug#54346: persist-save doesn't persist variables when the value is set to the default Date: Tue, 21 Jun 2022 17:55:42 -0700 Message-ID: References: <87r177ysjh.fsf@gnus.org> <87pmlpqgix.fsf@gnus.org> <87ee23diue.fsf@gnus.org> <87y1xqz3xs.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000096217105e1fecca3" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21172"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Phillip Lord , 54346@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 22 02:57:45 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3ogi-0005KH-IO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Jun 2022 02:57:44 +0200 Original-Received: from localhost ([::1]:59132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3ogh-00051q-ED for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jun 2022 20:57:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3og2-00044y-MK for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 20:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3og2-00025A-D8 for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 20:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3og2-0003Cr-CF for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 20:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gulshan Singh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jun 2022 00:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54346 X-GNU-PR-Package: emacs Original-Received: via spool by 54346-submit@debbugs.gnu.org id=B54346.165585936212240 (code B ref 54346); Wed, 22 Jun 2022 00:57:02 +0000 Original-Received: (at 54346) by debbugs.gnu.org; 22 Jun 2022 00:56:02 +0000 Original-Received: from localhost ([127.0.0.1]:33571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3of4-0003BA-4j for submit@debbugs.gnu.org; Tue, 21 Jun 2022 20:56:02 -0400 Original-Received: from mail-oi1-f177.google.com ([209.85.167.177]:42829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3of1-0003Aq-Pl for 54346@debbugs.gnu.org; Tue, 21 Jun 2022 20:56:00 -0400 Original-Received: by mail-oi1-f177.google.com with SMTP id l81so19240263oif.9 for <54346@debbugs.gnu.org>; Tue, 21 Jun 2022 17:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y7XluCWUcpomCfd70WEwr1SrYpG9fE09FSVsdvFL1Lo=; b=g2PFO1t2RB6F31synki2vB2hlV/cvCpm1so+ZB3EUr5Zxzc3sdZDqt1da+VYQRZt9Y VidNgDKc9Gbas3D/VBm2EP9cUJHCT32/DQkXt1kc7Qx7UtTIFkKEatjvhHLJY5HUTR2j vB6lRiIy7o24417NAbAR+XXA74At9Gw6CPTbaaltOggRy4h6+R6DKBngdnxtJ/lBbYqy m1lWlGUBzZNEfzbJe/KCkqGhoCu7c3ODZbq9tcD/JHpw4B0j7RO8zPzg832EEGapb1qc 2OaX6ykCjQaWhzz2NvOxYy/EeJAzEiMIGVPlrjRLzzys+NtkmpCWN2eDW3oBOXBydhqN j/RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y7XluCWUcpomCfd70WEwr1SrYpG9fE09FSVsdvFL1Lo=; b=jJ7sHLQinAOMs34p3VQDe3hRbl2rvPECHL74UTIs+mFGGiQc26qF6GEmHo3ma9HioM PjG5S3fW+pJdemIkV6z0YoxBqtbqESg3s6sKoGIAqWfMZLZPJMSviO75AK2B/25DRniS ENVug1CIYmXgxQVBDdcS3tBmz64Ava09qnjAw6AKaaXVmbBTlDDQlpiPsOxzdClKk4I6 3WPyxIGBKXea+6EAzZtmIaq6CX9SvEsBTY+07RbT3Qj++w9B7lmx5GxaQiwMsCVMtfg+ go+Ni+b42pzj5jP3nXLT2vRpY02pC2Zukh0t5VUkAoEZKlieQdUp0MQL5LTmKWUPGrwe xQBA== X-Gm-Message-State: AOAM530q9fMZYpIOaNE1KJR/g4QNwfoQXdulV7MqiDphpF0jDR2A5DGq c3ilWbrZcZEF/0oB9FTu8xRqcIB5cpq/GY8OOEw= X-Google-Smtp-Source: ABdhPJzuPFe0Srptrx22Xvnh3e1BSxQKm6q5ef/RVqM50j55sVEj92ql7nSpTKmd9UkeES/NjieiNoaJ8w/WTG8PJnQ= X-Received: by 2002:a05:6808:1247:b0:32c:2ba9:4fab with SMTP id o7-20020a056808124700b0032c2ba94fabmr21797209oiv.261.1655859353865; Tue, 21 Jun 2022 17:55:53 -0700 (PDT) In-Reply-To: <87y1xqz3xs.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234989 Archived-At: --00000000000096217105e1fecca3 Content-Type: multipart/alternative; boundary="00000000000096217005e1fecca1" --00000000000096217005e1fecca1 Content-Type: text/plain; charset="UTF-8" Sure, the attached patch should work on the ELPA version. On Tue, Jun 21, 2022 at 3:50 AM Lars Ingebrigtsen wrote: > Gulshan Singh writes: > > > Do you know what's normally done in cases like this? Even if > > persist.el is maintained externally, should we just merge my patch and > > close this bug if we can't get a response from the maintainer? > > Yes, we can merge the patch. However, it doesn't seem to apply to the > version we have in ELPA -- the upstream and the ELPA version have > already diverged, apparently. > > Can you respin the patch against the version in GNU ELPA? > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --00000000000096217005e1fecca1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sure, the attached patch should work on the ELPA version.<= /div>
O= n Tue, Jun 21, 2022 at 3:50 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
Gulshan Singh <gsingh2011@gmail.com> writes:

> Do you know what's normally done in cases like this? Even if
> persist.el is maintained externally, should we just merge my patch and=
> close this bug if we can't get a response from the maintainer?

Yes, we can merge the patch.=C2=A0 However, it doesn't seem to apply to= the
version we have in ELPA -- the upstream and the ELPA version have
already diverged, apparently.

Can you respin the patch against the version in GNU ELPA?

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no
--00000000000096217005e1fecca1-- --00000000000096217105e1fecca3 Content-Type: application/octet-stream; name="0001-Delete-persist-file-when-symbol-is-set-to-default-va.patch" Content-Disposition: attachment; filename="0001-Delete-persist-file-when-symbol-is-set-to-default-va.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4ovv40m0 RnJvbSA0ZjI3NzMzYzMyNmM1ZjI0NzY4ZmIwOWZkOGJlNDc0MmZkMTllM2JjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdWxzaGFuIFNpbmdoIDxnc2luZ2gyMDExQGdtYWlsLmNvbT4K RGF0ZTogVHVlLCAyMSBKdW4gMjAyMiAxNzozODo1OCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIERl bGV0ZSBwZXJzaXN0IGZpbGUgd2hlbiBzeW1ib2wgaXMgc2V0IHRvIGRlZmF1bHQgdmFsdWUKCi0t LQogcGVyc2lzdC5lbCAgICAgICAgICAgIHwgMzggKysrKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0KIHRlc3QvcGVyc2lzdC10ZXN0cy5lbCB8ICAzICsrKwogMiBmaWxlcyBjaGFu Z2VkLCAyMyBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9wZXJz aXN0LmVsIGIvcGVyc2lzdC5lbAppbmRleCAzZDhkMWFmLi45NTBkZTNhIDEwMDY0NAotLS0gYS9w ZXJzaXN0LmVsCisrKyBiL3BlcnNpc3QuZWwKQEAgLTEzMiwyNCArMTMyLDI2IEBAIHZhcmlhYmxl cyBwZXJzaXN0IGF1dG9tYXRpY2FsbHkgd2hlbiBFbWFjcyBleGl0cy4iCiAgICh1bmxlc3MgKHBl cnNpc3QtLXBlcnNpc3RhbnQtcCBzeW1ib2wpCiAgICAgKGVycm9yIChmb3JtYXQKICAgICAgICAg ICAgICJTeW1ib2wgJXMgaXMgbm90IHBlcnNpc3RhbnQiIHN5bWJvbCkpKQotICAodW5sZXNzIChl cXVhbCAoc3ltYm9sLXZhbHVlIHN5bWJvbCkKLSAgICAgICAgICAgICAgICAgKHBlcnNpc3QtZGVm YXVsdCBzeW1ib2wpKQotICAgIChsZXQgKChkaXItbG9jCi0gICAgICAgICAgIChmaWxlLW5hbWUt ZGlyZWN0b3J5Ci0gICAgICAgICAgICAocGVyc2lzdC0tZmlsZS1sb2NhdGlvbiBzeW1ib2wpKSkp Ci0gICAgICAodW5sZXNzIChmaWxlLWV4aXN0cy1wIGRpci1sb2MpCi0gICAgICAgIChta2RpciBk aXItbG9jKSkpCi0gICAgKHdpdGgtdGVtcC1idWZmZXIKLSAgICAgIChsZXQgKHByaW50LWxldmVs Ci0JICAgIHByaW50LWxlbmd0aAotICAgICAgICAgICAgcHJpbnQtcXVvdGVkCi0gICAgICAgICAg ICAocHJpbnQtZXNjYXBlLWNvbnRyb2wtY2hhcmFjdGVycyB0KQotICAgICAgICAgICAgKHByaW50 LWVzY2FwZS1ub25hc2NpaSB0KQotICAgICAgICAgICAgKHByaW50LWNpcmNsZSB0KSkKLQkocHJp bnQgKHN5bWJvbC12YWx1ZSBzeW1ib2wpIChjdXJyZW50LWJ1ZmZlcikpKQotICAgICAgKHdyaXRl LXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4KQotICAgICAgICAgICAgICAgICAgICAocGVy c2lzdC0tZmlsZS1sb2NhdGlvbiBzeW1ib2wpCi0gICAgICAgICAgICAgICAgICAgIG5pbCAncXVp ZXQpKSkpCisgIChsZXQgKChzeW1ib2wtZmlsZS1sb2MgKHBlcnNpc3QtLWZpbGUtbG9jYXRpb24g c3ltYm9sKSkpCisgICAgKGlmIChlcXVhbCAoc3ltYm9sLXZhbHVlIHN5bWJvbCkKKyAgICAgICAg ICAgICAgIChwZXJzaXN0LWRlZmF1bHQgc3ltYm9sKSkKKyAgICAgICAgKHdoZW4gKGZpbGUtZXhp c3RzLXAgc3ltYm9sLWZpbGUtbG9jKQorICAgICAgICAgIChkZWxldGUtZmlsZSBzeW1ib2wtZmls ZS1sb2MpKQorICAgICAgKGxldCAoKGRpci1sb2MKKyAgICAgICAgICAgICAoZmlsZS1uYW1lLWRp cmVjdG9yeSBzeW1ib2wtZmlsZS1sb2MpKSkKKyAgICAgICAgKHVubGVzcyAoZmlsZS1leGlzdHMt cCBkaXItbG9jKQorICAgICAgICAgIChta2RpciBkaXItbG9jKSkKKyAgICAgICAgKHdpdGgtdGVt cC1idWZmZXIKKyAgICAgICAgICAobGV0IChwcmludC1sZXZlbAorICAgICAgICAgICAgICAgIHBy aW50LWxlbmd0aAorICAgICAgICAgICAgICAgIHByaW50LXF1b3RlZAorICAgICAgICAgICAgICAg IChwcmludC1lc2NhcGUtY29udHJvbC1jaGFyYWN0ZXJzIHQpCisgICAgICAgICAgICAgICAgKHBy aW50LWVzY2FwZS1ub25hc2NpaSB0KQorICAgICAgICAgICAgICAgIChwcmludC1jaXJjbGUgdCkp CisgICAgICAgICAgICAocHJpbnQgKHN5bWJvbC12YWx1ZSBzeW1ib2wpIChjdXJyZW50LWJ1ZmZl cikpKQorICAgICAgICAgICh3cml0ZS1yZWdpb24gKHBvaW50LW1pbikgKHBvaW50LW1heCkKKyAg ICAgICAgICAgICAgICAgICAgICAgIHN5bWJvbC1maWxlLWxvYworICAgICAgICAgICAgICAgICAg ICAgICAgbmlsICdxdWlldCkpKSkpKQogCiAoZGVmdW4gcGVyc2lzdC1kZWZhdWx0IChzeW1ib2wp CiAgICJSZXR1cm4gdGhlIGRlZmF1bHQgdmFsdWUgZm9yIFNZTUJPTC4iCmRpZmYgLS1naXQgYS90 ZXN0L3BlcnNpc3QtdGVzdHMuZWwgYi90ZXN0L3BlcnNpc3QtdGVzdHMuZWwKaW5kZXggOWZhNDA2 Zi4uYjY2NDVhOSAxMDA2NDQKLS0tIGEvdGVzdC9wZXJzaXN0LXRlc3RzLmVsCisrKyBiL3Rlc3Qv cGVyc2lzdC10ZXN0cy5lbApAQCAtNDQsNiArNDQsOSBAQAogICAgICAgICh3aXRoLXRlbXAtYnVm ZmVyCiAgICAgICAgICAoaW5zZXJ0LWZpbGUtY29udGVudHMgKHBlcnNpc3QtLWZpbGUtbG9jYXRp b24gc3ltKSkKICAgICAgICAgIChidWZmZXItc3RyaW5nKSkpKQorICAgICAoc2V0IHN5bSAxMCkK KyAgICAgKHBlcnNpc3Qtc2F2ZSBzeW0pCisgICAgIChzaG91bGQtbm90IChmaWxlLWV4aXN0cy1w IChwZXJzaXN0LS1maWxlLWxvY2F0aW9uIHN5bSkpKQogICAgICAoc2hvdWxkLWVycm9yCiAgICAg ICAocGVyc2lzdC1zYXZlICdmcmVkKSkpKSkKIAotLSAKMi4zNy4wLnJjMC4xMDQuZzA2MTE2MTFh OTQtZ29vZwoK --00000000000096217105e1fecca3--