From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gulshan Singh Newsgroups: gmane.emacs.bugs Subject: bug#54346: persist-save doesn't persist variables when the value is set to the default Date: Sun, 10 Apr 2022 12:36:54 -0700 Message-ID: References: <87r177ysjh.fsf@gnus.org> <87pmlpqgix.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000e0251c05dc51f348" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6127"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Phillip Lord , 54346@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 10 21:38:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nddOI-0001KM-7d for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Apr 2022 21:38:30 +0200 Original-Received: from localhost ([::1]:54528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nddOH-0000cX-09 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Apr 2022 15:38:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nddNs-0000cD-3a for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2022 15:38:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nddNq-0003iM-9v for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2022 15:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nddNq-0006kx-7x for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2022 15:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gulshan Singh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Apr 2022 19:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54346 X-GNU-PR-Package: emacs Original-Received: via spool by 54346-submit@debbugs.gnu.org id=B54346.164961943325900 (code B ref 54346); Sun, 10 Apr 2022 19:38:02 +0000 Original-Received: (at 54346) by debbugs.gnu.org; 10 Apr 2022 19:37:13 +0000 Original-Received: from localhost ([127.0.0.1]:41553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nddN3-0006je-2k for submit@debbugs.gnu.org; Sun, 10 Apr 2022 15:37:13 -0400 Original-Received: from mail-oi1-f179.google.com ([209.85.167.179]:41910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nddN1-0006jR-Ca for 54346@debbugs.gnu.org; Sun, 10 Apr 2022 15:37:11 -0400 Original-Received: by mail-oi1-f179.google.com with SMTP id e189so13968426oia.8 for <54346@debbugs.gnu.org>; Sun, 10 Apr 2022 12:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K1K+I0QqeIwIZtPWzwrvHhV51a3qiqyyNjktqKr4KfM=; b=qz10AOs0RIyKZlZ7Mw4bki+SoHmNmy0rfeS6BBK/epaf/8c6pE/5KwsOp2jfFHHsax D0Re3Ih2xT0fKjeuiVWNy28ud0+Fwj/iVFQrUbuvu+RKOXKgecWpa/J3n1m1fqCVqfE0 44cFW8yF9n3qVNWeEJB+pM2XjByrTkVgc/HmDDiLPn6AbIxDirCjU6IL411wXIvWDokC ncBCky6lM92i13TPpjNy2rCO0bNH2uR1djXbsc6/oAQQiYHES2aLqkguHBFyzLb8MYoA p57NEcSDUfSn+G0ifrp4gfyNg/yNNYwhjWSZpOXdR/OFwvQNO3QRmhfJJUqrPcZ06GEx l21Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K1K+I0QqeIwIZtPWzwrvHhV51a3qiqyyNjktqKr4KfM=; b=g3nDwXEXZY+/AareOQiG3X4lWJnQXMsW47FFrPcznY+5elfd3F4BqQqS5UkeGZr+bk CQmvFPtCv+SunXLncHbQtoJ9p5yQ2PtKJbBW8RwdGYf8ISaYrn0TV65o9KQOjlgATYrZ spWZct0GzFndEQ+i22YgJ6PuTMp2jiy5vq5br1e8l4AU2pext9oJ8F1MdThUwgNXrVq0 Ld/A31HT1AWi6Qmgx0vLlc0XrzuwKcsp0GrTMF6tJyuktWf+fnxnGIgEmgjoBMFbHQb7 XlGgb6nlSucgD96MkduZ1Oq6Ts92vqzfG1whEc1RZ055H4Wh1ceGZaRwLGN+6J2XKAJ1 U2OQ== X-Gm-Message-State: AOAM530JVo08w9sTPYte3aj0bTYXYo1hhUNwBLLzXI4WjUy1JWAe2dEJ 6fCISBs1XQEMoZ5XPoL1xbP0SUfeVgkma/jVV7eXEZTZVHI= X-Google-Smtp-Source: ABdhPJwtcnkgqJBc/I8cGPEEIs6VxEDemujcPvQlsoCl4pOxczBrA5tp8AK2zHi456/5zJ8iwA0l7Vu1XNgQfx++Gq8= X-Received: by 2002:a05:6808:3094:b0:2f9:61ab:32fc with SMTP id bl20-20020a056808309400b002f961ab32fcmr4109506oib.261.1649619425560; Sun, 10 Apr 2022 12:37:05 -0700 (PDT) In-Reply-To: <87pmlpqgix.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229685 Archived-At: --000000000000e0251c05dc51f348 Content-Type: text/plain; charset="UTF-8" Hi, I cloned the upstream project [1] and created a merge request [2] there. The fix deletes the persist file when it gets set back to the default value, and it modifies a test to verify this behavior. I've attached the same patch here (created with `git format-patch HEAD^`, I haven't submitted a patch here before so let me know if this is the correct way to do this). I'm a little confused though, I see that on the externals/persist branch [3] there is a commit that does not exist on the upstream GitLab project. Why is this the case? Should I actually be making a patch off of the externals/persist branch? [1] https://gitlab.com/phillord/persist/ [2] https://gitlab.com/phillord/persist/-/merge_requests/1 [3] https://git.savannah.gnu.org/cgit/emacs/elpa.git/log/?h=externals/persist On Sun, Apr 10, 2022 at 5:17 AM Lars Ingebrigtsen wrote: > > Gulshan Singh writes: > > > If either of these solutions make sense, or if Phillip has any other > > suggestions, I'd be happy to make the fix myself if that would be > > easier. > > Yes, that'd be great (and post the patch here). > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no --000000000000e0251c05dc51f348 Content-Type: application/octet-stream; name="0001-Delete-persist-file-when-symbol-is-set-to-default-va.patch" Content-Disposition: attachment; filename="0001-Delete-persist-file-when-symbol-is-set-to-default-va.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l1toih1n0 RnJvbSBiMDQ5NmE1YTg4NDhkMTEyMzNmMjQxZjZiNzhmMDBmMTUzNjQxMGQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdWxzaGFuIFNpbmdoIDxnc2luZ2gyMDExQGdtYWlsLmNvbT4K RGF0ZTogU3VuLCAxMCBBcHIgMjAyMiAxMjoxMzozMSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIERl bGV0ZSBwZXJzaXN0IGZpbGUgd2hlbiBzeW1ib2wgaXMgc2V0IHRvIGRlZmF1bHQgdmFsdWUKCi0t LQogcGVyc2lzdC5lbCAgICAgICAgICAgIHwgMjYgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0K IHRlc3QvcGVyc2lzdC10ZXN0cy5lbCB8ICAzICsrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNl cnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9wZXJzaXN0LmVsIGIvcGVy c2lzdC5lbAppbmRleCAwOTFlNDI4Li44YjY0NWVhIDEwMDY0NAotLS0gYS9wZXJzaXN0LmVsCisr KyBiL3BlcnNpc3QuZWwKQEAgLTEzMiwxOCArMTMyLDIwIEBAIHZhcmlhYmxlcyBwZXJzaXN0IGF1 dG9tYXRpY2FsbHkgd2hlbiBFbWFjcyBleGl0cy4iCiAgICh1bmxlc3MgKHBlcnNpc3QtLXBlcnNp c3RhbnQtcCBzeW1ib2wpCiAgICAgKGVycm9yIChmb3JtYXQKICAgICAgICAgICAgICJTeW1ib2wg JXMgaXMgbm90IHBlcnNpc3RhbnQiIHN5bWJvbCkpKQotICAodW5sZXNzIChlcXVhbCAoc3ltYm9s LXZhbHVlIHN5bWJvbCkKLSAgICAgICAgICAgICAgICAgKHBlcnNpc3QtZGVmYXVsdCBzeW1ib2wp KQotICAgIChsZXQgKChkaXItbG9jCi0gICAgICAgICAgIChmaWxlLW5hbWUtZGlyZWN0b3J5Ci0g ICAgICAgICAgICAocGVyc2lzdC0tZmlsZS1sb2NhdGlvbiBzeW1ib2wpKSkpCi0gICAgICAodW5s ZXNzIChmaWxlLWV4aXN0cy1wIGRpci1sb2MpCi0gICAgICAgIChta2RpciBkaXItbG9jKSkpCi0g ICAgKHdpdGgtdGVtcC1idWZmZXIKLSAgICAgIChwcmludCAoc3ltYm9sLXZhbHVlIHN5bWJvbCkg KGN1cnJlbnQtYnVmZmVyKSkKLSAgICAgICh3cml0ZS1yZWdpb24gKHBvaW50LW1pbikgKHBvaW50 LW1heCkKLSAgICAgICAgICAgICAgICAgICAgKHBlcnNpc3QtLWZpbGUtbG9jYXRpb24gc3ltYm9s KQotICAgICAgICAgICAgICAgICAgICBuaWwgJ3F1aWV0KSkpKQorICAobGV0ICgoc3ltYm9sLWZp bGUtbG9jIChwZXJzaXN0LS1maWxlLWxvY2F0aW9uIHN5bWJvbCkpKQorICAgIChpZiAoZXF1YWwg KHN5bWJvbC12YWx1ZSBzeW1ib2wpCisgICAgICAgICAgICAgICAocGVyc2lzdC1kZWZhdWx0IHN5 bWJvbCkpCisgICAgICAgICh3aGVuIChmaWxlLWV4aXN0cy1wIHN5bWJvbC1maWxlLWxvYykKKyAg ICAgICAgICAoZGVsZXRlLWZpbGUgc3ltYm9sLWZpbGUtbG9jKSkKKyAgICAgIChsZXQgKChkaXIt bG9jCisgICAgICAgICAgICAgKGZpbGUtbmFtZS1kaXJlY3Rvcnkgc3ltYm9sLWZpbGUtbG9jKSkp CisgICAgICAgICh1bmxlc3MgKGZpbGUtZXhpc3RzLXAgZGlyLWxvYykKKyAgICAgICAgICAobWtk aXIgZGlyLWxvYykpCisgICAgICAgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAgICAgKHByaW50 IChzeW1ib2wtdmFsdWUgc3ltYm9sKSAoY3VycmVudC1idWZmZXIpKQorICAgICAgICAgICh3cml0 ZS1yZWdpb24gKHBvaW50LW1pbikgKHBvaW50LW1heCkKKyAgICAgICAgICAgICAgICAgICAgICAg IHN5bWJvbC1maWxlLWxvYworICAgICAgICAgICAgICAgICAgICAgICAgbmlsICdxdWlldCkpKSkp KQogCiAoZGVmdW4gcGVyc2lzdC1kZWZhdWx0IChzeW1ib2wpCiAgICJSZXR1cm4gdGhlIGRlZmF1 bHQgdmFsdWUgZm9yIFNZTUJPTC4iCmRpZmYgLS1naXQgYS90ZXN0L3BlcnNpc3QtdGVzdHMuZWwg Yi90ZXN0L3BlcnNpc3QtdGVzdHMuZWwKaW5kZXggOWZhNDA2Zi4uYjY2NDVhOSAxMDA2NDQKLS0t IGEvdGVzdC9wZXJzaXN0LXRlc3RzLmVsCisrKyBiL3Rlc3QvcGVyc2lzdC10ZXN0cy5lbApAQCAt NDQsNiArNDQsOSBAQAogICAgICAgICh3aXRoLXRlbXAtYnVmZmVyCiAgICAgICAgICAoaW5zZXJ0 LWZpbGUtY29udGVudHMgKHBlcnNpc3QtLWZpbGUtbG9jYXRpb24gc3ltKSkKICAgICAgICAgIChi dWZmZXItc3RyaW5nKSkpKQorICAgICAoc2V0IHN5bSAxMCkKKyAgICAgKHBlcnNpc3Qtc2F2ZSBz eW0pCisgICAgIChzaG91bGQtbm90IChmaWxlLWV4aXN0cy1wIChwZXJzaXN0LS1maWxlLWxvY2F0 aW9uIHN5bSkpKQogICAgICAoc2hvdWxkLWVycm9yCiAgICAgICAocGVyc2lzdC1zYXZlICdmcmVk KSkpKSkKIAotLSAKMi4zNS4xLjExNzguZzRmMTY1OWQ0NzYtZ29vZwoK --000000000000e0251c05dc51f348--