From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gulshan Singh Newsgroups: gmane.emacs.bugs Subject: bug#54346: persist-save doesn't persist variables when the value is set to the default Date: Mon, 20 Jun 2022 19:14:35 -0700 Message-ID: References: <87r177ysjh.fsf@gnus.org> <87pmlpqgix.fsf@gnus.org> <87ee23diue.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d61b9505e1ebc85b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25354"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54346@debbugs.gnu.org, Phillip Lord To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 21 04:15:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3TQZ-0006O9-Ht for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jun 2022 04:15:39 +0200 Original-Received: from localhost ([::1]:56082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3TQX-00080p-SZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jun 2022 22:15:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3TPy-0007ye-Uc for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 22:15:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3TPy-00080y-MA for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 22:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3TPy-0001kV-FK for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 22:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gulshan Singh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jun 2022 02:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54346 X-GNU-PR-Package: emacs Original-Received: via spool by 54346-submit@debbugs.gnu.org id=B54346.16557776986695 (code B ref 54346); Tue, 21 Jun 2022 02:15:02 +0000 Original-Received: (at 54346) by debbugs.gnu.org; 21 Jun 2022 02:14:58 +0000 Original-Received: from localhost ([127.0.0.1]:58857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3TPt-0001ju-Jj for submit@debbugs.gnu.org; Mon, 20 Jun 2022 22:14:57 -0400 Original-Received: from mail-oa1-f46.google.com ([209.85.160.46]:46728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3TPp-0001jd-BB for 54346@debbugs.gnu.org; Mon, 20 Jun 2022 22:14:56 -0400 Original-Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1013ecaf7e0so16629650fac.13 for <54346@debbugs.gnu.org>; Mon, 20 Jun 2022 19:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ndry1FqfOCIyiStH4FaK2SKvTKPszAzzcrA6fhogIcY=; b=e6RtCD1mHjNtyX1sYZijoBfNO5p8gC7Tz+30vQ/a6EGRzYbRqFDttTLitxLG1KDP2S /CTcB1aD9OwmyXGmFT1iwpA9dyggkUffNJhOa9ScO04HTEMlqf1SnbikFTwquEfbb19y 5Avpi/FjhW8MqQNU+A+g5CwmvJf3rzHjeclE5KqhFeqVpBpXjRv0SBsXRqefzVUafQBS D5MTq/m8nxFse1GLmMLXdJtev7Dlx6SpxX768O7cg21EG5L7ssXH0uuQANnxLqmz0iBn GSiEyQ71IUyruw2Zc0+HCUJL08PZEzO3t2qDTUP5BPTDVQTyBkUAdonOWNyOfYk8gttv ehVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ndry1FqfOCIyiStH4FaK2SKvTKPszAzzcrA6fhogIcY=; b=kROyzHXIMJXtbSxk1aeCXPDb51bLL6KtsW8YXPCRPZzVv6q/9CyvraCPLuQBCka5oz 6CJ6l8VgDccTQ9TMtCJSi2q6ewj39yz0SZffqrsy/Pnu5xUm/j1zW6YOg/10IS7XTnWO c0BPlw+DQ44wjohghbn/VqPAgnMtd/1lz/D7GrfhPSGQMay/AND5CYksyDXf4ylcue6o evNnfKfbUfSCHPnBa8EeUx42zrTTKy604B2su/v/4/K9tvjgajSzPNBYo4u3mbbd8mG+ +YTuIOqIPK6S8j9rbg+tKPWQdjZSqHUxTxsHjsZ8a4pOatQmh0eL1RKuX4HGjSt3byxX Jzpg== X-Gm-Message-State: AJIora+VQvJHUWJDm2Mw0equQXedhC+aPm+Vgcg4/hTc6ff3oYu+wg4Y AsoMeAA+JIuvn6v+pBT0zRURGp1jl3ymrzeM0jSm3aFW X-Google-Smtp-Source: AGRyM1vxffCa5X1NBoQQioak9s5U+SEtNzN7QOnHh2yTFxnVfFcnpetmBQG7EgzIPCivsa78iWwsDSKyhNvgSd7nGTc= X-Received: by 2002:a05:6871:91:b0:fe:1977:afb9 with SMTP id u17-20020a056871009100b000fe1977afb9mr13948106oaa.83.1655777686591; Mon, 20 Jun 2022 19:14:46 -0700 (PDT) In-Reply-To: <87ee23diue.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234926 Archived-At: --000000000000d61b9505e1ebc85b Content-Type: text/plain; charset="UTF-8" Hi, It's been a few months since the last message here. I also directly sent Phillip an email last week asking if he could take a look at my PR, but I haven't received a response. Do you know what's normally done in cases like this? Even if persist.el is maintained externally, should we just merge my patch and close this bug if we can't get a response from the maintainer? On Mon, Apr 11, 2022 at 3:18 AM Lars Ingebrigtsen wrote: > Gulshan Singh writes: > > > I cloned the upstream project [1] and created a merge request [2] > > there. The fix deletes the persist file when it gets set back to the > > default value, and it modifies a test to verify this behavior. I've > > attached the same patch here (created with `git format-patch HEAD^`, I > > haven't submitted a patch here before so let me know if this is the > > correct way to do this). > > Yup; looks good. > > > I'm a little confused though, I see that on the externals/persist > > branch [3] there is a commit that does not exist on the upstream > > GitLab project. Why is this the case? Should I actually be making a > > patch off of the externals/persist branch? > > That's my error -- I didn't check whether it persist was maintained > externally before making that change. So it should be merged upstream. > > Phillip? > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --000000000000d61b9505e1ebc85b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

It's been a few months since th= e last message here. I also directly sent Phillip an email last week asking= if he could take a look at my PR, but I haven't received a response.
Do you know what's normally done in cases like this? Even if pers= ist.el is maintained externally, should we just merge my patch and close th= is bug if we can't get a response from the maintainer?

<= div class=3D"gmail_quote">
On Mon, Apr= 11, 2022 at 3:18 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
Gulshan Singh <gsingh2011@gmail.com> writes:

> I cloned the upstream project [1] and created a merge request [2]
> there. The fix deletes the persist file when it gets set back to the > default value, and it modifies a test to verify this behavior. I'v= e
> attached the same patch here (created with `git format-patch HEAD^`, I=
> haven't submitted a patch here before so let me know if this is th= e
> correct way to do this).

Yup; looks good.

> I'm a little confused though, I see that on the externals/persist<= br> > branch [3] there is a commit that does not exist on the upstream
> GitLab project. Why is this the case? Should I actually be making a > patch off of the externals/persist branch?

That's my error -- I didn't check whether it persist was maintained=
externally before making that change.=C2=A0 So it should be merged upstream= .

Phillip?

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no
--000000000000d61b9505e1ebc85b--