From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alexander Kuleshov Newsgroups: gmane.emacs.bugs Subject: bug#27597: [PATCH] fix warnings in src/xdisp.c Date: Sat, 8 Jul 2017 16:28:48 +0600 Message-ID: References: <83h8ynl4rv.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1499509826 25677 195.159.176.226 (8 Jul 2017 10:30:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Jul 2017 10:30:26 +0000 (UTC) Cc: 27597-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 08 12:30:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTn08-0005pE-0t for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Jul 2017 12:30:12 +0200 Original-Received: from localhost ([::1]:60543 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTn0B-0000yX-R3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Jul 2017 06:30:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTn02-0000vx-13 for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 06:30:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTmzy-0008MU-Tb for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 06:30:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54652) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dTmzy-0008MN-Qr for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 06:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dTmzy-0007UZ-I4 for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 06:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alexander Kuleshov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jul 2017 10:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27597-done@debbugs.gnu.org id=D27597.149950975728723 (code D ref 27597); Sat, 08 Jul 2017 10:30:02 +0000 Original-Received: (at 27597-done) by debbugs.gnu.org; 8 Jul 2017 10:29:17 +0000 Original-Received: from localhost ([127.0.0.1]:57329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTmzE-0007TC-Rb for submit@debbugs.gnu.org; Sat, 08 Jul 2017 06:29:17 -0400 Original-Received: from mail-lf0-f46.google.com ([209.85.215.46]:36660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTmzC-0007T0-Oh for 27597-done@debbugs.gnu.org; Sat, 08 Jul 2017 06:29:15 -0400 Original-Received: by mail-lf0-f46.google.com with SMTP id h22so36791378lfk.3 for <27597-done@debbugs.gnu.org>; Sat, 08 Jul 2017 03:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kFZuTwRHyHjd9MmnRjr+utust1uduWrx6/C39ia7Kvk=; b=NqoQ9BPxXMkVkiBHc7oliSvoINKchksmSQEA/F0WvVgSzp/75c+DEIidk/TTcjtDxg BFyCkC/9eDxMfp7zEScwb95V0Qotd7b+3EfL58oN20MbZMeTX/cVWZJUiKIgU4vKiULr G64fb78ue0dxrVvNMbwscScU/YV9m2dV3jJlF+2VRVXH/8evnPWB3s7/P4N5Nc8K6VWu IB/8gsOsG9vW1dTt2RVqc1HzWvKo+Jz9zumF5f+aQIa8MrS904+RTGGH/QM1dGAYzfy/ 0chGv0tuK4W7NfZHLJ/k1sTjbGKe2Pui/NoM8WUUnjyXTs1aI0e6kk3Ey5xh+wVe+KJD dD+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kFZuTwRHyHjd9MmnRjr+utust1uduWrx6/C39ia7Kvk=; b=iNhea9CVMegLl+z1NZ4TYf7j4qK466CI69glYVmbrL+JOXJBU+dRhlc7AeGbuqwPkw kvovtSKRsoCfmWIUAUoIt12MwObtZiejYqt5JP650SsnV/7Oh7qraeMy/ZxWDbqA7Om7 kTpAxbQ3PrK7n2g2UofL9WmPwqLSFL7xa0Yjgu6gm+sr5Gt+Oa/K9sqOYSmSupbtmsXw sCiczDWjfa8R+32e6PS79GDHYMpDdtTwIYMRHVoKESyUEFE4BtiRbNSdTgGNetpkue1i ZKI7Db8HndNYBPdjyqKlPeQ4TWDd5NHkFT0jkJuMaqxvVK71d1WxWso0QtMy/JxUzSZ/ mwJA== X-Gm-Message-State: AKS2vOwqtUa98DzkvvnvfVAJ92O5n/4Qlu0AV43k6O3U3UQLE9LDilRw qNSMCBXJGrLBeEPQvh+yDyCfN98T1A== X-Received: by 10.25.25.65 with SMTP id 62mr21764181lfz.91.1499509748736; Sat, 08 Jul 2017 03:29:08 -0700 (PDT) Original-Received: by 10.25.27.131 with HTTP; Sat, 8 Jul 2017 03:28:48 -0700 (PDT) In-Reply-To: <83h8ynl4rv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134329 Archived-At: On Sat, Jul 8, 2017 at 2:19 PM, Eli Zaretskii wrote: >> From: Alexander Kuleshov >> Date: Thu, 6 Jul 2017 17:47:03 +0600 >> >> here is simple fix for following warnings: >> >> xdisp.c: In function =E2=80=98Fdump_glyph_matrix=E2=80=99: >> xdisp.c:19320:20: error: format =E2=80=98%lld=E2=80=99 expects argument = of type =E2=80=98long >> long int=E2=80=99, but argument 3 has type =E2=80=98ptrdiff_t {aka long = int}=E2=80=99 >> [-Werror=3Dformat=3D] >> fprintf (stderr, "PT =3D %"pI"d, BEGV =3D %"pI"d. ZV =3D %"pI"d\n", >> >> from src/xdisp.c > > Thanks, pushed to master. > > In the future, please provide a commit log message that is according > to our coding standards: > > . mention the names of functions in which you make changes > . start sentences with a capital letter > . mention the bug number > > Here's the log message I used in this case: > > * src/xdisp.c (dump_glyph, dump_glyph_row, Fdump_glyph_matrix): > Use pD directives for ptrdiff_t values instead of pI, to avoid > compilation warnings on 64-bit hosts. (Bug#27597) > Hello Eli, Yes, thanks, I'll take into account code style next time.