From: Ankit Gadiya via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>, 69562@debbugs.gnu.org
Subject: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph
Date: Thu, 7 Mar 2024 15:48:50 +0530 [thread overview]
Message-ID: <CAN7zea2WunTj=FuL=gPz5-EV0gXZf9W9Vy1Zz=qf9iOAMV3dZg@mail.gmail.com> (raw)
In-Reply-To: <86a5na2xh3.fsf@gnu.org>
On Thu, 7 Mar 2024 at 15:08, Eli Zaretskii <eliz@gnu.org> wrote:
> I note that this bug and its discussion lack the minimal reproducible
> recipe, at least there's no complete recipe. You start with showing
> some incomplete snippet, and AFAICT never show anything more detailed.
> So would you please post such a complete recipe, including:
>
> . a Go source file to visit
> . the sequence of Emacs command/keys to type in order to reproduce
> the problem, after visiting the above file
> . what you get in the buffer after these commands
>
> You see, I fear that you and Dmitry are not doing the same in your
> reproduction steps, and that is why Dmitry cannot reproduce the issue
> you are complaining about. Having a complete self-contained recipe
> with all the details will go a long way towards eliminating the
> differences between what you see. (It will also allow me to try
> reproducing this, as currently I have no idea what to type in the
> buffer under go-ts-mode to begin with.)
>
> Thanks.
In retrospect that makes sense, thank you. In fact I was able to figure
out the issue with reproduction, as I followed the advice of recording exact
command sequence.
Following is the full Go file to reproduce the issue:
```
package main
// This is the docstring for the main function that extends beyond
fill-column value.
func main() {
}
```
Following is the exact steps to reproduce the issue:
* emacs -Q main.go
* M-x go-ts-mode
* Highlight the full docstring line with Mouse.
* M-x fill-paragraph
This is the result in the buffer after executing the above steps:
```
package main
// This is the docstring for the main function that extends beyond
fill-column value.
func main() {
}
```
I think the difference between Dmitry and me was that I was highlighting the
docstring and Dmitry was not. I tried the same steps but without highlighting
just with the cursor somewhere in the docstring line and it worked as expected.
I believe this is what Dmitry observed as well. This is the content of my buffer
without highlighting the step.
```
package main
// This is the docstring for the main function that extends beyond
// fill-column value.
func main() {
}
```
(Please don't mind the repeated email, I forgot to CC the Bugtracker.)
On Thu, 7 Mar 2024 at 15:08, Eli Zaretskii <eliz@gnu.org> wrote:
>
> > Date: Thu, 7 Mar 2024 14:28:52 +0530
> > From: Ankit Gadiya via "Bug reports for GNU Emacs,
> > the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >
> > On Thu, 7 Mar 2024 at 07:27, Dmitry Gutov <dmitry@gutov.dev> wrote:
> > >
> > > Could you confirm that your problem reproduces if you start Emacs as
> > > 'emacs -Q'?
> >
> > I did notice some files from earlier versions of Emacs installation on my
> > machine. So just to rule it out, I cleared all the installations and re-compiled
> > and re-installed Emacs locally from the same commit again. Unfortunately, it is
> > still reproducing in the `emacs -Q` session.
> >
> > This is the output of `emacs-version` inside `emacs -Q` session.
> >
> > GNU Emacs 29.2.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.38,
> > cairo version 1.16.0) of 2024-03-04
> >
> > This is the partial output from the `report-emacs-bug` buffer in the same `emacs
> > -Q` session.
> >
> > In GNU Emacs 29.2.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
> > 3.24.38, cairo version 1.16.0) of 2024-03-04 built on t14
> > Repository revision: ae80192d97b8d0e54a9429091cd84190bdbeb49e
> > Repository branch: emacs-29
> > System Description: Debian GNU/Linux 12 (bookworm)
> >
> > I also tried fetching newer changes from the `emacs-29` branch and I'm
> > still able to reproduce it.
> >
> > GNU Emacs 29.2.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38,
> > cairo version 1.16.0) of 2024-03-07
> >
> > In GNU Emacs 29.2.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> > 3.24.38, cairo version 1.16.0) of 2024-03-07 built on t14
> > Repository revision: 6e801077ae88e72dbad32015a083602062c4efe3
> > Repository branch: emacs-29
> > System Description: Debian GNU/Linux 12 (bookworm)
>
> I note that this bug and its discussion lack the minimal reproducible
> recipe, at least there's no complete recipe. You start with showing
> some incomplete snippet, and AFAICT never show anything more detailed.
> So would you please post such a complete recipe, including:
>
> . a Go source file to visit
> . the sequence of Emacs command/keys to type in order to reproduce
> the problem, after visiting the above file
> . what you get in the buffer after these commands
>
> You see, I fear that you and Dmitry are not doing the same in your
> reproduction steps, and that is why Dmitry cannot reproduce the issue
> you are complaining about. Having a complete self-contained recipe
> with all the details will go a long way towards eliminating the
> differences between what you see. (It will also allow me to try
> reproducing this, as currently I have no idea what to type in the
> buffer under go-ts-mode to begin with.)
>
> Thanks.
next prev parent reply other threads:[~2024-03-07 10:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 8:41 bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-05 12:44 ` Eli Zaretskii
2024-03-05 13:03 ` Dmitry Gutov
[not found] ` <CAN7zea2d+Ku3YG6hw9xw1xKRkkomf7pji8JArZskHbJ2CwZOGw@mail.gmail.com>
2024-03-05 14:49 ` Dmitry Gutov
2024-03-05 15:49 ` Eli Zaretskii
2024-03-05 18:59 ` Dmitry Gutov
2024-03-06 5:22 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-07 1:57 ` Dmitry Gutov
2024-03-07 8:58 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-07 9:38 ` Eli Zaretskii
2024-03-07 10:18 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
[not found] ` <CAN7zea13N9xgVLzQAFUiZiiVajB1vzQmh=vbaWOW97VKvL71Ww@mail.gmail.com>
2024-03-07 10:55 ` Eli Zaretskii
2024-03-07 11:13 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-07 14:15 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN7zea2WunTj=FuL=gPz5-EV0gXZf9W9Vy1Zz=qf9iOAMV3dZg@mail.gmail.com' \
--to=bug-gnu-emacs@gnu.org \
--cc=69562@debbugs.gnu.org \
--cc=ankit@argp.in \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).