unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#66507: 30.0.50; Cannot build some modules without adding LOCAL_EXPORT_CFLAGS=-isystem ... on Android port.
@ 2023-10-12 21:17 Takesi Ayanokoji
  2023-10-13  1:06 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 6+ messages in thread
From: Takesi Ayanokoji @ 2023-10-12 21:17 UTC (permalink / raw)
  To: 66507

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Hello,

Duaring building Emacs Android port, I encountered some modules that could
not build without specifying system include header file by -isystem.

These modules are

libxml2:
add LOCAL_EXPORT_CFLAGS := -isystem $(LOCAL_PATH)/include
 to its Android.mk.

lbjansson:
add LOCAL_EXPORT_CFLAGS := -isystem $(LOCAL_PATH)/src -I
$(LOCAL_PATH)/android
 to its Android.mk

core/libpackagelistparser:
add LOCAL_EXPORT_CFLAGS := -isystem $(LOCAL_PATH)/../include
(I installed it from core/libpackagelistparser)

Thanks,

[-- Attachment #2: Type: text/html, Size: 990 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#66507: 30.0.50; Cannot build some modules without adding LOCAL_EXPORT_CFLAGS=-isystem ... on Android port.
  2023-10-12 21:17 bug#66507: 30.0.50; Cannot build some modules without adding LOCAL_EXPORT_CFLAGS=-isystem ... on Android port Takesi Ayanokoji
@ 2023-10-13  1:06 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-10-13  4:30   ` Takesi Ayanokoji
  0 siblings, 1 reply; 6+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-10-13  1:06 UTC (permalink / raw)
  To: Takesi Ayanokoji; +Cc: 66507

Takesi Ayanokoji <ayanokoji.takesi@gmail.com> writes:

> Hello,
>
> Duaring building Emacs Android port, I encountered some modules that could not build without specifying system include header file by -isystem.
>
> These modules are
>
> libxml2:
> add LOCAL_EXPORT_CFLAGS := -isystem $(LOCAL_PATH)/include
>  to its Android.mk.
>
> lbjansson:
> add LOCAL_EXPORT_CFLAGS := -isystem $(LOCAL_PATH)/src -I $(LOCAL_PATH)/android
>  to its Android.mk
>
> core/libpackagelistparser:
> add LOCAL_EXPORT_CFLAGS := -isystem $(LOCAL_PATH)/../include
> (I installed it from core/libpackagelistparser)
>
> Thanks,

IIRC all three of these changes are mentioned in java/INSTALL, but
please correct me if I'm wrong.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#66507: 30.0.50; Cannot build some modules without adding LOCAL_EXPORT_CFLAGS=-isystem ... on Android port.
  2023-10-13  1:06 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-10-13  4:30   ` Takesi Ayanokoji
  2023-10-13  5:01     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 6+ messages in thread
From: Takesi Ayanokoji @ 2023-10-13  4:30 UTC (permalink / raw)
  To: Po Lu; +Cc: 66507

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

Hello Po- san.

Unfortunately it doesn't seem to be mentioned in the java/INSTALL.

Thanks,

2023年10月13日(金) 午前10:06 Po Lu <luangruo@yahoo.com>:

> Takesi Ayanokoji <ayanokoji.takesi@gmail.com> writes:
>
> > Hello,
> >
> > Duaring building Emacs Android port, I encountered some modules that
> could not build without specifying system include header file by -isystem.
> >
> > These modules are
> >
> > libxml2:
> > add LOCAL_EXPORT_CFLAGS := -isystem $(LOCAL_PATH)/include
> >  to its Android.mk.
> >
> > lbjansson:
> > add LOCAL_EXPORT_CFLAGS := -isystem $(LOCAL_PATH)/src -I
> $(LOCAL_PATH)/android
> >  to its Android.mk
> >
> > core/libpackagelistparser:
> > add LOCAL_EXPORT_CFLAGS := -isystem $(LOCAL_PATH)/../include
> > (I installed it from core/libpackagelistparser)
> >
> > Thanks,
>
> IIRC all three of these changes are mentioned in java/INSTALL, but
> please correct me if I'm wrong.
>

[-- Attachment #2: Type: text/html, Size: 1482 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#66507: 30.0.50; Cannot build some modules without adding LOCAL_EXPORT_CFLAGS=-isystem ... on Android port.
  2023-10-13  4:30   ` Takesi Ayanokoji
@ 2023-10-13  5:01     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-10-13  6:40       ` Takesi Ayanokoji
  0 siblings, 1 reply; 6+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-10-13  5:01 UTC (permalink / raw)
  To: Takesi Ayanokoji; +Cc: 66507-done

Takesi Ayanokoji <ayanokoji.takesi@gmail.com> writes:

> Hello Po- san.
>
> Unfortunately it doesn't seem to be mentioned in the java/INSTALL.

I've now repaired these ommissions; that being said, I opted to
recommend modifications to the Makefiles different from those you
mentioned, for include paths are customarily exported through the
variable LOCAL_EXPROT_C_INCLUDE_DIRS, not variables meant for exporting
CFLAGS.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#66507: 30.0.50; Cannot build some modules without adding LOCAL_EXPORT_CFLAGS=-isystem ... on Android port.
  2023-10-13  5:01     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-10-13  6:40       ` Takesi Ayanokoji
  2023-10-15 17:35         ` ayatakesi
  0 siblings, 1 reply; 6+ messages in thread
From: Takesi Ayanokoji @ 2023-10-13  6:40 UTC (permalink / raw)
  To: Po Lu; +Cc: 66507-done

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

Hello,

I will try LOCAL_EXPORT_C_INCLUDE_DIRS instead.

Thanks,

2023年10月13日(金) 午後2:02 Po Lu <luangruo@yahoo.com>:

> Takesi Ayanokoji <ayanokoji.takesi@gmail.com> writes:
>
> > Hello Po- san.
> >
> > Unfortunately it doesn't seem to be mentioned in the java/INSTALL.
>
> I've now repaired these ommissions; that being said, I opted to
> recommend modifications to the Makefiles different from those you
> mentioned, for include paths are customarily exported through the
> variable LOCAL_EXPROT_C_INCLUDE_DIRS, not variables meant for exporting
> CFLAGS.
>

[-- Attachment #2: Type: text/html, Size: 1064 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#66507: 30.0.50; Cannot build some modules without adding LOCAL_EXPORT_CFLAGS=-isystem ... on Android port.
  2023-10-13  6:40       ` Takesi Ayanokoji
@ 2023-10-15 17:35         ` ayatakesi
  0 siblings, 0 replies; 6+ messages in thread
From: ayatakesi @ 2023-10-15 17:35 UTC (permalink / raw)
  To: Po Lu; +Cc: 66507-done

Hello, again

I tried LOCAL_EXPORT_C_INCLUDE_DIRS, and worked fine
 except core/libpackagelistparser.

When I build libpackagelistparser, make failed with

/home/runner/work/my-emacs/my-emacs/my_sub_modules/core/libpackagelistparser//packagelistparser.c:30:10: fatal error: 'utils/Log.h' file not found
#include <utils/Log.h>
         ^~~~~~~~~~~~~

I cloned core package from Google, and I specify such bellow

directory structure:
core
|-libpackagelistparser
    Android.mk
|-utils
  |-include
      Log.h

in Android.mk:
LOCAL_EXPORT_C_INCLUDE_DIRS += $(LOCAL_PATH)/../include

But LOCAL_EXPORT_C_INCLUDE_DIRS and LOCAL_EXPORT_C_INCLUDES
 did not work except LOCAL_EXPORT_CFLAGS.


Takesi Ayanokoji <ayanokoji.takesi@gmail.com> writes:

> Hello,
>
> I will try LOCAL_EXPORT_C_INCLUDE_DIRS instead.
>
> Thanks,
>
> 2023年10月13日(金) 午後2:02 Po Lu <luangruo@yahoo.com>:
>
>  Takesi Ayanokoji <ayanokoji.takesi@gmail.com> writes:
>
>  > Hello Po- san.
>  >
>  > Unfortunately it doesn't seem to be mentioned in the
>  java/INSTALL.
>
>  I've now repaired these ommissions; that being said, I
>  opted to
>  recommend modifications to the Makefiles different from
>  those you
>  mentioned, for include paths are customarily exported
>  through the
>  variable LOCAL_EXPROT_C_INCLUDE_DIRS, not variables
>  meant for exporting
>  CFLAGS.





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-10-15 17:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-12 21:17 bug#66507: 30.0.50; Cannot build some modules without adding LOCAL_EXPORT_CFLAGS=-isystem ... on Android port Takesi Ayanokoji
2023-10-13  1:06 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-13  4:30   ` Takesi Ayanokoji
2023-10-13  5:01     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-13  6:40       ` Takesi Ayanokoji
2023-10-15 17:35         ` ayatakesi

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).