From: Ray <emacsray@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 29619@debbugs.gnu.org
Subject: bug#29619: Fwd: [xref.el] Add `xref-find-references` to `xref-prompt-for-identifier`
Date: Sat, 9 Dec 2017 09:52:00 -0800 [thread overview]
Message-ID: <CAN30aBHFu3fyC9vtj2J177ijWFVmo0skWGw5E1sbPwPhfrd2Lg@mail.gmail.com> (raw)
In-Reply-To: <c670749b-a6dc-39cb-0ac2-87f0046b1ce5@yandex.ru>
Thanks for being open to change the default if more people feel the same.
With the xref system people use drifting from tag based
(ctags,etags,GNU GLOBAL,cscope,...) tools to Language Server Protocol
(cquery, rls, ...),
a single identifier without position has become insufficient to
describe the one the user wants to look up. For example, a local
variable/struct/lambda `foo` may exist
in different functions.
I'm using a C++ language server called cquery. This is what I get (for
the argument `identifier`) when I hit the key bound to
`xref-find-definitions`:
#("QueryDatabase" 0 13 (fontified t ref-params (:textDocument (:uri
"file:///home/maskray/Dev/Util/cquery/src/query_utils.h") :position
(:line 11 :character 54) :context (:includeDeclaration :json-false))
def-params (:textDocument (:uri
"file:///home/maskray/Dev/Util/cquery/src/query_utils.h") :position
(:line 11 :character 54))))
Here the text properties are more useful than the identifier itself,
because LSP uses position instead of identifier to sending requests to
the language server.
https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#textdocumentpositionparams
This is my 2 cents. I am totally fine to live with the current default
`xref-prompt-for-identifier` because I can customize it.
On Sat, Dec 9, 2017 at 7:25 AM, Dmitry Gutov <dgutov@yandex.ru> wrote:
> On 12/8/17 11:27 PM, Ray wrote:
>>
>> Currently, xref-find-references prompts for the identifier to look up,
>> because it is not listed in xref-prompt-for-identifier:
>>
>> (defcustom xref-prompt-for-identifier '(not xref-find-definitions
>>
>> xref-find-definitions-other-window
>>
>> xref-find-definitions-other-frame)
>>
>> It will be much core convenient to add xref-find-references in the list.
>
>
> We've discussed it before, and for now have settled on this list of
> non-prompting functions.
>
> But thank you for your report. We may change the default if more people feel
> the same.
next prev parent reply other threads:[~2017-12-09 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAN30aBF0FcQpH+DDxR5ggWgwYHPn41nzdgNdUXSt2j0mXY39-A@mail.gmail.com>
2017-12-08 21:27 ` bug#29619: Fwd: [xref.el] Add `xref-find-references` to `xref-prompt-for-identifier` Ray
2017-12-09 15:25 ` Dmitry Gutov
2017-12-09 17:52 ` Ray [this message]
2017-12-10 16:57 ` Dmitry Gutov
2017-12-11 7:18 ` Fangrui Song
2017-12-11 10:38 ` Dmitry Gutov
2018-01-21 22:20 ` guillaume papin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN30aBHFu3fyC9vtj2J177ijWFVmo0skWGw5E1sbPwPhfrd2Lg@mail.gmail.com \
--to=emacsray@gmail.com \
--cc=29619@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).