unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ship Mints <shipmints@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 74087@debbugs.gnu.org
Subject: bug#74087: Bug patch: invoke tab-bar-tab-post-open-functions during tabs initialization
Date: Tue, 29 Oct 2024 14:19:17 -0400	[thread overview]
Message-ID: <CAN+1HbrKz4qdxUXyrj3OB_G9Mu-8XSxpQdg-qbyQsRQS_ysZWw@mail.gmail.com> (raw)
In-Reply-To: <86a5em4w18.fsf@mail.linkov.net>

[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]

I'm trying to align all tab creation behavior with
tab-bar-tab-post-open-functions. Even the first tab should be considered
"opened" by the system and call people's functions on the hook. That tab,
if you close it, does call the close hooks correctly and that's aligned, at
least. If the open hook doesn't get called, then those tabs have to be
treated in a special way and that creates bugs and burden. Not sure how
relevant it is what I do in my custom hook that should get called for the
implied opened first frames but doesn't.

On Tue, Oct 29, 2024 at 2:15 PM Juri Linkov <juri@linkov.net> wrote:

> > tab-bar-tab-post-open-functions need to be called during tab-bar
> > initialization. Currently, a user's custom post-open functions are
> invoked
> > only for tabs created beyond the initial tab. This is a bug, in my view.
>
> Please explain what are you trying to achieve?
>
> 'tab-bar-tab-post-open-functions' is intended to be run in a new tab
> explicitly created by the user via 'tab-bar-new-tab-to'.
>
> OTOH, 'tab-bar-tabs' is a function that returns a list of existing tabs.
>

[-- Attachment #2: Type: text/html, Size: 1539 bytes --]

  reply	other threads:[~2024-10-29 18:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 14:12 bug#74087: Bug patch: invoke tab-bar-tab-post-open-functions during tabs initialization Ship Mints
2024-10-29 18:13 ` Juri Linkov
2024-10-29 18:19   ` Ship Mints [this message]
2024-10-29 18:29     ` Ship Mints
2024-10-29 18:43       ` Ship Mints
2024-10-29 18:52       ` Juri Linkov
2024-10-29 19:03         ` Ship Mints
2024-10-29 19:07           ` Juri Linkov
2024-10-29 19:18             ` Ship Mints
2024-10-29 19:23               ` Ship Mints
2024-10-29 19:32                 ` Ship Mints
2024-10-29 19:46                   ` Juri Linkov
2024-10-29 20:04                     ` Ship Mints
2024-10-29 20:05                       ` Ship Mints
2024-10-30  7:24                         ` Juri Linkov
2024-10-30 12:41                           ` Ship Mints
2024-10-30 18:32                             ` Juri Linkov
2024-10-30 18:38                               ` Ship Mints
2024-10-30 19:02                                 ` Eli Zaretskii
2024-10-30 19:29                                   ` Juri Linkov
2024-10-30 13:44         ` Ship Mints
2024-10-30 18:30           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN+1HbrKz4qdxUXyrj3OB_G9Mu-8XSxpQdg-qbyQsRQS_ysZWw@mail.gmail.com \
    --to=shipmints@gmail.com \
    --cc=74087@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).