unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ship Mints <shipmints@gmail.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: Daniel Mendler <mail@daniel-mendler.de>, 74604@debbugs.gnu.org
Subject: bug#74604: 30.0.92; FR: M-x package-upgrade - offer an option to show a diff on upgrade
Date: Mon, 2 Dec 2024 07:04:24 -0500	[thread overview]
Message-ID: <CAN+1HbqOavhsd3xtN4XN6LyPyW5k=fvP0TE0pNGG9viW289hJQ@mail.gmail.com> (raw)
In-Reply-To: <87r06qqx3z.fsf@posteo.net>

[-- Attachment #1: Type: text/plain, Size: 2405 bytes --]

Isn't it the case that describe-package works only on installed packages,
not prospectively installed packages? To help determine the value/risk of a
package install or update, I'd think it better to show this in advance.
Daniel's diff suggestion is similar but more technical.

On Mon, Dec 2, 2024 at 3:59 AM Philip Kaludercic <philipk@posteo.net> wrote:

> Ship Mints <shipmints@gmail.com> writes:
>
> > I like this idea, too. I spend a reasonable amount of time trying to
> > understand what people have changed and if it will affect me negatively
> > (the defensive part) or positively (for new features, user options,
> > deprecations). Showing a source-code diff may be a bit technical for some
> > users, though. I wonder if there could be either a link to a changelog,
> or
> > a way to encourage a changelog convention so one could be displayed for
> > users prior to a decision to update a package.
>
> Note that packages can distribute this information.  Currently, if a
> tarball includes a "news" file, it will be displayed by
> `describe-package.  IIRC no package archive generates these right now.
> But if we implement a user option like that described above (or below?),
> then we can add that as an option as well.
>
> The main issue is that not all package maintainers ensure that there are
> changelog/news sources that ELPA could use to provide this information.
>
> > -Stephane
> >
> > On Sun, Dec 1, 2024 at 5:06 PM Philip Kaludercic <philipk@posteo.net>
> wrote:
> >
> >> Daniel Mendler <mail@daniel-mendler.de> writes:
> >>
> >> > This is a feature request for the security wishlist. When upgrading
> >> > package it would be good to show a diff between the new and old
> package
> >> > files. Such an option could help performing review casually as part of
> >> > the upgrade process and may improve the security of the package
> >> > archives. More eyes would look at new package versions. This would
> make
> >> > it harder to inject malicious code either via the source repository or
> >> > via attacks on the package archives.
> >>
> >> That sounds like a good option to have!  I'll look into adding something
> >> like this via a user option that adjusts how to confirm a package
> upgrade.
> >>
> >> Note that package-vc has something similar with the
> >> `package-vc-log-incoming' command.
> >>
> >>
> >>
> >>
>

[-- Attachment #2: Type: text/html, Size: 3201 bytes --]

  reply	other threads:[~2024-12-02 12:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-29 15:39 bug#74604: 30.0.92; FR: M-x package-upgrade - offer an option to show a diff on upgrade Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-01 22:05 ` Philip Kaludercic
2024-12-01 22:47   ` Ship Mints
2024-12-02  8:59     ` Philip Kaludercic
2024-12-02 12:04       ` Ship Mints [this message]
2024-12-02 12:18         ` Philip Kaludercic
2024-12-02 12:25         ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-01 23:12   ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN+1HbqOavhsd3xtN4XN6LyPyW5k=fvP0TE0pNGG9viW289hJQ@mail.gmail.com' \
    --to=shipmints@gmail.com \
    --cc=74604@debbugs.gnu.org \
    --cc=mail@daniel-mendler.de \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).