* bug#72264: Default project-mode-line-format missing a quote (Emacs 30 prep)
@ 2024-07-24 0:44 Ship Mints
2024-07-24 10:39 ` Philip Kaludercic
0 siblings, 1 reply; 4+ messages in thread
From: Ship Mints @ 2024-07-24 0:44 UTC (permalink / raw)
To: 72264
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
In progmodes/project.el, I believe the face reference, below, needs a quote.
(defun project-mode-line-format ()
"Compose the project mode-line."
...
(propertize
(project-name project)
'face project-mode-line-face
* 'face 'project-mode-line-face ; should be quoted?*
...
'local-map project-mode-line-map)))))
I hope I got that right. I've been using a custom project-mode-line-format
and custom project-mode-line-face which is how I noticed this.
Stephane
[-- Attachment #2: Type: text/html, Size: 1008 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#72264: Default project-mode-line-format missing a quote (Emacs 30 prep)
2024-07-24 0:44 bug#72264: Default project-mode-line-format missing a quote (Emacs 30 prep) Ship Mints
@ 2024-07-24 10:39 ` Philip Kaludercic
2024-07-24 11:59 ` Ship Mints
0 siblings, 1 reply; 4+ messages in thread
From: Philip Kaludercic @ 2024-07-24 10:39 UTC (permalink / raw)
To: Ship Mints; +Cc: 72264
Ship Mints <shipmints@gmail.com> writes:
> In progmodes/project.el, I believe the face reference, below, needs a quote.
>
> (defun project-mode-line-format ()
> "Compose the project mode-line."
> ...
> (propertize
> (project-name project)
> 'face project-mode-line-face
> * 'face 'project-mode-line-face ; should be quoted?*
project-mode-line-face is a variable that may contain a face, but the
symbol itself doesn't designate a face. Just check the definition a few
lines above.
> ...
> 'local-map project-mode-line-map)))))
>
> I hope I got that right. I've been using a custom project-mode-line-format
> and custom project-mode-line-face which is how I noticed this.
How did you define your custom `project-mode-line-face'?
> Stephane
--
Philip Kaludercic on peregrine
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#72264: Default project-mode-line-format missing a quote (Emacs 30 prep)
2024-07-24 10:39 ` Philip Kaludercic
@ 2024-07-24 11:59 ` Ship Mints
2024-07-24 12:31 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Ship Mints @ 2024-07-24 11:59 UTC (permalink / raw)
To: Philip Kaludercic; +Cc: 72264
[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]
Gotcha. I didn't realize the indirection. Changed my definition and it
works. Thank you for looking at this. I know these kinds of reports seem
like noise. Please close.
-s
On Wed, Jul 24, 2024 at 6:39 AM Philip Kaludercic <philipk@posteo.net>
wrote:
> Ship Mints <shipmints@gmail.com> writes:
>
> > In progmodes/project.el, I believe the face reference, below, needs a
> quote.
> >
> > (defun project-mode-line-format ()
> > "Compose the project mode-line."
> > ...
> > (propertize
> > (project-name project)
> > 'face project-mode-line-face
> > * 'face 'project-mode-line-face ; should be quoted?*
>
> project-mode-line-face is a variable that may contain a face, but the
> symbol itself doesn't designate a face. Just check the definition a few
> lines above.
>
> > ...
> > 'local-map project-mode-line-map)))))
> >
> > I hope I got that right. I've been using a custom
> project-mode-line-format
> > and custom project-mode-line-face which is how I noticed this.
>
> How did you define your custom `project-mode-line-face'?
>
> > Stephane
>
> --
> Philip Kaludercic on peregrine
>
[-- Attachment #2: Type: text/html, Size: 1873 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#72264: Default project-mode-line-format missing a quote (Emacs 30 prep)
2024-07-24 11:59 ` Ship Mints
@ 2024-07-24 12:31 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2024-07-24 12:31 UTC (permalink / raw)
To: Ship Mints; +Cc: philipk, 72264-done
> Cc: 72264@debbugs.gnu.org
> From: Ship Mints <shipmints@gmail.com>
> Date: Wed, 24 Jul 2024 07:59:28 -0400
>
> Gotcha. I didn't realize the indirection. Changed my definition and it works. Thank you for looking at this. I
> know these kinds of reports seem like noise. Please close.
Done.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-24 12:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-24 0:44 bug#72264: Default project-mode-line-format missing a quote (Emacs 30 prep) Ship Mints
2024-07-24 10:39 ` Philip Kaludercic
2024-07-24 11:59 ` Ship Mints
2024-07-24 12:31 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).