From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ship Mints Newsgroups: gmane.emacs.bugs Subject: bug#74750: clone-frame and make-frame pixelwise issues Date: Mon, 16 Dec 2024 11:02:31 -0500 Message-ID: References: <861pyfd8pe.fsf@gnu.org> <4d057282-8ec2-4ddb-ac0f-23e65af6e5a1@gmx.at> <7404039b-e71e-44e5-a446-70fa07889528@gmx.at> <1ed054fc-4b82-47cf-8d89-4768b56b88a7@gmx.at> <544d13ee-54f0-4786-8c5b-b1c87570f36c@gmx.at> <391ac457-09d0-4541-bc65-cddde4d23929@gmx.at> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a405f806296551c7" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10321"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 74750@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 16 17:05:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNDax-0002TJ-MF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Dec 2024 17:05:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNDak-0003DX-Db; Mon, 16 Dec 2024 11:05:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNDah-0003Ao-BV for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 11:05:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNDah-0005r0-1b for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 11:05:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=1Y4Vpx91wAdEB5uAj2f0s0pJzX7ONs3e1FPtAlz/aOA=; b=rlYpYCXmEaSBJEfZE3XRwk4YoygpaYlDURithBtWdN6BSJZ8+DOT0QnGtYZyJPbQsfpvvLNcaECD9BFMNh2W5YQ9n7PFoV1mQRhyx5jvKwwgFxTS/EkrMeSfOIizzgREOFpE484T/y6pu1joOG1eNNA0MJgb+l+lPgEVEHXxDmh3x2oE66+SnJZmGvqqAEghQQ26FhDiUD6vUUjbQDxm+SeoH6hUNf61u8uxNJWof2dUlkixMrB08EPjB8w0kPTHqCJX97BlCrTHV0SMNTgeoyKJg5SAJmydrLQYb0YwsauVY9+lWLTMX+UO25k0wunrd/ua5Jn0mRod7iOLkyvmUw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNDag-0001Uj-EJ for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 11:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ship Mints Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Dec 2024 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74750 X-GNU-PR-Package: emacs Original-Received: via spool by 74750-submit@debbugs.gnu.org id=B74750.17343650615642 (code B ref 74750); Mon, 16 Dec 2024 16:05:02 +0000 Original-Received: (at 74750) by debbugs.gnu.org; 16 Dec 2024 16:04:21 +0000 Original-Received: from localhost ([127.0.0.1]:55672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNDa0-0001Sw-Vj for submit@debbugs.gnu.org; Mon, 16 Dec 2024 11:04:21 -0500 Original-Received: from mail-vs1-f51.google.com ([209.85.217.51]:44318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNDZz-0001So-2c for 74750@debbugs.gnu.org; Mon, 16 Dec 2024 11:04:19 -0500 Original-Received: by mail-vs1-f51.google.com with SMTP id ada2fe7eead31-4afdd15db60so1074421137.1 for <74750@debbugs.gnu.org>; Mon, 16 Dec 2024 08:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734364998; x=1734969798; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1Y4Vpx91wAdEB5uAj2f0s0pJzX7ONs3e1FPtAlz/aOA=; b=HgdR6Q5SHQYQ/mWXhQ2gIM+q8k3OeXhnDLGcFPZB29PIeBIsJHFeilLyEwQwh1RjpL n6C+jnrKsvUjrxeSNrIYnYJcUOoOYsHffVUFw+A1O9tK5LNOw46IiUWY8IjyVApwofpV aW16r38nJKIN+JvV7jTfFdBs+dyhXwkcJswrQqjPgFW2vdq0AgiMrvjyEHXmGlVYG6zm /h3WIUF5IAnzaPidtJ1JTjqsvOKssMshqeeobkSF4KGqsHWI99gtXDtlTEwGdbIyw744 ImnqQvYGzHVG77GVxvw57KqEoSxQ55Gj/qflzDmzr5w0HFBopUOas3NB597ZEMU/+GNC FRdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734364998; x=1734969798; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1Y4Vpx91wAdEB5uAj2f0s0pJzX7ONs3e1FPtAlz/aOA=; b=ARZqG+x0X689NxMlRizu0LzvLHp1KKH0yDKFInglHTW5st8RNrHzis8rhtwEnxAOrN TitKBKNibqtN8NAEEakoJScZ7Nmg6okX0Ol3G52441OJxkB9OkjY3Kzx1UY4Y3qQmkOA 8TV43MqOR/dQZwm5I85WBwg/AV0iql4ehlkQM5QrUouGnnqrgF9sYpLJT6Lx2m4/WLmE zSjYzP78wAthZU2uKgjT+rIl+tp30kXBvpvgwz69sT2UPGtCz8uE5yPkdAvThqCRpiwa vB+94HF2oxUv0yn3bv7kA/GwqfqNYBz7mjEpKY/A0psUwRg4rdccsic3PKtryzJv04hV 3LCA== X-Forwarded-Encrypted: i=1; AJvYcCVF65WIlQBTIKVYbkWRN1WpHlYd2i3GCzW2WAyDtrKs6spxGnI1rHxl7yqk98GbTMgBrttjTw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwMwDBM0sMUw0AVA5MIsElRIi83Lape/GPnnPZOVqt9f8HnHXdy oW9dGIyMuokIqe8HZ75+kkZGZLjJsUWWdy/WwUkVB2nzByrH8wsDkjhdJaakPsJMJKPCPVe8apR +X5oUquYEm0iKlymLnSRI+G7toqE= X-Gm-Gg: ASbGncuMl9rJzjunUvSCVRd0Vv7xcliv1mF3C1T0vgxPpgYwPHfbLo71aKuhmi4kP4A H05e7gd+9Vp67kpsuKslxS+P5lds/I3ik4/TlNA== X-Google-Smtp-Source: AGHT+IExRkwAih6PC0XxmiHUe73VuQ0IXCz5LlDoTe3ERMv1FEMKXalPgyJToFVyTTbh8IjQ/7IoVlRpIx+FIzyzMzk= X-Received: by 2002:a05:6122:4598:b0:515:d2d1:7c0d with SMTP id 71dfb90a1353d-51a242a91d7mr512953e0c.5.1734364998401; Mon, 16 Dec 2024 08:03:18 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297180 Archived-At: --000000000000a405f806296551c7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Aha, you beat me to it. On Mon, Dec 16, 2024 at 11:01=E2=80=AFAM Ship Mints w= rote: > Martin, I'm assuming you'll do the patch against frame.h and frame.c? > > On Mon, Dec 16, 2024 at 10:55=E2=80=AFAM Ship Mints = wrote: > >> Yes, paperwork on file. I will submit a patch to the latest master now >> that we're agreed. Thank you for your help with these changes. >> >> On Mon, Dec 16, 2024 at 10:49=E2=80=AFAM martin rudalics wrote: >> >>> > With your suggested wording changes but without the pixelwise >>> argument: >>> ... >>> > (new-frame)) >>> >>> Please omit the parentheses here. >>> ... >>> > (unless (display-graphic-p frame) >>> >>> This is a fix you should mention in the commit message. >>> ... >>> >>> Please provide a diff to the current frame.el of master and a commit >>> message. Have you done your Emacs paperwork already? If not, I can >>> install this as a tiny change because it's short enough. Still you >>> should start the paperwork since otherwise we cannot install further >>> changes from you. >>> >>> Thanks, martin >>> >> --000000000000a405f806296551c7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Aha, you beat me to it.

On Mon, Dec 16, 2024 = at 11:01=E2=80=AFAM Ship Mints <s= hipmints@gmail.com> wrote:
Martin, I'm assuming you'll do the patch again= st frame.h and frame.c?

On Mon, Dec 16, 2024 at 10:55=E2=80=AFAM Ship= Mints <shipmin= ts@gmail.com> wrote:
Yes, paperwork on file. I will submit a patch to the latest = master now that we're agreed. Thank you for your help with these change= s.

On Mon, Dec 16, 2024 at 10:49=E2=80=AFAM martin rudalics <rudalics@gmx.at> wrot= e:
=C2=A0> Wi= th your suggested wording changes but without the pixelwise argument:
...
=C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(new-frame))

Please omit the parentheses here.
...
=C2=A0>=C2=A0 =C2=A0 =C2=A0 (unless (display-graphic-p frame)

This is a fix you should mention in the commit message.
...

Please provide a diff to the current frame.el of master and a commit
message.=C2=A0 Have you done your Emacs paperwork already?=C2=A0 If not, I = can
install this as a tiny change because it's short enough.=C2=A0 Still yo= u
should start the paperwork since otherwise we cannot install further
changes from you.

Thanks, martin
--000000000000a405f806296551c7--