From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ship Mints Newsgroups: gmane.emacs.bugs Subject: bug#74750: clone-frame and make-frame pixelwise issues Date: Mon, 16 Dec 2024 11:01:43 -0500 Message-ID: References: <861pyfd8pe.fsf@gnu.org> <4d057282-8ec2-4ddb-ac0f-23e65af6e5a1@gmx.at> <7404039b-e71e-44e5-a446-70fa07889528@gmx.at> <1ed054fc-4b82-47cf-8d89-4768b56b88a7@gmx.at> <544d13ee-54f0-4786-8c5b-b1c87570f36c@gmx.at> <391ac457-09d0-4541-bc65-cddde4d23929@gmx.at> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c2c7c80629654e77" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5217"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 74750@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 16 17:04:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNDZu-0001Av-3H for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Dec 2024 17:04:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNDZk-0002a8-6I; Mon, 16 Dec 2024 11:04:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNDZj-0002Zj-3q for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 11:04:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNDZi-0005lu-Rd for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 11:04:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=BO0Wyxe/Ws+NQENJDcGrjAJmrsNL0to3CVAF0eR/3yQ=; b=e5Ekjy2skcVf0i9MU3V7PTMjyoriHlpL21Qoi55hlVFHwA/Cpk536PrD2qRYKig/59Bwp9wpHwPnAI215z12zdIDRGcuScKyb7co8SKnnkaflFHHsx4HXo9jTdScWiJnRqQhkZARx2BBEZ+IlEIBZKETHt4NYvlKy5HswKfcnD7xAwO4NXIc7CAkv1fMfVAoP28bb9va9FSvcklvwYxmDWk7oZBD2GW35A7/ZK69QUn+9Ria5UecciI4EIy2AfMU/ImyVmpzhdn+bK66cw7ls+UwatF/QEplF0CQFghXbHUVZLYcetr5Z6yp8gLUyAUKmwSdT8pBjMlKDLLduTZRtw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNDZi-0001S1-9R for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 11:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ship Mints Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Dec 2024 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74750 X-GNU-PR-Package: emacs Original-Received: via spool by 74750-submit@debbugs.gnu.org id=B74750.17343650165513 (code B ref 74750); Mon, 16 Dec 2024 16:04:02 +0000 Original-Received: (at 74750) by debbugs.gnu.org; 16 Dec 2024 16:03:36 +0000 Original-Received: from localhost ([127.0.0.1]:55668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNDZH-0001Qr-G6 for submit@debbugs.gnu.org; Mon, 16 Dec 2024 11:03:35 -0500 Original-Received: from mail-qv1-f43.google.com ([209.85.219.43]:55436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNDZE-0001Qe-96 for 74750@debbugs.gnu.org; Mon, 16 Dec 2024 11:03:33 -0500 Original-Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6d8fa32d3d6so58499626d6.2 for <74750@debbugs.gnu.org>; Mon, 16 Dec 2024 08:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734364952; x=1734969752; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BO0Wyxe/Ws+NQENJDcGrjAJmrsNL0to3CVAF0eR/3yQ=; b=AtfYOQunHBOZ2cG/VW7txouP4VDorSjwL80gGLc6X3ghsHsgyH7wDO5pS/nvMU2Bzz Dgf27BsrbllPrWcjm3H3rTjIKuo/vFEJ7etRtBpqfRaXl6CyXs3IgqGSs7Qr93CBbikD RzRKUzkqNXVf4fXZ0ea5pP2UW0HUIi3PlwAihlYDRRU8roNV+LLEnTq04eruNH9B2oeT ppxG5EePDX3vxecOdu2uD5trMhlwA/Jfoj8N/v4ZqnhtLMEgZU02aw/X6nj7aSF/oL1b LOWgsdjKBfN1Rr+aSzNFV7rk8QcJI8nREhQmMt7aKqzQWxet4+DEF1O8WrfbBtYe7rOs +6MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734364952; x=1734969752; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BO0Wyxe/Ws+NQENJDcGrjAJmrsNL0to3CVAF0eR/3yQ=; b=FSX3y+Yx2juqAdvc3PYbb+YFUwWwWMiFbJ7GN/QCivQz/CQz7i7ViLB/7AjTqulXih 8e8HcFB+FPiSn8I09ry8+wpgQa0GvVxZnilVggBFJMM1RojnJcihRdA7C2QQz72/aXnM C8+0Uex9KFJr1ePW39jvkExG+UCLSfRMaIaC4LYwH68e9v+k5FytsXvMwrEH+1K1hWrC fwunIU8gYHpm0Chjx4hpsC9ix4f+xPQ3WKHUieI9+7Aabe/mDJbDBkJt5qS0qQuImj1a ie0GXk1SRMNb8HJDsXd1DRrlbnqWe3lG+8DxiNO6/w0gBLkBRIoXspXPtjB53l8b7p3m DPUg== X-Forwarded-Encrypted: i=1; AJvYcCXOQBJO6hcQ2bE+uaP42EPq8zvUR6p3GQqg5PKwWdxPDEeNzcRK+LRl234J/VVvHRa0xoi4vg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzBrZO0gZ/bfIrQF4n1U7qGRkur8z+iFmzbGt0sAkCPVqCordId 2D3czaVyw2Z407DHVM5YaBcRiMWtWatkGqfCc5vekQ1tbPDMQNgvipSB6YTRY2bRrpxY0/8b/Ww u3pGXeEfdP7ahSpYDAFpBbDE5aDU= X-Gm-Gg: ASbGncuFfocy/w1MTfuUwXTMhOxiZEcnFSWb1hckgQ/QIZ1WJC+VQeQshjKEiM+ubWd ZZjyU6Z+93cie4qhxEY5bSc7N7P4nXBw/lMB0gQ== X-Google-Smtp-Source: AGHT+IGMXncrmjgPtNieNZNybV78GvSS9xRogvJR/ro463GWVx8AGaugbmh95GdgGOBkXehlUTAXpMORwA0/V1bQCqM= X-Received: by 2002:a05:6214:258d:b0:6d4:142d:8119 with SMTP id 6a1803df08f44-6dc9684c7abmr199051376d6.42.1734364950086; Mon, 16 Dec 2024 08:02:30 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297179 Archived-At: --000000000000c2c7c80629654e77 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Martin, I'm assuming you'll do the patch against frame.h and frame.c? On Mon, Dec 16, 2024 at 10:55=E2=80=AFAM Ship Mints w= rote: > Yes, paperwork on file. I will submit a patch to the latest master now > that we're agreed. Thank you for your help with these changes. > > On Mon, Dec 16, 2024 at 10:49=E2=80=AFAM martin rudalics wrote: > >> > With your suggested wording changes but without the pixelwise argumen= t: >> ... >> > (new-frame)) >> >> Please omit the parentheses here. >> ... >> > (unless (display-graphic-p frame) >> >> This is a fix you should mention in the commit message. >> ... >> >> Please provide a diff to the current frame.el of master and a commit >> message. Have you done your Emacs paperwork already? If not, I can >> install this as a tiny change because it's short enough. Still you >> should start the paperwork since otherwise we cannot install further >> changes from you. >> >> Thanks, martin >> > --000000000000c2c7c80629654e77 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Martin, I'm assuming you'll do the patch against frame.h and fra= me.c?

On Mon, Dec 16, 2024 at 10:55=E2=80=AFAM S= hip Mints <shipmints@gmail.com> wrote:
= Yes, paperwork on file. I will submit a patch to the latest master now that= we're agreed. Thank you for your help with these changes.
<= br>
On Mon,= Dec 16, 2024 at 10:49=E2=80=AFAM martin rudalics <rudalics@gmx.at> wrote:
=C2=A0> With your suggest= ed wording changes but without the pixelwise argument:
...
=C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(new-frame))

Please omit the parentheses here.
...
=C2=A0>=C2=A0 =C2=A0 =C2=A0 (unless (display-graphic-p frame)

This is a fix you should mention in the commit message.
...

Please provide a diff to the current frame.el of master and a commit
message.=C2=A0 Have you done your Emacs paperwork already?=C2=A0 If not, I = can
install this as a tiny change because it's short enough.=C2=A0 Still yo= u
should start the paperwork since otherwise we cannot install further
changes from you.

Thanks, martin
--000000000000c2c7c80629654e77--