From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Warren Lynn Newsgroups: gmane.emacs.bugs Subject: bug#21562: Fwd: bug#21562: 24.5; Copy dir via Tramp pscp does not work Date: Mon, 12 Oct 2015 11:54:36 -0400 Message-ID: References: <878u7tk0bm.fsf@gmx.de> <87mvw1rw1y.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c032e4c9bc3fb0521ea58c3 X-Trace: ger.gmane.org 1444665428 31105 80.91.229.3 (12 Oct 2015 15:57:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 12 Oct 2015 15:57:08 +0000 (UTC) Cc: 21562@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 12 17:57:00 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZlfT9-0007EF-4a for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Oct 2015 17:56:59 +0200 Original-Received: from localhost ([::1]:56302 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlfT8-0006BX-Ot for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Oct 2015 11:56:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlfRN-0003RE-N7 for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2015 11:55:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlfRH-0000v5-Fr for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2015 11:55:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlfRH-0000ux-2g for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2015 11:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZlfRG-0006NO-Jw for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2015 11:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Warren Lynn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Oct 2015 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 21562-submit@debbugs.gnu.org id=B21562.144466528124477 (code B ref 21562); Mon, 12 Oct 2015 15:55:02 +0000 Original-Received: (at 21562) by debbugs.gnu.org; 12 Oct 2015 15:54:41 +0000 Original-Received: from localhost ([127.0.0.1]:37244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZlfQu-0006Mi-AI for submit@debbugs.gnu.org; Mon, 12 Oct 2015 11:54:41 -0400 Original-Received: from mail-yk0-f181.google.com ([209.85.160.181]:36585) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZlfQr-0006MZ-P6 for 21562@debbugs.gnu.org; Mon, 12 Oct 2015 11:54:38 -0400 Original-Received: by ykey125 with SMTP id y125so16126896yke.3 for <21562@debbugs.gnu.org>; Mon, 12 Oct 2015 08:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=b5rLfQs15sfkX9Fjy4VyjhyhPleYm9PX47N5QGvPNeY=; b=jBBT+FmAGwtPS5nX298zaxqs15DDq4gljVbbTeywDMo9wplyCsMcYkU0eWK74VA+aZ N5AH3oXNCFHxidQquK7CozGCLwwGqrjDUdeyetWu7G4zFN81mp/Hyjnua27dS7AD07YV tLOuEVqcOrl30OyJC+LqM/yRyBGdhZau8LKV9nKHzCpX7b5nzWGnaOZmv4iCpV5ELn0M 7BL6o4WOsN5bPLzRv/fRYSOudbQ6YgBj+FPBkxvBKIaP5TnZgu5K9NmWxTR/oQEHqD03 SILwL3Kq47tEeEAtaAy9JHjyyyc7Ipn/5/cxUangA8YFXrengF9RcFVbJ08Fmo6vd5pI HCOQ== X-Received: by 10.129.128.195 with SMTP id q186mr20544268ywf.90.1444665276217; Mon, 12 Oct 2015 08:54:36 -0700 (PDT) Original-Received: by 10.37.228.65 with HTTP; Mon, 12 Oct 2015 08:54:36 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107542 Archived-At: --94eb2c032e4c9bc3fb0521ea58c3 Content-Type: text/plain; charset=UTF-8 Hi Michael: Here is I am resending the message you missed. Thanks. Wanrong ---------- Forwarded message ---------- From: Warren Lynn Date: Tue, Oct 6, 2015 at 11:57 AM Subject: Re: bug#21562: 24.5; Copy dir via Tramp pscp does not work To: Michael Albinus Hi Michael: Thanks a lot for testing it out. On my Windows setup, I don't have the "test" directory under my Emacs installation directory (which is simply an unzipped directory from the official download). Where do I get it? On the other hand, my test case is really simple. I don't have any fancy path names (no special chars and etc). Just something like this: source: /pscp:root@10.81.100.225:/mnt/Data_drive/wlin/ttt destination: c:\wlin\ Or reverse source/destination. On Windows testing. One of the great things about Emacs is its versatility. It works on Windows and Linux, with either text termimal or GUI. Over the years, I have been bouncing between Linux and Windows (Windows is my main platform for the moment) and I feel I made a good and smart investment on Emacs. I hope the Emacs team does not treat Windows as the second priority and hence slowly lose one of its great strengths. Of course as you said, this all depends on the participation of the community. If you need some testing help on Windows, and it does not takes a lot of time (assuming most of it is automated), I can volunteer. On Fri, Oct 2, 2015 at 1:59 PM, Michael Albinus wrote: > Warren Lynn writes: > > Hi Warren, > > > Actually, things were more broken than I thought. The original code > > did not handle correctly directory copy from local to remote either. > > The reason is function > > tramp-make-copy-program-file-name > > already quotes the target, and then shell-quote-argument quotes the > > target again, so we get double quotes. > > > > I attached a second patch to fix both copying dir from local to > > remote, or remote to local. However, I am not so sure if this is a > > completely correct fix as I don't know much about the "multi-hop" > > thing. Anyway, hope this can serve as a starting point for the > > ultimate proper fix. > > Thanks for your investigations. > > I've applied your patch to recent Tramp sources, and the Tramp test > suite still passes all expected tests. That's good, but it's with a > local Ubuntu stanza. > > Since I don't use MS Windows, I cannot check it for your case. Could > you, please run the test suite, preferred with and without your > patch. You could do this like this (untested): > > set REMOTE_TEMPORARY_FILE_DIRECTORY=/pscp:user@host:/tmp > > "C:\Program Files\emacs-24.5\bin\emacs.exe" -Q -batch -l "C:\Program > Files\emacs-24.5\test\automated\tramp-tests.el" -f > ert-run-tests-batch-and-exit > > Of course, you must adapt some paths in this example. > > Since nobody has reported such a problem yet, I suspect that your use > case is not covered yet by the Tramp tests. Could you please describe > exactly, what and how you have tried to copy, especially source and > target paths? I would like to get this problem reproducible. Well, for > this I need to hijack the laptop of my wife :-) > > > BTW, all the above works out of box on Emacs 23.3. > > > > To be honest, I am quite disappointed with Emacs recent (last 2 or 3 > > years) release quality. Seems some convoluted low-quality code was > > checked in the first place, and then not enough testing was done > > before release. Don't know if I have any right to complain in the > > first place as I am not an active developer here. But I would hate to > > see my favorite editor Emacs going down this path further. > > I cannot speak for Emacs in general. But none of the Tramp contributors > uses MS Windows locally, as far as I am aware of. If there won't be any > volunteer for testing this, we cannot expect a better quality. > > Additionally, the Tramp tests on MS Windows require special settings > (see %REMOTE_TEMPORARY_FILE_DIRECTORY% I've shown above). I have no idea > how we could establish a mockup Tramp connection method for testing, as > we have done it for local unixoid systems. > > Best regards, Michael. > > PS: Starting on Monday, I'll be offline for about a week. > --94eb2c032e4c9bc3fb0521ea58c3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Michael:

Here is I am resending = the message you missed. Thanks.

Wanrong

=
---------- Forwarded message ----------
From:= Warren Lynn <wrn.lynn@gmail.com>
Date: = Tue, Oct 6, 2015 at 11:57 AM
Subject: Re: bug#21562: 24.5; Copy dir via = Tramp pscp does not work
To: Michael Albinus <michael.albinus@gmx.de>


Hi Michael:
=C2=A0
Thanks a lot for testing it = out. On my Windows setup, I don't have the "test" directory u= nder my Emacs installation directory (which is simply an unzipped directory= from the official download). Where do I get it?
=C2=A0
On the other hand, my test case is really simple. I don't have any fan= cy path names (no special chars and etc). Just something like this:
source:
/pscp:root@10.81.100.225:/mnt/Data_drive/wlin/ttt
destination:
c:\wlin\
=C2=A0
Or reverse= source/destination.
=C2=A0
On Windows testing. One of= =C2=A0the great things about=C2=A0Emacs is its versatility. It works on Win= dows and Linux, with either text termimal or GUI. Over the years, I have be= en bouncing between Linux and Windows (Windows is my main platform for the = moment) and I feel I made a good and smart investment on Emacs. I hope the = Emacs team=C2=A0does not=C2=A0treat Windows as the second priority and henc= e slowly lose one of its great strengths. Of course as you said, this all d= epends on the participation of the community. If you need some testing help= on Windows, and it does not takes a lot of time (assuming most of it is au= tomated), I can volunteer.
=C2=A0

On Fri, Oct 2, 2015 at 1:59 PM, Michael Albinus <michael.albinus@g= mx.de> wrote:
Warren Lynn &= lt;wrn.lynn@gmail.c= om> writes:

Hi Warren,

> Actually, things were more broken than I thought. The original code > did not handle correctly directory copy from local to remote either. > The reason is function
> tramp-make-copy-program-file-name
> already quotes the target, and then shell-quote-argument quotes the > target again, so we get double quotes.
>
> I attached a second patch to fix both copying dir from local to
> remote, or remote to local. However, I am not so sure if this is a
> completely correct fix as I don't know much about the "multi-= hop"
> thing. Anyway, hope this can serve as a starting point for the
> ultimate proper fix.

Thanks for your investigations.

I've applied your patch to recent Tramp sources, and the Tramp test
suite still passes all expected tests. That's good, but it's with a=
local Ubuntu stanza.

Since I don't use MS Windows, I cannot check it for your case. Could you, please run the test suite, preferred with and without your
patch. You could do this like this (untested):

set REMOTE_TEMPORARY_FILE_DIRECTORY=3D/pscp:user@host:/tmp

"C:\Program Files\emacs-24.5\bin\emacs.exe" -Q -batch -l "C:= \Program Files\emacs-24.5\test\automated\tramp-tests.el" -f ert-run-te= sts-batch-and-exit

Of course, you must adapt some paths in this example.

Since nobody has reported such a problem yet, I suspect that your use
case is not covered yet by the Tramp tests. Could you please describe
exactly, what and how you have tried to copy, especially source and
target paths? I would like to get this problem reproducible. Well, for
this I need to hijack the laptop of my wife :-)

> BTW, all the above works out of box on Emacs 23.3.
>
> To be honest, I am quite disappointed with Emacs recent (last 2 or 3 > years) release quality. Seems some convoluted low-quality code was
> checked in the first place, and then not enough testing was done
> before release. Don't know if I have any right to complain in the<= br> > first place as I am not an active developer here. But I would hate to<= br> > see my favorite editor Emacs going down this path further.

I cannot speak for Emacs in general. But none of the Tramp contribut= ors
uses MS Windows locally, as far as I am aware of. If there won't be any=
volunteer for testing this, we cannot expect a better quality.

Additionally, the Tramp tests on MS Windows require special settings
(see %REMOTE_TEMPORARY_FILE_DIRECTORY% I've shown above). I have no ide= a
how we could establish a mockup Tramp connection method for testing, as
we have done it for local unixoid systems.

Best regards, Michael.

PS: Starting on Monday, I'll be offline for about a week.


--94eb2c032e4c9bc3fb0521ea58c3--