From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: signal3 Newsgroups: gmane.emacs.bugs Subject: bug#56110: 27+; switching from line-mode to char-mode Date: Wed, 22 Jun 2022 22:23:49 +0000 Message-ID: References: <875ykvs9gq.fsf@electra.home.arpa> <87wndaw84w.fsf@web.de> <87sfnyw6m7.fsf@web.de> <877d58obnn.fsf@web.de> <87czf0qu3p.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6622"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen , 56110@debbugs.gnu.org, Stefan Monnier To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 23 00:25:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o48mh-0001Uq-RP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Jun 2022 00:25:15 +0200 Original-Received: from localhost ([::1]:53716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o48mg-0003Dp-BY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Jun 2022 18:25:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o48mU-0003Dh-8I for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2022 18:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o48mT-0001vL-Td for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2022 18:25:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o48mT-0002Vg-Qf for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2022 18:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: signal3 Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jun 2022 22:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56110 X-GNU-PR-Package: emacs Original-Received: via spool by 56110-submit@debbugs.gnu.org id=B56110.16559366519585 (code B ref 56110); Wed, 22 Jun 2022 22:25:01 +0000 Original-Received: (at 56110) by debbugs.gnu.org; 22 Jun 2022 22:24:11 +0000 Original-Received: from localhost ([127.0.0.1]:36809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o48le-0002UX-Vu for submit@debbugs.gnu.org; Wed, 22 Jun 2022 18:24:11 -0400 Original-Received: from mail-yw1-f181.google.com ([209.85.128.181]:36373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o48lZ-0002Tw-Ou for 56110@debbugs.gnu.org; Wed, 22 Jun 2022 18:24:09 -0400 Original-Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-3176d94c236so177292567b3.3 for <56110@debbugs.gnu.org>; Wed, 22 Jun 2022 15:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O7rd1hgU51w/WNmaEgWiBk3sXiFWd5/RwIBRTMJ4Q+8=; b=dhwdmk9s7MALTj9yTf08/cNVfRpa5Y5FihpLu5jMZAI6IX0WMW9eM/Rw5mrzsMd0mb oQF1dCM5PCwBzH/EvHh1F5r0OfRoz+JTFwS2K3paSX63cDKoMPl+aUsorsBW+RxGrRJw ohxQPVtszEd6cIHkjU35qBnr0/peZ26LT+xji7JMOrG29iXaAweX75xVO0DNCgvGIInX k4PbYjdJq4E0UXTKE/vLW9Gz2JDKg7alMLLNX1spEmIZqKNmu8GPifyKiRkj21C56vxb g5Xtxb+L+jT6aAm3tkplubfcJYk2dRHJRL+FZmi/axKdqiWrnVFmv9UN7X5ujTFFhqDs qmSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O7rd1hgU51w/WNmaEgWiBk3sXiFWd5/RwIBRTMJ4Q+8=; b=HLVcGd9Budb8OJZGTuXY+WY0uE2wH4ZpKcioUaZwmyWTWBHR+qRH5fqrSZ2sVDnOfY 4393COrx7TG/7HqVFMb4VMfI7x+77CClqUDUrfUhooO2SZVagjsneR0Cmrb7jAcJCA+z ZIo2Cs3ncePfsBP67KknM7oh+KS2pwHGTYUKmO54+xivvjdxZU/Dsl2Vd5aX4E5IK9Xm +iHReBFer/mmxz+MHU3F5tUlQEJOQHkuX6jSAV3Y0zUP39MxmYInUEAdYQ0kzzE2IhVg VH+y7GN2uMcKDuoBib1ZHkjCxIK8ke+meWGRxWOszC5oU9ZEJcz9qK48o7DPLWkXDGGI qW/A== X-Gm-Message-State: AJIora+5mlJZpnNcS3I7vWejwtDjPe+phKjdQfK7O5ZBDJb97lUK3lb8 Sieugdz/Eclod7CHUiHUvxxR3rXeRUe0ATAFdyQ= X-Google-Smtp-Source: AGRyM1ssJmY09M7pudZ2R2JSkiIUYmAmn4zYeOQPC3AeWAgFngVOCC4zeSi6PSlITOgQPyx8xI5KZZqr/lPP4/PrBng= X-Received: by 2002:a81:2442:0:b0:30f:9fc4:a488 with SMTP id k63-20020a812442000000b0030f9fc4a488mr6837601ywk.408.1655936640291; Wed, 22 Jun 2022 15:24:00 -0700 (PDT) In-Reply-To: <87czf0qu3p.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235055 Archived-At: On Wed, Jun 22, 2022 at 9:14 PM Basil L. Contovounesios wrote: > In any case, my vote is for correct and simpler code over a smaller > diff. Lol, correct is definitely better! Smaller diff might be considered if there's doubt regarding correctness. > > And in that vein, I'm not sure why the unwind-protect was removed. > > AFAICT it's redundant because let always unwinds its temporary bindings, > in contrast with the previous add-function and setq which make permanent > modifications that require manual unwinding. Ah... makes sense to me now, thanks for the clarification..