From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ren Victor Newsgroups: gmane.emacs.bugs Subject: bug#30823: 25.3; modification-hooks of overlays are not run in some cases Date: Thu, 15 Mar 2018 15:29:52 +0800 Message-ID: References: <83lgetri7r.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000002b8c6505676e75a6" X-Trace: blaine.gmane.org 1521098900 28650 195.159.176.226 (15 Mar 2018 07:28:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Mar 2018 07:28:20 +0000 (UTC) Cc: 30823@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 15 08:28:16 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewNJ9-0007F0-FT for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Mar 2018 08:28:15 +0100 Original-Received: from localhost ([::1]:50079 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewNL5-00041s-TP for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Mar 2018 03:30:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewNKy-0003xw-8y for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2018 03:30:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewNKv-0008JZ-3i for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2018 03:30:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54319) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewNKu-0008JJ-VF for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2018 03:30:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewNKt-0006LT-5d for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2018 03:30:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ren Victor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Mar 2018 07:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30823-submit@debbugs.gnu.org id=B30823.152109900124359 (code B ref 30823); Thu, 15 Mar 2018 07:30:03 +0000 Original-Received: (at 30823) by debbugs.gnu.org; 15 Mar 2018 07:30:01 +0000 Original-Received: from localhost ([127.0.0.1]:33983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewNKq-0006Ko-Pf for submit@debbugs.gnu.org; Thu, 15 Mar 2018 03:30:01 -0400 Original-Received: from mail-lf0-f49.google.com ([209.85.215.49]:41539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewNKp-0006KX-6b for 30823@debbugs.gnu.org; Thu, 15 Mar 2018 03:29:59 -0400 Original-Received: by mail-lf0-f49.google.com with SMTP id m69-v6so8581172lfe.8 for <30823@debbugs.gnu.org>; Thu, 15 Mar 2018 00:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=W+XyePt+Yjyq4rEDuZr3dzLYsDwjdJAsn4avtSxiKFc=; b=nfU7xdO+u6yGVGTPqeVDFXVxktmHZabonDxYEH1+1USzbzNCmxZFMikpcjrm0Z+WeN nwI/N5zYb6zftxFZnQ6hZFXJL+0HQyYp0IrwOzTNn7VZHKV0EMVZuZHQe7YQwWe+AtcL EbMgse0i62D3m2tM3eUlZEGt7TTJQiKpVTDxhT3TMMJBsIUy7FIHzbFIWwZOIsXiicEG iABoGcAglcBRdu1zYf30yngWRCVO3YTi3wROwkvBK5wRdKinvgebca6g4Zi5Lbs79EYz of43FQX71ebNnUmSgcDUrEBGWL/JRA6Zb6BkI0musZVbTPMmReJ3iP5I6tW84Jwym/mu 0z7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=W+XyePt+Yjyq4rEDuZr3dzLYsDwjdJAsn4avtSxiKFc=; b=c8zy61uC4AHLpt9Q8FPYpaJ6oSeSwll8a/oMI2rbNSVWI+sc7XeZBANr5EP7gEQs8C jSfbiGnzx8sjCa7mkI9ilfM4fz9/MZCOeok6kBPzfXelumKrp0g6hmjuKfLahrbm1kwI h8VQwG9Nb4l/SME1k1gs04tZNGxL8gRhVY2nSr2HtJ2xmv6FZINl6KYCqhwXQsXp0O6h 2oL+6INpXwNvebsEfjV04PE+9hW5pdabmFsKl1O+9rH5FrWNTp/XlHt1KW6ylqn9IM+9 4wkFJ/h48+hfLSCtp0k9R7E/6KhKue2AdXrEufv8hlzUAOAAdXLdy/wOD9XLHBdYXhuf 28+w== X-Gm-Message-State: AElRT7Eqxg6GAC+pE53S02I000wC0W4f3IbiiAFtrgbgloI1aGq+A6u3 0c74d6yWWYOIJ6O3P3z5F8D7aTw9lVcBzTPH7SE= X-Google-Smtp-Source: AG47ELtWsMJ1Po86fruwqKzerqwpINgEYuLdERErj3brsP+JAXeJSYTKZlOgC8zpzni1V8TJR0L0UCQDHqugfXtVqoE= X-Received: by 2002:a19:da1a:: with SMTP id r26-v6mr5701912lfg.76.1521098993397; Thu, 15 Mar 2018 00:29:53 -0700 (PDT) Original-Received: by 10.46.157.146 with HTTP; Thu, 15 Mar 2018 00:29:52 -0700 (PDT) In-Reply-To: <83lgetri7r.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144304 Archived-At: --0000000000002b8c6505676e75a6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 15, 2018 at 2:00 PM, Eli Zaretskii wrote: >> From: Ren Victor >> Date: Thu, 15 Mar 2018 12:15:57 +0800 >> >> Two factors=EF=BC=9A >> >> 1. A commit of Emacs=EF=BC=8C modification-hooks might not be run in= some cases: >> http://git.savannah.gnu.org/cgit/emacs.git/commit/src?id=3D564d81172= 5596f15ecf543777e11504b47d2af86 >> >> 2. In ggtags, an overlay is deleted in the overlay's modification-ho= oks: >> https://github.com/leoliu/ggtags/blob/eec392d2d639030c5a51bce8431f28= 15ad8e7bc5/ggtags.el#L2306 >> >> Deleted overlay ceases to be attached to the buffer. If the buffer of >> the first overlay in the saved array doesn't match the current buffer, >> then all the modification hooks will not be run in this buffer. >> >> Thus modes that depends on modification-hooks won't work together with >> ggtags-highlight-tag mode. >> >> I think Emacs should support `delete-overlay' in modificaiton-hooks of >> overlays, like ggtags. So I report this bug. > > Thanks. Can you provide a recipe starting from "emacs -Q" to > reproduce the problem? I wrote a ert case which is encolsed. emacs -Q -batch -l ert -l bug30823.el -f ert-run-tests-batch-and-exit --0000000000002b8c6505676e75a6 Content-Type: text/x-emacs-lisp; charset="US-ASCII"; name="bug30823.el" Content-Disposition: attachment; filename="bug30823.el" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jes70jr00 KHJlcXVpcmUgJ2VydCkKCihlcnQtZGVmdGVzdCB0ZXN0LW1vZGlmaWNhdGlvbi1ob29rcyAoKQog ICJUZXN0IGZvciBidWcjMzA4MjMuIgogIChsZXQgKChjaGVjay1wb2ludCBuaWwpCgkob3YtZGVs ZXRlIG5pbCkKCShvdi1zZXQgbmlsKSkKICAgICh3aXRoLXRlbXAtYnVmZmVyCiAgICAgIChpbnNl cnQgImFiYyIpCiAgICAgIChzZXRxIG92LXNldCAobWFrZS1vdmVybGF5IDEgMykpCiAgICAgIChv dmVybGF5LXB1dCBvdi1zZXQgJ21vZGlmaWNhdGlvbi1ob29rcwoJCSAgIChsaXN0IChsYW1iZGEg KG8gYWZ0ZXIgJnJlc3QgX2FyZ3MpCgkJCSAgIChhbmQgYWZ0ZXIgKHNldHEgY2hlY2stcG9pbnQg dCkpKSkpCiAgICAgIChzZXRxIG92LWRlbGV0ZSAobWFrZS1vdmVybGF5IDEgMykpCiAgICAgIChv dmVybGF5LXB1dCBvdi1kZWxldGUgJ21vZGlmaWNhdGlvbi1ob29rcwoJCSAgIChsaXN0IChsYW1i ZGEgKG8gYWZ0ZXIgJnJlc3QgX2FyZ3MpCgkJCSAgIChhbmQgKG5vdCBhZnRlcikgKGRlbGV0ZS1v dmVybGF5IG8pKSkpKQogICAgICAoZ290by1jaGFyIDIpCiAgICAgIChpbnNlcnQgIjEiKQogICAg ICAoc2hvdWxkIChlcSBjaGVjay1wb2ludCB0KSkpKSkKCg== --0000000000002b8c6505676e75a6--