From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63260: 29.0.90; Regression installing/activating packages without autoloads Date: Sat, 6 May 2023 14:51:39 +0200 Message-ID: References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <83bkixhm0c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000081dd1a05fb05deef" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37889"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Basil L. Contovounesios" , 63260@debbugs.gnu.org, "Philip K." To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 06 14:52:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvHOb-0009eL-QB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 May 2023 14:52:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvHOS-0003Xe-M4; Sat, 06 May 2023 08:52:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvHOM-0003X8-Ju for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 08:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvHOM-0006sV-6g for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 08:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvHOM-0007Lr-2d for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 08:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 12:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63260 X-GNU-PR-Package: emacs Original-Received: via spool by 63260-submit@debbugs.gnu.org id=B63260.168337752028252 (code B ref 63260); Sat, 06 May 2023 12:52:02 +0000 Original-Received: (at 63260) by debbugs.gnu.org; 6 May 2023 12:52:00 +0000 Original-Received: from localhost ([127.0.0.1]:59637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHOJ-0007Lb-RQ for submit@debbugs.gnu.org; Sat, 06 May 2023 08:52:00 -0400 Original-Received: from mail-lj1-f178.google.com ([209.85.208.178]:60885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHOG-0007LJ-8r for 63260@debbugs.gnu.org; Sat, 06 May 2023 08:51:59 -0400 Original-Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2ac785015d7so31464201fa.1 for <63260@debbugs.gnu.org>; Sat, 06 May 2023 05:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683377510; x=1685969510; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bt+ICshN55yov9ZgkQpwS2HFV0/4OBEy3mf1zZHu7zU=; b=FBsRmMZIV8IxfelnHMfsVnNpx2O9p/Cme8honKTxEtQ1RIjwxgj+Gq5O13Fl+LQlyC B7D+PxxTpqbQ/0Ss8Kq/RX6qtgyWs43POHdrugtbKBr7HPj1T8TYhD92S2kJIhcEaQYK yOCUDPVMwCSNseW+YwDVY3CRCDeefOUw0jYODgmRHzI7W5DKSD+Tnc7XUyvL8LMuTadp 7wjSvI09z6msdYjaf0nYAUPe9rJZ23/6bDAuZoGipoMHm1g593ddVHmNs0uR5axzhFi7 Mi511Iq0JkaUBHfm4C/hniC5VLR7tiijnS2P8OSlBVXjlcKCoCtxcIl01TH0BYL5CbkC 3BKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683377510; x=1685969510; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bt+ICshN55yov9ZgkQpwS2HFV0/4OBEy3mf1zZHu7zU=; b=LAIMo+/WXF/TcfD75S2HvgmvGwV817gTtrm//aFU5XrNtgOYQ3ur0upZCdiHJyFb/Z EoQP5gJoK+o8DHDsZjtDGtKggEsGXhZWrzlIVRaTZABv8k9cQFoZWKfb+z8W8pmsb4+e FkvZGalnVs0pZM59OMYEYiBP8JPHnAdh/5WR5boQDY1des+hizb2z80DuhjD6gu32sB8 GNy90HPL58dBwAXKim5WWNQxsaDNRmhQDAk01PSq8DeaVwGmsWiIAHsEoxPhUDngqw3F 9uHjMp8F01+ZGc7hmDSAY6iNq9N4/B2elaJiUrbHcZhsAmlwe8mw17ctIgmGHH36g2xW 0Kww== X-Gm-Message-State: AC+VfDx+LtFSNH7koH6BDMDdBEmiEXlf3S3FxxaprHPcxWuaNtZH/1xr 8dh6T74cg4VwjWjffbkS9wY/PVZZfU7vhtvPbcc= X-Google-Smtp-Source: ACHHUZ7Z6w1GLpO+ixZeoHCGfk6eAQnxH+iLnHtOUUo8TueulWjhGiaNhD++N1JknMEssqAITADzvyJqdNkHlR9Q3RI= X-Received: by 2002:a2e:6816:0:b0:2ac:7e64:ef8 with SMTP id c22-20020a2e6816000000b002ac7e640ef8mr1280414lja.16.1683377510012; Sat, 06 May 2023 05:51:50 -0700 (PDT) In-Reply-To: <83bkixhm0c.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261190 Archived-At: --00000000000081dd1a05fb05deef Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Please push if it's ok with you, I'm afk until tomorrow Thanks Robert On Sat, May 6, 2023, 11:00 Eli Zaretskii wrote: > > Cc: 63260@debbugs.gnu.org, Philip Kaludercic > > From: Robert Pluim > > Date: Fri, 05 May 2023 08:36:51 +0200 > > > > >>>>> On Thu, 04 May 2023 18:28:47 +0200, Basil Contovounesios < > contovob@tcd.ie> said: > > > > Basil> This does not address the file-missing error during package > activation, > > Basil> but it allows a subsequent package-quickstart-refresh to > complete > > Basil> (albeit with a warning in a *Compile-Log*): > > > > The file-missing error is expected, no? That=CA=BCs why the autoloads > > loading is wrapped in `with-demoted-errors'. Although if the message > bothers > > you, I guess we could check `file-exists-p' for it. > > > > Basil> Compiling file > /tmp/tmp.6cdF8paE0K/.emacs.d/package-quickstart.el > > Basil> at Thu May 4 18:24:07 2023 > > Basil> Entering directory =E2=80=98/tmp/tmp.6cdF8paE0K/.emacs.d/= =E2=80=99 > > Basil> package-quickstart.el:4:2: Warning: Empty let body > > > > Basil> due to the following generated contents of > package-quickstart-file: > > > > Basil> (let ((load-true-file-name nil)(load-file-name nil)) > > Basil> ) > > > > I=CA=BCd claim ENOCOFFEE for the last patch, but it was not the morning= :-) > > > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > > index 0919ce34448..4b488281b78 100644 > > --- a/lisp/emacs-lisp/package.el > > +++ b/lisp/emacs-lisp/package.el > > @@ -4491,11 +4491,11 @@ package-quickstart-refresh > > (insert ";;; Quickstart file to activate all packages at startup > -*- lexical-binding:t -*-\n") > > (insert ";; =C2=A1=C2=A1 This file is autogenerated by > `package-quickstart-refresh', DO NOT EDIT !!\n\n") > > (dolist (pkg package--quickstart-pkgs) > > - (let* ((file > > - ;; Prefer uncompiled files (and don't accept .so files= ). > > - (let ((load-suffixes '(".el" ".elc"))) > > - (locate-library (package--autoloads-file-name pkg)))= ) > > - (pfile (prin1-to-string file))) > > + (when-let* ((file > > + ;; Prefer uncompiled files (and don't accept .so > files). > > + (let ((load-suffixes '(".el" ".elc"))) > > + (locate-library (package--autoloads-file-name > pkg)))) > > + (pfile (prin1-to-string file))) > > (insert "(let ((load-true-file-name " pfile ")\ > > \(load-file-name " pfile "))\n") > > (insert-file-contents file) > > > > Philip, Basil: is the above okay with you? I'd like this issue > resolved before making the next pretest of Emacs 29.1. > > Thanks. > --00000000000081dd1a05fb05deef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Please push if it's ok with you, I'm afk until to= morrow

Thanks

Robert

On Sat, May 6, 2023, 11:00 E= li Zaretskii <eliz@gnu.org> wrote= :
> Cc: 63260@debbugs.gnu.org= , Philip Kaludercic <philipk@posteo.net>
> From: Robert Pluim <rpluim@gmail.com>
> Date: Fri, 05 May 2023 08:36:51 +0200
>
> >>>>> On Thu, 04 May 2023 18:28:47 +0200, Basil Contovo= unesios <contovob@tcd.ie> said:
>
>=C2=A0 =C2=A0 =C2=A0Basil> This does not address the file-missing er= ror during package activation,
>=C2=A0 =C2=A0 =C2=A0Basil> but it allows a subsequent package-quicks= tart-refresh to complete
>=C2=A0 =C2=A0 =C2=A0Basil> (albeit with a warning in a *Compile-Log*= ):
>
> The file-missing error is expected, no? That=CA=BCs why the autoloads<= br> > loading is wrapped in `with-demoted-errors'. Although if the messa= ge bothers
> you, I guess we could check `file-exists-p' for it.
>
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0Compiling file /tmp/tmp.6cdF8= paE0K/.emacs.d/package-quickstart.el
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 at Thu May=C2=A0 4 18:24:07 2023
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0Entering directory =E2=80=98/= tmp/tmp.6cdF8paE0K/.emacs.d/=E2=80=99
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0package-quickstart.el:4:2: Wa= rning: Empty let body
>
>=C2=A0 =C2=A0 =C2=A0Basil> due to the following generated contents o= f package-quickstart-file:
>
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0(let ((load-true-file-name ni= l)(load-file-name nil))
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0)
>
> I=CA=BCd claim ENOCOFFEE for the last patch, but it was not the mornin= g :-)
>
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 0919ce34448..4b488281b78 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -4491,11 +4491,11 @@ package-quickstart-refresh
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (insert ";;; Quickstart file to activa= te all packages at startup=C2=A0 -*- lexical-binding:t -*-\n")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (insert ";; =C2=A1=C2=A1 This file is = autogenerated by `package-quickstart-refresh', DO NOT EDIT !!\n\n"= )
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (dolist (pkg package--quickstart-pkgs)
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let* ((file
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; Prefer unc= ompiled files (and don't accept .so files).
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((load-s= uffixes '(".el" ".elc")))
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (locat= e-library (package--autoloads-file-name pkg))))
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(pfile (prin1-= to-string file)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (when-let* ((file
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0;; Prefer uncompiled files (and don't accept .so files).
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(let ((load-suffixes '(".el" ".elc")))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0(locate-library (package--autoloads-file-name pkg))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (pfile (prin1-to-string file)))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (insert "(let ((load-tru= e-file-name " pfile ")\
>=C2=A0 \(load-file-name " pfile "))\n")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (insert-file-contents file) >

Philip, Basil: is the above okay with you?=C2=A0 I'd like this issue resolved before making the next pretest of Emacs 29.1.

Thanks.
--00000000000081dd1a05fb05deef--