From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Mon, 2 Mar 2015 10:35:50 +0100 Message-ID: References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> <83wq31syvm.fsf@gnu.org> <54F20C96.4020507@cornell.edu> <83vbilsvb5.fsf@gnu.org> <54F221B8.4050909@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bfcf66292635605104af195 X-Trace: ger.gmane.org 1425289041 15083 80.91.229.3 (2 Mar 2015 09:37:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Mar 2015 09:37:21 +0000 (UTC) Cc: 19909@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 02 10:37:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YSMmj-0001NZ-7m for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Mar 2015 10:37:09 +0100 Original-Received: from localhost ([::1]:55788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMmi-0003T1-Fs for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Mar 2015 04:37:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMme-0003Su-F5 for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2015 04:37:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSMmc-0006Bd-VI for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2015 04:37:04 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMmc-0006BU-SD for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2015 04:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YSMmc-0001rD-A5 for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2015 04:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Mar 2015 09:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: Eli Zaretskii , bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14252889647055 (code B ref -1); Mon, 02 Mar 2015 09:37:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Mar 2015 09:36:04 +0000 Original-Received: from localhost ([127.0.0.1]:33809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSMlf-0001pj-By for submit@debbugs.gnu.org; Mon, 02 Mar 2015 04:36:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52201) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSMld-0001pD-FW for submit@debbugs.gnu.org; Mon, 02 Mar 2015 04:36:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSMlW-0005aI-KH for submit@debbugs.gnu.org; Mon, 02 Mar 2015 04:35:55 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:43127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMlW-0005aC-Gg for submit@debbugs.gnu.org; Mon, 02 Mar 2015 04:35:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMlV-0003Qu-5o for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2015 04:35:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSMlT-0005Z4-KB for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2015 04:35:53 -0500 Original-Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:42111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMlT-0005Yi-9i; Mon, 02 Mar 2015 04:35:51 -0500 Original-Received: by wiwh11 with SMTP id h11so13247522wiw.1; Mon, 02 Mar 2015 01:35:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=orR7ZPuyr+egBlT4qXjklqyTCqGIAq4QnJL5Xh6/Fck=; b=DclHV9qJ29IAeLxvA2uAi/Z9H0O6/Ve2pJfa1/x34o7BhYPkezGzIb6KmYV0mRIj+/ NpffVA8vJCFIuq0tIDzS9666gpLPLQjgTN89VOzd2eWtmxuhJEhmzz0tM3x4t4aoBxBR XZe38SRQQQuFTAf1DpL9UPngx3sw7OdF6tUi5K0LCvUhkQtibWN7BH0djW2h6RxEcD20 OqUP8LrVqwOFpKiOk8npd48P/d5v02eQCuHR7fFeqsknqReSzAnKypmDP7I7VIdWrFL1 4yMQU/qFBNipWdphriav2MgTN7yYF0ZAYgx0WhJ3yeGxi7wUdUBIRW/cpXitxCDLuPPg Vm2w== X-Received: by 10.194.90.210 with SMTP id by18mr55137182wjb.80.1425288950078; Mon, 02 Mar 2015 01:35:50 -0800 (PST) Original-Received: by 10.27.198.198 with HTTP; Mon, 2 Mar 2015 01:35:50 -0800 (PST) In-Reply-To: <54F221B8.4050909@cornell.edu> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99951 Archived-At: --047d7bfcf66292635605104af195 Content-Type: text/plain; charset=UTF-8 On Sat, Feb 28, 2015 at 9:14 PM, Ken Brown wrote: > On 2/28/2015 2:14 PM, Eli Zaretskii wrote: > >> Date: Sat, 28 Feb 2015 13:44:38 -0500 >>> From: Ken Brown >>> CC: bug-gnu-emacs@gnu.org >>> >>> No, I meant your reasons for specifying --with-file-notification=w32. >>>> You could only bump into this issue if you specified it, AFAIU. >>>> >>> >>> Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19909#36, I think >>> he specified --with-file-notification=w32 because he wanted file >>> notification and didn't know he could use gfile. >>> >> >> Exactly > Isn't gfile the default for Cygwin? >> > > Yes. (Of course, the builder has to have the appropriate glib development > package installed, or else file notification won't actually be used.) > > I'm inclined to go ahead with the revised patch he submitted in the >>> above URL. I'll commit it (with Robert as author and with the change >>> marked as a "tiny change") if that's OK with you, Eli. >>> >> >> If that's what Cygwin users want, fine with me. >> > > I personally don't care, but Robert requested it, and I don't see any harm > in it. So I'll go ahead as soon as I hear back from him as to how he wants > his name shown. > > 1. Shouldn't the name in the ChangeLog be "Robert Pluim" instead of >>> "rpluim" to match all the other entries? >>> >> >> I don't think it matters when there's no assignment on file. >> > I'd prefer "Robert Pluim" but it's not a big deal. It does show that there's a variable somewhere that I haven't set correctly though, since that ChangeLog entry should never have said "rpluim" > >> 2. I tested making a git commit with >>> >>> --author="Robert Pluim (tiny change)" >>> >>> but git stripped away the "(tiny change)" part. What should I do to get >>> "tiny change" into the git history? Maybe it's not so important now, >>> because I can put it into the ChangeLog, but I'm thinking about the >>> future, when ChangeLogs are automatically generated. >>> >> >> The projects I know of use >> >> Copyright-paperwork-exempt: yes >> >> on a separate line in the log message. You will see that I already >> used that in Emacs, at least once. >> > I'll test the waters with my future employers as to copyright assignment, and this discussion will hopefully not have to happen again :) Regards Robert --047d7bfcf66292635605104af195 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On S= at, Feb 28, 2015 at 9:14 PM, Ken Brown <kbrown@cornell.edu>= wrote:
On 2/28/2015 2:1= 4 PM, Eli Zaretskii wrote:
Date: Sat, 28 Feb 2015 13:44:38 -0500
From: Ken Brown <kbrown@cornell.edu>
CC: bug-gnu-emac= s@gnu.org

No, I meant your reasons for specifying --with-file-notification=3Dw32.
You could only bump into this issue if you specified it, AFAIU.

Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D1= 9909#36, I think
he specified --with-file-notification=3Dw32 because he wanted file
notification and didn't know he could use gfile.


Exactly
= =C2=A0
Isn't gfile the default for Cygwin?

 Yes.=C2=A0 (Of course, the builder has to have the appropriate glib develop= ment package installed, or else file notification won't actually be use= d.)

I'm inclined to go ahead with the revised patch he submitted in the
above URL.=C2=A0 I'll commit it (with Robert as author and with the cha= nge
marked as a "tiny change") if that's OK with you, Eli.

If that's what Cygwin users want, fine with me.

 I personally don't care, but Robert requested it, and I don't see a= ny harm in it.=C2=A0 So I'll go ahead as soon as I hear back from him a= s to how he wants his name shown.

1. Shouldn't the name in the ChangeLog be "Robert Pluim" inst= ead of
"rpluim" to match all the other entries?

I don't think it matters when there's no assignment on file.

I'd prefer "Robe= rt Pluim" but it's not a big deal. It does show that there's a= variable somewhere that I haven't set correctly though, since that Cha= ngeLog entry should never have said "rpluim"
=C2=A0

2. I tested making a git commit with

=C2=A0 =C2=A0 --author=3D"Robert Pluim <rpluim@gmail.com>=C2=A0 (tiny change)&quo= t;

but git stripped away the "(tiny change)" part.=C2=A0 What should= I do to get
"tiny change" into the git history?=C2=A0 Maybe it's not so i= mportant now,
because I can put it into the ChangeLog, but I'm thinking about the
future, when ChangeLogs are automatically generated.

The projects I know of use

=C2=A0 =C2=A0Copyright-paperwork-exempt: yes

on a separate line in the log message.=C2=A0 You will see that I already used that in Emacs, at least once.

I'll tes= t the waters with my future employers as to copyright assignment, and this = discussion will hopefully not have to happen again :)

Regards

Robert
--047d7bfcf66292635605104af195--