From: Robert Pluim <rpluim@gmail.com>
To: Ken Brown <kbrown@cornell.edu>
Cc: 19909@debbugs.gnu.org
Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin
Date: Mon, 2 Mar 2015 10:35:50 +0100 [thread overview]
Message-ID: <CAMTcmTctr8mdZTSJ=Bzkn74ZvD9cjDf5VmVMMp5QpuJ5S_dQ_w@mail.gmail.com> (raw)
In-Reply-To: <54F221B8.4050909@cornell.edu>
[-- Attachment #1: Type: text/plain, Size: 2376 bytes --]
On Sat, Feb 28, 2015 at 9:14 PM, Ken Brown <kbrown@cornell.edu> wrote:
> On 2/28/2015 2:14 PM, Eli Zaretskii wrote:
>
>> Date: Sat, 28 Feb 2015 13:44:38 -0500
>>> From: Ken Brown <kbrown@cornell.edu>
>>> CC: bug-gnu-emacs@gnu.org
>>>
>>> No, I meant your reasons for specifying --with-file-notification=w32.
>>>> You could only bump into this issue if you specified it, AFAIU.
>>>>
>>>
>>> Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19909#36, I think
>>> he specified --with-file-notification=w32 because he wanted file
>>> notification and didn't know he could use gfile.
>>>
>>
>>
Exactly
> Isn't gfile the default for Cygwin?
>>
>
> Yes. (Of course, the builder has to have the appropriate glib development
> package installed, or else file notification won't actually be used.)
>
> I'm inclined to go ahead with the revised patch he submitted in the
>>> above URL. I'll commit it (with Robert as author and with the change
>>> marked as a "tiny change") if that's OK with you, Eli.
>>>
>>
>> If that's what Cygwin users want, fine with me.
>>
>
> I personally don't care, but Robert requested it, and I don't see any harm
> in it. So I'll go ahead as soon as I hear back from him as to how he wants
> his name shown.
>
> 1. Shouldn't the name in the ChangeLog be "Robert Pluim" instead of
>>> "rpluim" to match all the other entries?
>>>
>>
>> I don't think it matters when there's no assignment on file.
>>
>
I'd prefer "Robert Pluim" but it's not a big deal. It does show that
there's a variable somewhere that I haven't set correctly though, since
that ChangeLog entry should never have said "rpluim"
>
>> 2. I tested making a git commit with
>>>
>>> --author="Robert Pluim <rpluim@gmail.com> (tiny change)"
>>>
>>> but git stripped away the "(tiny change)" part. What should I do to get
>>> "tiny change" into the git history? Maybe it's not so important now,
>>> because I can put it into the ChangeLog, but I'm thinking about the
>>> future, when ChangeLogs are automatically generated.
>>>
>>
>> The projects I know of use
>>
>> Copyright-paperwork-exempt: yes
>>
>> on a separate line in the log message. You will see that I already
>> used that in Emacs, at least once.
>>
>
I'll test the waters with my future employers as to copyright assignment,
and this discussion will hopefully not have to happen again :)
Regards
Robert
[-- Attachment #2: Type: text/html, Size: 4898 bytes --]
next prev parent reply other threads:[~2015-03-02 9:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 9:47 bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Robert Pluim
2015-02-20 10:06 ` Eli Zaretskii
2015-02-20 10:19 ` Robert Pluim
2015-02-20 10:46 ` Eli Zaretskii
2015-02-20 14:16 ` Robert Pluim
2015-02-20 15:10 ` Eli Zaretskii
2015-02-20 15:46 ` Robert Pluim
2015-02-20 16:17 ` Eli Zaretskii
2015-02-20 16:44 ` Robert Pluim
2015-02-20 17:16 ` Eli Zaretskii
2015-02-20 16:15 ` Ken Brown
2015-02-20 17:06 ` Robert Pluim
2015-02-20 17:18 ` Eli Zaretskii
2015-02-27 22:25 ` Ken Brown
2015-02-28 7:59 ` Eli Zaretskii
2015-02-28 16:32 ` Ken Brown
2015-02-28 16:41 ` Eli Zaretskii
2015-02-28 16:53 ` Robert Pluim
2015-02-28 16:56 ` Robert Pluim
2015-02-28 17:57 ` Eli Zaretskii
2015-02-28 18:44 ` Ken Brown
2015-02-28 19:14 ` Eli Zaretskii
2015-02-28 20:14 ` Ken Brown
2015-03-02 9:35 ` Robert Pluim [this message]
2015-03-02 14:05 ` Ken Brown
2015-03-02 14:06 ` bug#19909: closed (Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin) GNU bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMTcmTctr8mdZTSJ=Bzkn74ZvD9cjDf5VmVMMp5QpuJ5S_dQ_w@mail.gmail.com' \
--to=rpluim@gmail.com \
--cc=19909@debbugs.gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).