From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0) Date: Wed, 19 Feb 2020 09:59:21 +0100 Message-ID: References: <87h7zoorys.fsf@thb.lt> <87lfozsuoi.fsf@thb.lt> <83pneblloc.fsf@gnu.org> <83lfozlkmt.fsf@gnu.org> <8c68006d-54b5-7fd5-128a-c253b4899cde@yandex.ru> <83k14jl0j8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000b0556c059eea0174" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="17151"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39662@debbugs.gnu.org, Thibault Polge , Dmitry Gutov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 19 10:00:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4LDO-0004Ka-OC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 10:00:18 +0100 Original-Received: from localhost ([::1]:47542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4LDN-0006Z3-QV for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 04:00:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39831) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4LDA-0006Yd-ER for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 04:00:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4LD9-0001ud-Bg for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 04:00:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35657) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4LD9-0001tz-7w for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 04:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4LD8-0005Jh-DJ for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 04:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Feb 2020 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39662 X-GNU-PR-Package: emacs Original-Received: via spool by 39662-submit@debbugs.gnu.org id=B39662.158210278020379 (code B ref 39662); Wed, 19 Feb 2020 09:00:02 +0000 Original-Received: (at 39662) by debbugs.gnu.org; 19 Feb 2020 08:59:40 +0000 Original-Received: from localhost ([127.0.0.1]:41630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4LCl-0005Ic-Op for submit@debbugs.gnu.org; Wed, 19 Feb 2020 03:59:39 -0500 Original-Received: from mail-io1-f49.google.com ([209.85.166.49]:39237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4LCj-0005IQ-CH for 39662@debbugs.gnu.org; Wed, 19 Feb 2020 03:59:37 -0500 Original-Received: by mail-io1-f49.google.com with SMTP id c16so25552251ioh.6 for <39662@debbugs.gnu.org>; Wed, 19 Feb 2020 00:59:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WMli0tAPsz/qRqVkiuASsLpDrF6vzAu/nzqWCqjNzCI=; b=E9Wla9/yKvL3brG7eJbkNc6P+TcMq4rtH+CvJWtsxyB9HoXepltcbkIeZylam6XJ4p bDuJrYQmlDmaWJ3e31exihAezkoe1pyeQN5A1WO+pJr+CeXeQBRM0flBpfzJkI52j9o2 0XCPuiCVvaAKIH3N2BlxALKu2OXxWA+rHDyQg9spYujP20lK8g5iidlj61ZPIqBSVpCw aRd7FNXzLKrW/yPGcS+tAXlaE40zhz3vKkdNkAcn3NT8G/CbpMEWpU6OsqCvROnAq93O u8Qq2aVoTQvTIJKJzs5klGNtda3Z2hZJZ5U+0HNP4/MvtaxktWCWSMx7aU+gI0iRw7G7 1SXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WMli0tAPsz/qRqVkiuASsLpDrF6vzAu/nzqWCqjNzCI=; b=nrwJSPp/+zOLrtMgpODb13rr3fDoDL0dr+SJMYkCEubovti2eNBiRz6Czhiy2Lx9tV uXgexTSdyJBVmidxF6ZttOjG+l7307RtA4/oLlLzjKEmEPL4C422hHmFi3f5sKBvBXb7 gaaG09khvIdyEk4AkDbx6QYz5EJW3OKrKIFVaMv4lP4XVaY6eDKFS2kOTGef/girApgg 5RvyAAMxnxsD9sRMk0NxODejtbOd585V5R3eEkJh86ozX3L8VZCIvCOPXKUloLvDbOEz JUh1mpM85Q3B9eQcYMOjGbK45CfRF8X1KIBDdXlrTVSc/6PvKtHJroVJVqmwCzAOnC6O CgwA== X-Gm-Message-State: APjAAAXageBzOLo7PSZhh4loBctYKVTJvMmo/4PNJ2JMLGEMui9D9yS+ b1GQuz/hUBpCzIrcG3Cv3uAewoGv+1jWpTWsod0= X-Google-Smtp-Source: APXvYqw7dlMzTBTLx6uefggUr34cNbnag3HPUrhJL6/n2glbpn2TvVbhagjfvyhQkmqZACeSWqAJ8voCg6jlLQlnnFg= X-Received: by 2002:a5e:d602:: with SMTP id w2mr17852951iom.94.1582102771421; Wed, 19 Feb 2020 00:59:31 -0800 (PST) In-Reply-To: <83k14jl0j8.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176238 Archived-At: --000000000000b0556c059eea0174 Content-Type: text/plain; charset="UTF-8" On Wed, 19 Feb 2020, 04:27 Eli Zaretskii, wrote: > I thought in the scenario we are discussing there will be no bitmaps > shown at all, since the scenario disables the fringes. Isn't that so? > If the user turns fringe-mode back on, diff-hl will use the previously created bitmaps, which will be width 1 if define-fringe-bitmap decides to use that instead of zero, or will crash if x_cr_define_fringe_bitmap does not define the bitmap when width == 0 Maybe signaling an error is best :-) > --000000000000b0556c059eea0174 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Wed, 19 Feb 2020, 04:27 Eli Zaretskii, <eliz@gnu.org> wrote:
I thought in the scenario we are discussing there will be no bitmaps
shown at all, since the scenario disables the fringes.=C2=A0 Isn't that= so?

If the user turns fringe-mode back on, diff-hl will use the previously = created bitmaps, which will be width 1 if define-fringe-bitmap decides to u= se that instead of zero, or will crash if x_cr_define_fringe_bitmap does no= t define the bitmap when width =3D=3D 0

Maybe signaling an error is best :-)
--000000000000b0556c059eea0174--