From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ioannis Kappas Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Sat, 1 May 2021 12:38:41 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000036ac9c05c1432c47" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18359"; mail-complaints-to="usenet@ciao.gmane.io" To: 48137@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 01 13:40:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcnz4-0004h4-49 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 May 2021 13:40:30 +0200 Original-Received: from localhost ([::1]:50098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcnz3-0001eN-5C for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 May 2021 07:40:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcnyd-0001eF-58 for bug-gnu-emacs@gnu.org; Sat, 01 May 2021 07:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51869) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcnyc-0007rF-SJ for bug-gnu-emacs@gnu.org; Sat, 01 May 2021 07:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lcnyc-0003JY-OY for bug-gnu-emacs@gnu.org; Sat, 01 May 2021 07:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ioannis Kappas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 May 2021 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48137 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161986914512328 (code B ref -1); Sat, 01 May 2021 11:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 May 2021 11:39:05 +0000 Original-Received: from localhost ([127.0.0.1]:35174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcnxh-0003Ck-AR for submit@debbugs.gnu.org; Sat, 01 May 2021 07:39:05 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcnxe-0003CM-SS for submit@debbugs.gnu.org; Sat, 01 May 2021 07:39:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcnxe-0001bl-JE for bug-gnu-emacs@gnu.org; Sat, 01 May 2021 07:39:02 -0400 Original-Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:45845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcnxb-0007MP-0k for bug-gnu-emacs@gnu.org; Sat, 01 May 2021 07:39:02 -0400 Original-Received: by mail-ot1-x332.google.com with SMTP id f75-20020a9d03d10000b0290280def9ab76so852157otf.12 for ; Sat, 01 May 2021 04:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=rpYVM8qdoaMmL6C7iA3fkRwQX8AsUpzNPrnDOORZ6Kg=; b=iFlEMKHi8S07Xu8LDqleq2zquxBxcrjzFMIbXXaMM2GousRxqQ8RuHv4Nm5rYmeKlV EvAVFeleZzZa9VIEbfSBTdaokDj5IcevwizAxwTHvjQcdnt+UzB4y8M+jxaanD1wHrdU UvYxQ+1qwfXH3pB+ELVZ9ZyapVcDmtQD+FuTwSiGwKvPQJek87vm7EZvvBfg/N2n/xWv dP1gNOrAhpj8+sTvbNa+ZNol1GR/E1reMZobwWUovlzIrrw29LK+9m2yPvWJimvJdgAc /6/rsoX2abZXsRGNEY+u3/PHAIqq2g2xlI04KO3aPg9xG5GhDZzNclA/ffhfvQo70k5j FODw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=rpYVM8qdoaMmL6C7iA3fkRwQX8AsUpzNPrnDOORZ6Kg=; b=lg9yiq6dw7WjQPOscyw8qq1IXX0aO5Ax9IySOxNFHOihXgWYKCXSmOhLv/YThysaHf EEIDjkaoJtXYT3AQ56nF7sOR3z9Leyfj2jYBaTn7QZojqSmQ0tGSGZolHXLla71bGMdw Ku612dlKLDujUEcD+O3cRCKZhV5O/invousqcg0i06yVUdD4TcqSqHFMxUhG35rVYYun UT627zlejCtzapF0YHaOkRDlw2Z5NHS1r3jdDtuE5fI4DJOsu9+3FattKG7k4pMEieVX r18RRs9+qmJ9lwXMNbqxupGlsbVhqc3JY5uHjXjKWDXtGowbVjje4Qm0Tr+LJe/5p9Sy 5O6g== X-Gm-Message-State: AOAM532OAQdlrU93sxNMT6toHUCwu1toiGRGQ6dQoBy0OrTXmF8rqKAz p/tD+Or2EdznQXUOtBWMU1hB+xQ9ZaQYgsgBtrM54oiNHec= X-Google-Smtp-Source: ABdhPJwSoVj/rF0vGTmeLInoPL7PQP6Yye71asq8d1yTtzpEs9FmQrOkBtqC+51D3xQvCSF0/D/29+ie042MCpLOgOs= X-Received: by 2002:a9d:2de1:: with SMTP id g88mr7730182otb.5.1619869132232; Sat, 01 May 2021 04:38:52 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::332; envelope-from=ioannis.kappas@gmail.com; helo=mail-ot1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205335 Archived-At: --00000000000036ac9c05c1432c47 Content-Type: multipart/alternative; boundary="00000000000036ac9805c1432c45" --00000000000036ac9805c1432c45 Content-Type: text/plain; charset="UTF-8" There is an issue with `package-install-file' that fails with the following error when trying to install a file written with DOS line endings: error: Package lacks a "Version" or "Package-Version" header (This is more apparent on MS-Windows which writes files with DOS line endings by default) To reproduce, create a minimal package file with Emacs on MS-Windows and write it to disk as package-install-file-test-win.el: ;;; package-install-file-test-win.el --- test issue ;; Version: 0.1 (provide 'package-install-file-test-win) ;;; package-install-file-test-win.el ends here Then M-x package-install-file RET package-install-file-test-win.el RET and it should produce the error. The above succeeds on GNU/Linux and installs the dummy package as expected. I have attached an ert test to do the same. The test fail on windows and succeeds on Linux. You can run it from command line as: : emacs -Q --batch -l ert -l ./issue-package-install-file-test.el -f ert-run-tests-batch The cause appears to be that 'package can't handle package files encoded with DOS line endings. Analysis to follow. --00000000000036ac9805c1432c45 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
There is an issue with `package-inst= all-file' that fails with the
following error when trying to = install a file written with DOS line
endings:

error: Package lacks a "Version" or "Package-Version&q= uot; header

(This is more apparent on MS-Windows w= hich writes files with DOS line
endings by default)
To reproduce, create a minimal package file with Emacs on MS-Wi= ndows
and write it to disk as package-install-file-test-win.el:

;;; package-install-file-test-win.el --- test issue= =C2=A0

;; Version: 0.1

(p= rovide 'package-install-file-test-win)

;;; pac= kage-install-file-test-win.el ends here


=
Then M-x package-install-file RET package-install-file-test-win.el RET=

and it should produce the error.

The above succeeds on GNU/Linux and installs the dummy package as<= /div>
expected.

I have attached an ert test to= do the same. The test fail on windows
and succeeds on Linux.

You can run it from command line as:

: emacs -Q --batch -l ert -l ./issue-package-install-file-test.el = -f ert-run-tests-batch

The cause appears to be tha= t 'package can't handle package files
encoded with DOS li= ne endings. Analysis to follow.

--00000000000036ac9805c1432c45-- --00000000000036ac9c05c1432c47 Content-Type: application/octet-stream; name="issue-package-install-file-test.el" Content-Disposition: attachment; filename="issue-package-install-file-test.el" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ko5o5gxd0 Ozs7IC0qLSBsZXhpY2FsLWJpbmRpbmc6IHQ7IC0qLQ0KKHJlcXVpcmUgJ2VydCkNCg0KKGRlZmNv bnN0IHRlc3QvcGFja2FnZSAiOzs7IHBhY2thZ2UtaW5zdGFsbC1maWxlLXRlc3Qtd2luLmVsIC0t LSB0ZXN0IGlzc3VlIA0KDQo7OyBWZXJzaW9uOiAwLjENCg0KKGRlZnVuIHBhY2thZ2UtaW5zdGFs bC1maWxlLXRlc3Qtd2luLzUgKCkgNSkNCg0KKHByb3ZpZGUgJ3BhY2thZ2UtaW5zdGFsbC1maWxl LXRlc3Qtd2luKQ0KDQo7OzsgcGFja2FnZS1pbnN0YWxsLWZpbGUtdGVzdC13aW4uZWwgZW5kcyBo ZXJlDQoiDQogICJNaW5pbWFsIHRlc3QgcGFja2FnZSBmaWxlIikNCg0KKGVydC1kZWZ0ZXN0IHBh Y2thZ2UtaW5zdGFsbC1maWxlICgpDQogICJUZXN0IHRoYXQgcGFja2FnZSBpbnN0YWxsIGZpbGUg d29ya3Mgb24gYSBtaW5pbWFsIHBhY2thZ2UgZmlsZQ0Kd3JpdHRlbiB0byBkaXNrIGJ5IEVtYWNz LiINCiAgKG1lc3NhZ2UgIjpzeXN0ZW0gJXMgOnZlcnNpb24gJXMiIHN5c3RlbS1jb25maWd1cmF0 aW9uIGVtYWNzLXZlcnNpb24pDQoNCiAgKGxldCogKCh0ZW1wLWRpciAobWFrZS10ZW1wLWZpbGUg InBhY2thZ2UtaW5zdGFsbC1maWxlLXRlc3Qtd2luIiB0KSkNCiAgICAgICAgIChwYWNrYWdlLXBh dGggKGV4cGFuZC1maWxlLW5hbWUNCiAgICAgICAgICAgICAgICAgICAgICAgICJwYWNrYWdlLWlu c3RhbGwtZmlsZS10ZXN0LXdpbi5lbCINCiAgICAgICAgICAgICAgICAgICAgICAgIHRlbXAtZGly KSkpDQogICAgOzsgd3JpdGUgZmlsZSBpbiB0aGUgZGVmYXVsdCBlbmNvZGluZw0KICAgICh3aXRo LXRlbXAtYnVmZmVyDQogICAgICAoaW5zZXJ0IHRlc3QvcGFja2FnZSkNCiAgICAgICh3cml0ZS1y ZWdpb24gKHBvaW50LW1pbikgKHBvaW50LW1heCkgcGFja2FnZS1wYXRoKSkNCiAgICAobWVzc2Fn ZSAiOnBhY2thZ2UtZmlsZS1jcmVhdGVkLWF0ICVzIiBwYWNrYWdlLXBhdGgpDQoNCiAgICA7OyBy ZXBvcnQgb24gZmlsZSBlbmNvZGluZw0KICAgICh3aXRoLXRlbXAtYnVmZmVyDQogICAgICAoaW5z ZXJ0LWZpbGUtY29udGVudHMgcGFja2FnZS1wYXRoKQ0KICAgICAgKGxldCogKChjb250ZW50cyAo YnVmZmVyLXN0cmluZykpKQ0KICAgICAgICAobWVzc2FnZSAiOnBhY2thZ2UtZmlsZS1jb2Rpbmct c3lzdGVtICVzIiBidWZmZXItZmlsZS1jb2Rpbmctc3lzdGVtKSkpDQoNCiAgICA7OyBpbnN0YWxs IHBhY2thZ2UNCiAgICAocGFja2FnZS1pbnN0YWxsLWZpbGUgcGFja2FnZS1wYXRoKQ0KICAgIChk ZWxldGUtZGlyZWN0b3J5IHRlbXAtZGlyIHQpDQoNCiAgICANCiAgICA7OyBjYWxsIGR1bW15IGZ1 bmN0aW9uDQogICAgKHJlcXVpcmUgJ3BhY2thZ2UtaW5zdGFsbC1maWxlLXRlc3Qtd2luKQ0KICAg IChzaG91bGQgKGVxdWFsIDUgKHBhY2thZ2UtaW5zdGFsbC1maWxlLXRlc3Qtd2luLzUpKSkNCg0K ICAgIDs7IHJlbW92ZSBwYWNrYWdlDQogICAgKHBhY2thZ2UtZGVsZXRlIChjYWRyIChhc3NxICdw YWNrYWdlLWluc3RhbGwtZmlsZS10ZXN0LXdpbiBwYWNrYWdlLWFsaXN0KSkpKSkNCg== --00000000000036ac9c05c1432c47--