From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ioannis Kappas Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Wed, 5 May 2021 08:03:17 +0100 Message-ID: References: <834kfmabvs.fsf@gnu.org> <83tunj651i.fsf@gnu.org> <83lf8u68bu.fsf@gnu.org> <83mtta4gtf.fsf@gnu.org> <83fsz24f2x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14277"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48137@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 09:10:58 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leBgP-0003aS-CZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 09:10:57 +0200 Original-Received: from localhost ([::1]:36834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leBgO-0002sr-8L for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 03:10:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leBZi-0003oa-Op for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 03:04:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leBZi-0007v0-HL for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 03:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leBZi-0004Nf-D4 for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 03:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ioannis Kappas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 07:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.162019822516832 (code B ref 48137); Wed, 05 May 2021 07:04:02 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 5 May 2021 07:03:45 +0000 Original-Received: from localhost ([127.0.0.1]:58124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leBZR-0004NQ-4D for submit@debbugs.gnu.org; Wed, 05 May 2021 03:03:45 -0400 Original-Received: from mail-ot1-f46.google.com ([209.85.210.46]:42847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leBZC-0004NJ-CG for 48137@debbugs.gnu.org; Wed, 05 May 2021 03:03:44 -0400 Original-Received: by mail-ot1-f46.google.com with SMTP id g15-20020a9d128f0000b02902a7d7a7bb6eso844045otg.9 for <48137@debbugs.gnu.org>; Wed, 05 May 2021 00:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fyBVRY6T3B6aGGU4F2kWRj5X695bauNehWFaJkx3sts=; b=qwtaBUpoHph7lBVKnlXHqz9yC6dy71bXaJcF6mpSJwVKMdIMXWZSaX5ayZEtKTBHDb ZuDQEUoOd/hfQ95jlU+zjkTL1bIvK72TXXRHMUXLsLXRKe/hbG3LodH3oA+9/lYZ+2CS PzEHi2XXVf3c3B3DVazn7lYbhg77zOjjQpCoLwZHjciwfCU+l7SK6kipJ3lkJORySpJm ywTZIHxZTuT2IajWqcQ7vmWPv7RLAkkZkKpAetOiMzoPk6tKKmsfZsGVeajgyQ9GTCWh yYO4AdPk/Y8aFwMkaHltj0akctyQ+QXKzISiBTalY9tzTWXdhxA3CDVI2DL3YIUCNCrk kNQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fyBVRY6T3B6aGGU4F2kWRj5X695bauNehWFaJkx3sts=; b=NO2qJi7QU78JPpU4ZlMZ+p2lM6QBlsinC9Lg+u/oxyh1CyhmBFRX6mBHKLH4QpXb6T rx3XPAmd8iyJBOCHvJ+U5PcFk+CEj6Skb7Wz17dqmnNBRZOgt3/b/QuiKHy7KWiPQud7 0jdY3ZgvgtAXUbxUX3wI3Dtqie/37+I60ZH7kjrCUaR06vaNNTNgLmUcd1XmXg0SMlBs 0DuICNusJx7GIzXAV6wuyT1oQEFtn4xNUp5v+MzNy5z7sLOh6tuygNvAiBlosNdwc/ao PPSAjdy377jISz6pYfe0ecyaO/hEfizMwpUtXfoaJWI1SwBiiYtG+ATzzjcDVAG9zF/z TC1w== X-Gm-Message-State: AOAM532laFXLE0EFjPMaiM4rFfoKK4d2ewvAwrc9t4G0ae2oURy/F9rc Xx958USmdOK95eZW9efwC96jFEmSEmcb1u6N2FE= X-Google-Smtp-Source: ABdhPJxCS8NpreKY+XS0RELdZ9YiNqEDlP3R/JLtqvZyGSugjy8pdH32LSGlibqj7U27YjGHi/MxRf5Yb0ixtesvbYY= X-Received: by 2002:a9d:2de1:: with SMTP id g88mr23782355otb.5.1620198204719; Wed, 05 May 2021 00:03:24 -0700 (PDT) In-Reply-To: <83fsz24f2x.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205656 Archived-At: On Tue, May 4, 2021 at 5:52 PM Eli Zaretskii wrote: > > > From: Stefan Monnier > > Cc: ioannis.kappas@gmail.com, 48137@debbugs.gnu.org > > Date: Tue, 04 May 2021 12:27:37 -0400 > > > > >> I agree that in principle it would be better to copy the file by copying > > >> its bytes than by `insert-file-contents + write-region`. > > > Why only "in principle"? what prevents us from actually doing that? > > > > Someone willing to take the time and rework the code accordingly? > > I thought that's Ioannis? I can have a look. Currently, `package-install-file' reads the package contents into a buffer and calls `package-install-from-buffer' to parse the headers, download & install its dependencies, and finally install the package itself from the buffer. Just to confirm, what we are discussing as a solution (at a high level) is to parse the package headers from a decoded buffer, download & install its dependencies, and copy/extract the package file to the elpa user dir? Thanks